Forumist [deleted] Could you confirm the update below fixes your issue?
Update 1.3.1 - Fixing the update
Okay, so let's explain what happened in the previous update. I tried (a bit on a hacky way) to process all the SEO properties as last function before rendering the page. Aparently it worked well on localhost
and on my production forums without any issues, but it didn't on some other production forums.
Therefore I've now updated the position when the ->finish()
function is called. The extender (Extend.php
) has left untouched and will still work for other extensions to extend SEO. It might be that, in situations when the SEO extension was called earlier then other extensions, the SEO extender isn't processed (the reason is that it was already processed and the tags have been written to the page).
I'm not very satisfied with reverting some code, so I'll try to open a PR into for the Flarum core later this week to make sure an event fires after all the other extensions are finished updating the content
of the webpage. Hopefully it will be merged into BETA 14 and the previous SEO update has its full potential in this version 🙂 There is an issue from someone also having the same issue: flarum/core2239
Changelog:
- Fixed v17development/flarum-seo34 . The description was set as headline. Also added a parameter to the
setTitle
API and removed a parameter from and setDescription
in Extend.php
- Reverted some code because it was breaking on some forums 🙁
How to update?
To update, run:
composer update v17development/flarum-seo
To install, run:
composer require v17development/flarum-seo
If there are any issues, or you have any feedback, let me know on GitHub! Also, pull requests are also appreciated 🙂