Flarum SEO

010101

JasperVriends Very cool! Yes, uninstall elint before upgrading, everyone (if you use it). I’ll pop a disclaimer over on that thread. I won’t fully discontinue elint just in case for some strange reason someone doesn’t want to use this SEO extension, but they want the external/internal links feature. I don’t know why someone wouldn’t want this SEO extension, but you never know. 🤷‍♂️

MikeJones

JasperVriends awesome! So excited for the "do follow links" you are the man!

MikeJones

@JasperVriends When I opened the do follow settings for the first time it had my domain in there automatically which was a nice touch but it was typed in like this:

://www.seekadventure.net

should I change it to:

seekadventure.net

I also just got this error in Sentry that looks related to do follow:

JasperVriends

MikeJones oh woops. No that's not necessary, it's just a placeholder generated via JavaScript for something that's automatically being added in the backend 😃

I'll fix the displayed domain in the next version 😛

JasperVriends

MikeJones Ah i see, thanks for the bug report!

askvortsov The confict has already been added to the composer.json 😃

JasperVriends

Update v1.6.2

Fixed the two bugs found by MikeJones and added franzliedke/flarum-open-links-in-new-tab to the composer.json conflict.

To update, run:

composer update v17development/flarum-seo

MikeJones No need to, I've just tagged v1.6.2 🙂

matteocontrini Does this conflict with franzliedke/flarum-open-links-in-new-tab as well)?

Oh... I didn't knew about that one... Yes it does indeed, I added it to the composer.json conflict 🙂

askvortsov

JasperVriends This extension (or elint) should be able to specify the other in composer.json under conflicts, that would prevent both from being installed, which is easier than relying on people to remember.

rob006

askvortsov I don't think that using conflict is correct here. It will prevent installing both these extensions at the same time, while you really need to prevent enabling these extensions at the same time. It will mess up with setups like in FreeFlarum, where bunch of extensions is installed and user can pick which he wants to use. With conflict you can't provide both these extensions.

Conflicts should probably be handled at Flarum level, when extension is enabled - you may provide better info what is the problem (output from Composer is pretty cryptic, especially for non-technical users) and prevent problems like this:

JasperVriends added franzliedke/flarum-open-links-in-new-tab to the composer.json conflict

That could make it worse than before. Now if you you have franzliedke/flarum-open-links-in-new-tab installed, Composer will just silently install older (v1.6.1) release, which has known bugs and also does not work with franzliedke/flarum-open-links-in-new-tab.

MikeJones

JasperVriends no problem. Should I disable extension until it is fixed?

matteocontrini

JasperVriends Another new feature is the external links in new tab functionality. As were already mapping trough the links for the nofollow feature, we made sure all external links open in a new tab. Internal links from your forum will still open inside the same window as usual.

This unfortunately does mean that this extension now has a conflict with @010101 's elint extension.

Does this conflict with franzliedke/flarum-open-links-in-new-tab as well? 🙂

MikeJones

JasperVriends damn your quick! Much appreciated!

askvortsov

rob006 Ah that's a really good point. There's plans in place for Flarum-driven optional dependencies (if A is an optional dependency of B, and both are enabled, boot A before B always), conflicts could be a good addition too. Especially if we eventually build in some form of GUI for managing extensions via composer to Flarum.

JasperVriends

rob006 askvortsov Interesting. Good points. What would you guys recommend to do now?

clarkwinkelmann

I am using conflict for similar situations myself. I feel like it makes sense for most self-hosted forums to use that attribute, as it's an extra layer of protection. Generally speaking, it's safer to not keep disabled extensions installed if you don't plan to use them again anyway, since it only increases the (slight) risk of a security issue through that dormant and possibly outdated code.

I'm not sure how, but I suppose there must be a workaround for managed hostings that want to provide conflicting extensions. At the last resort they could use a modified Composer client that ignores conflict and replace it with a check in Flarum itself during extension enabling.

Same applies to replace by the way. I've also used that one on quite a few extensions.

rob006

clarkwinkelmann I am using conflict for similar situations myself. I feel like it makes sense for most self-hosted forums to use that attribute, as it's an extra layer of protection.

It is inconvenient in such cases too - if you want to test 2 conflicting extensions, you need to completely uninstall one of them before second can be installed.

clarkwinkelmann Same applies to replace by the way. I've also used that one on quite a few extensions.

replace is way worse than conflict 😃. It means that your extension provides all classes existing in replaced extension. So unless you created fork with only minor changes, using replace is incorrect.

matteocontrini

@JasperVriends hello, I have a custom BBcode where the generated output contains a link with target="_blank", however it seems that this extension is overriding that target attribute, which becomes blank. (The link is to another subdomain on the same 2nd level domain.)

Could you make it so that the "target" is not changed when it's already set?

Thank you.

matteocontrini

@JasperVriends sorry to ping you, but could you take a look at the problem above when you get the chance? 🙂 I have a custom BBcode that shows images with a link with target="_blank", but this extension is removing the target and I have no control over it at all, which is very annoying.

JasperVriends

matteocontrini No problem, thanks for the reminder 👀 I'll work on an update tomorrow! If there is anything else, let me know 🙂

matteocontrini

JasperVriends o problem, thanks for the reminder 👀 I'll work on an update tomorrow! If there is anything else, let me know

Hi, I guess I'm here to annoy you again... 😅

Justman10000

I installed this! In response from the instance, only this came:

askvortsov

Justman10000 Check your storage/logs directory for error messages

« Previous Page Next Page »