Flarum SEO

matteocontrini

JasperVriends o problem, thanks for the reminder 👀 I'll work on an update tomorrow! If there is anything else, let me know

Hi, I guess I'm here to annoy you again... 😅

Debaucus

Most phones and browsers such as Firefox use the apple-icon as the icon for a display. An example is like so -

A github example of implementation -

Might be something to add?

[deleted]

How can I solve that

ctml

[deleted]

JasperVriends External links in new tab
Another new feature is the external links in new tab functionality. As were already mapping trough the links for the nofollow feature, we made sure all external links open in a new tab. Internal links from your forum will still open inside the same window as usual.

This unfortunately does mean that this extension now has a conflict with @010101 's elint extension.

Remove the elint extension, this extension provides the same functionality.

JasperVriends

Update v1.7.0 - Start of refactoring & beta-16

In this update I've started on refactoring the extension a bit, making it easier to maintain and future-proof. Some other parts in the backend will change even more, but this will be done in a newer version.

Also, the extension is now checked and updated for beta-16. If you experience any issue, please open an issue on GitHub.

Changelog:

Refactored parts of the code
Beta-16 ready
Skips target if it has already been set (issue reported by @matteocontrini )

To update, run:

composer update v17development/flarum-seo

⚠️ Keep in mind this update is beta-16 only

This update took some time, other V17 extensions will be updated this weekend

StarsRiver

JasperVriends An error was encountered.

[2021-03-20 02:51:15] flarum.ERROR: RuntimeException: Route pages.index on method POST already exists in /www/wwwroot/flarum/vendor/flarum/core/src/Http/RouteCollection.php:77
Stack trace:
#0 /www/wwwroot/flarum/vendor/flarum/core/src/Extend/Routes.php(94): Flarum\Http\RouteCollection->addRoute()
#1 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(1226): Flarum\Extend\Routes->Flarum\Extend\{closure}()
#2 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(1172): Illuminate\Container\Container->fireCallbackArray()
#3 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(734): Illuminate\Container\Container->fireResolvingCallbacks()
#4 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(652): Illuminate\Container\Container->resolve()
#5 /www/wwwroot/flarum/vendor/flarum/core/src/Api/ApiServiceProvider.php(34): Illuminate\Container\Container->make()
#6 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(723): Flarum\Api\ApiServiceProvider->Flarum\Api\{closure}()
#7 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(652): Illuminate\Container\Container->resolve()
#8 /www/wwwroot/flarum/vendor/flarum/core/src/Frontend/FrontendServiceProvider.php(70): Illuminate\Container\Container->make()
#9 /www/wwwroot/flarum/vendor/illuminate/container/BoundMethod.php(36): Flarum\Frontend\FrontendServiceProvider->boot()
#10 /www/wwwroot/flarum/vendor/illuminate/container/Util.php(40): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()
#11 /www/wwwroot/flarum/vendor/illuminate/container/BoundMethod.php(93): Illuminate\Container\Util::unwrapIfClosure()
#12 /www/wwwroot/flarum/vendor/illuminate/container/BoundMethod.php(37): Illuminate\Container\BoundMethod::callBoundMethod()
#13 /www/wwwroot/flarum/vendor/illuminate/container/Container.php(611): Illuminate\Container\BoundMethod::call()
#14 /www/wwwroot/flarum/vendor/flarum/core/src/Foundation/Application.php(289): Illuminate\Container\Container->call()
#15 /www/wwwroot/flarum/vendor/flarum/core/src/Foundation/Application.php(272): Flarum\Foundation\Application->bootProvider()
#16 [internal function]: Flarum\Foundation\Application->Flarum\Foundation\{closure}()
#17 /www/wwwroot/flarum/vendor/flarum/core/src/Foundation/Application.php(273): array_walk()
#18 /www/wwwroot/flarum/vendor/flarum/core/src/Foundation/InstalledSite.php(150): Flarum\Foundation\Application->boot()
#19 /www/wwwroot/flarum/vendor/flarum/core/src/Foundation/InstalledSite.php(82): Flarum\Foundation\InstalledSite->bootLaravel()
#20 /www/wwwroot/flarum/vendor/flarum/core/src/Http/Server.php(58): Flarum\Foundation\InstalledSite->bootApp()
#21 /www/wwwroot/flarum/vendor/flarum/core/src/Http/Server.php(35): Flarum\Http\Server->safelyBootAndGetHandler()
#22 /www/wwwroot/flarum/public/index.php(26): Flarum\Http\Server->listen()
#23 {main}

Edited by moderator to remove repeating error in the log.

matteocontrini

JasperVriends Skips target if it has already been set (issue reported by @matteocontrini )

Thanks! Unfortunately it doesn't work, it still removes the target and rel attributes and leave them empty (as before).

[deleted]

I got this error after updating to newest version:

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [FoF\Pages\PageRepository] does not exist. in /home/xxx/xxx/vendor/illuminate/container/Container.php:835
Stack trace:
#0 /home/xxx/xxx/vendor/illuminate/container/Container.php(714): Illuminate\Container\Container->build('FoF\\Pages\\PageR...')
#1 /home/xxx/xxx/vendor/illuminate/container/Container.php(652): Illuminate\Container\Container->resolve('FoF\\Pages\\PageR...', Array)
#2 /home/xxx/xxx/vendor/illuminate/container/Container.php(987): Illuminate\Container\Container->make('FoF\\Pages\\PageR...')
#3 /home/xxx/xxx/vendor/illuminate/container/Container.php(907): Illuminate\Container\Container->resolveClass(Object(ReflectionParameter))
#4 /home/xxx/xxx/vendor/illuminate/container/Container.php(868): Illuminate\Container\Container->resolveDependencies(Array)
#5 /home/xxx/xxx/vendor/illuminate/container/Container.php(714): Illuminate\Container\Container->build('V17Development\\...')
#6 /home/xxx/xxx/vendor/illuminate/container/Container.php(652): Illuminate\Container\Container->resolve('V17Development\\...', Array)
#7 /home/xxx/xxx/vendor/illuminate/container/Container.php(987): Illuminate\Container\Container->make('V17Development\\...')
#8 /home/xxx/xxx/vendor/illuminate/container/Container.php(907): Illuminate\Container\Container->resolveClass(Object(ReflectionParameter))

I do not use fof/pages because it is not compatibile with beta16 yet...

JasperVriends

Update v1.7.1 - Fixed crash

Thanks for reporting the issues you were experiencing after the previous update! If you experience any more issues, let me know!

To update, run:

composer update v17development/flarum-seo

matteocontrini Can you let me know what extension you are using? Then I'll be able to check this locally 🙂

serdo

plugin error when i update to beta 16

"You are not authorized to access this page."

matteocontrini

JasperVriends Can you let me know what extension you are using? Then I'll be able to check this locally

It's actually a private extension but you can reproduce the issue with a custom BBcode:

(new Extend\Formatter)
        ->configure(function (Configurator $config) {
            $config->BBCodes->addCustom(
                '[HELLO]{TEXT}[/HELLO]',
                '<a href="{TEXT}" target="_blank">Link</a>'
            );
        })

(non-sense, but you get the idea)

In my case the link is always on the same domain.

Thanks! 😃

mekici

JasperVriends When the cache is cleared in the Admin Control panel while the SEO plugin is active, the homepage is not loaded. Gives the error "Something went wrong while loading the full version of the page."

[2021-04-05 12:17:26] flarum.ERROR: TypeError: Argument 1 passed to V17Development\FlarumSeo\Formatter\FormatLinks::__invoke() must be an instance of s9e\TextFormatter\Renderer, instance of __PHP_Incomplete_Class given, called in /var/www/rc1/vendor/flarum/core/src/Foundation/ContainerUtil.php on line 30 and defined in /var/www/rc1/vendor/v17development/flarum-seo/src/Formatter/FormatLinks.php:56
Stack trace:
#0 /var/www/rc1/vendor/flarum/core/src/Foundation/ContainerUtil.php(30): V17Development\FlarumSeo\Formatter\FormatLinks->__invoke()
#1 /var/www/rc1/vendor/flarum/core/src/Formatter/Formatter.php(91): Flarum\Foundation\ContainerUtil::Flarum\Foundation\{closure}()
#2 /var/www/rc1/vendor/flarum/core/src/Post/CommentPost.php(172): Flarum\Formatter\Formatter->render()
#3 /var/www/rc1/vendor/flarum/core/src/Api/Serializer/BasicPostSerializer.php(44): Flarum\Post\CommentPost->formatContent()
#4 /var/www/rc1/vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(87): Flarum\Api\Serializer\BasicPostSerializer->getDefaultAttributes()
#5 /var/www/rc1/vendor/tobscure/json-api/src/Resource.php(169): Flarum\Api\Serializer\AbstractSerializer->getAttributes()
#6 /var/www/rc1/vendor/tobscure/json-api/src/Resource.php(75): Tobscure\JsonApi\Resource->getAttributes()
#7 /var/www/rc1/vendor/tobscure/json-api/src/Document.php(187): Tobscure\JsonApi\Resource->toArray()
#8 [internal function]: Tobscure\JsonApi\Document->Tobscure\JsonApi\{closure}()
#9 /var/www/rc1/vendor/tobscure/json-api/src/Document.php(186): array_map()
#10 /var/www/rc1/vendor/tobscure/json-api/src/Document.php(224): Tobscure\JsonApi\Document->toArray()
#11 /var/www/rc1/vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize()
#12 /var/www/rc1/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(121): Flarum\Api\JsonApiResponse->__construct()
#13 /var/www/rc1/vendor/flarum/core/src/Api/Client.php(72): Flarum\Api\Controller\AbstractSerializeController->handle()
#14 /var/www/rc1/vendor/flarum/core/src/Forum/Content/Index.php(121): Flarum\Api\Client->send()
#15 /var/www/rc1/vendor/flarum/core/src/Forum/Content/Index.php(86): Flarum\Forum\Content\Index->getApiDocument()
#16 /var/www/rc1/vendor/flarum/core/src/Frontend/Frontend.php(63): Flarum\Forum\Content\Index->__invoke()
#17 /var/www/rc1/vendor/flarum/core/src/Frontend/Frontend.php(55): Flarum\Frontend\Frontend->populate()
#18 /var/www/rc1/vendor/flarum/core/src/Frontend/Controller.php(32): Flarum\Frontend\Frontend->document()
#19 /var/www/rc1/vendor/flarum/core/src/Http/RouteHandlerFactory.php(38): Flarum\Frontend\Controller->handle()
#20 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#21 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ExecuteRoute->process()
#22 /var/www/rc1/vendor/fof/oauth/src/Middleware/ErrorHandler.php(50): Laminas\Stratigility\Next->handle()
#23 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): FoF\OAuth\Middleware\ErrorHandler->process()
#24 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/FlarumPromotionHeader.php(29): Laminas\Stratigility\Next->handle()
#25 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\FlarumPromotionHeader->process()
#26 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php(57): Laminas\Stratigility\Next->handle()
#27 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ShareErrorsFromSession->process()
#28 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle()
#29 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process()
#30 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#31 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ResolveRoute->process()
#32 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/SetLocale.php(50): Laminas\Stratigility\Next->handle()
#33 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\SetLocale->process()
#34 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle()
#35 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process()
#36 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle()
#37 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process()
#38 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#39 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\StartSession->process()
#40 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php(46): Laminas\Stratigility\Next->handle()
#41 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\CollectGarbage->process()
#42 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#43 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process()
#44 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#45 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\HandleErrors->process()
#46 /var/www/rc1/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle()
#47 /var/www/rc1/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#48 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\RequestHandler->process()
#49 /var/www/rc1/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle()
#50 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePathRouter->process()
#51 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(42): Laminas\Stratigility\Next->handle()
#52 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process()
#53 /var/www/rc1/vendor/middlewares/base-path/src/BasePath.php(53): Laminas\Stratigility\Next->handle()
#54 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Middlewares\BasePath->process()
#55 /var/www/rc1/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#56 /var/www/rc1/vendor/laminas/laminas-stratigility/src/Next.php(61): Flarum\Http\Middleware\ProcessIp->process()
#57 /var/www/rc1/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle()
#58 /var/www/rc1/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process()
#59 /var/www/rc1/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle()
#60 /var/www/rc1/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#61 /var/www/rc1/public/index.php(26): Flarum\Http\Server->listen()

the error occurs when the following option is enabled
Crawl all posts (it's slower on page refresh, but search results will be better)

JasperVriends

Hi erroras ! ~~Are you sure this is happening due to the SEO extension? As the SEO extension doesn't set routes 🤔~~

We've just released v1.7.2 which should fix the issue, can you verify the issue has been resolved?

matteocontrini Thanks for that! I'll experiment with that 🙂

erroras

flarum.ERROR: RuntimeException: Route pages.index on method POST already exists in public_html/vendor/flarum/core/src/Http/RouteCollection.php:77

erroras

works

EnricoBaldi

@JasperVriends

I found a really big mistake in my opinion in your plugin.

CANONICAL

As i see it is not working properly, beacsue it add to canonical not the main URL of discussion, but it add too all links like ?near=2 near=10

THat means for one same thread can be indexed many different copies, main url plus all ?near=##

As we know CANONICAL should be only one and relative the main thread, with "near" potetially google could index for the same thread as many compies as are the replies.

THis should be fixed, or we risk to incurr in the issue of duplicated contents with risk to be penalized.

THanks

JasperVriends

Hi EnricoBaldi ! Thanks for your feedback! Good one, I completely agree and found out that this is Flarum's behaviour for the discussions 🙁

I just tried to override the cononical locally for discussions, but it didn't seem to work. Just to be sure, all the discussion pages that contain the /d/123-discussion-title?near=$1 should have a /d/123-discussion-title canonical URL instead right?

matteocontrini

JasperVriends there's an issue for this here: flarum/core2397

EnricoBaldi

JasperVriends yes we need just one CANONICAL.

SO yes for one thread should be as canonical only /d/123-discussion-title for all possible pages / subpages. So near= code should be not shown in canonical url.

philips300

Bet16?

JasperVriends

philips300 Yes

« Previous Page Next Page »