FriendsOfFlarum Links

olepmac

olepmac Update on this issue

Solved. Weirdly enough, it installed with this syntax error on line 52:

(/var/www/flarum/vendor/fof/links/src/Command/CreateLinkHandler.php)

        $link = Link::build(
            Arr::get($data, 'attributes.title'),
            Arr::get($data, 'attributes.icon'),
            Arr::get($data, 'attributes.url'),
            Arr::get($data, 'attributes.isInternal'),
            Arr::get($data, 'attributes.isNewtab'),
            Arr::get($data, 'attributes.visibility'), // out of place comma
        );

Just removing the comma after the last item in the array took care of it.

Has anyone encountered the same issue?

datitisev

olepmac This might have been because of your PHP version, not sure. I have had issues with trailing commas in the past that didn't error locally but did on other systems... we should probably remove it from the ext tho.

olepmac

datitisev PHP version: PHP 7.2.34-9+ubuntu18.04.1+deb.sury.org+1

Just fyi, maybe it might be helpful.

010101

datitisev I just experienced this suddenly. After my web host did some server maintenance I couldn't get to my forum. I checked the logs and it was the same errors @olepmac pasted. Disabling this extension got me back into my forum.

rob006

datitisev Trailing comma in method call is available since PHP 7.3.

IanM

Considering PHP 7.2 is now EOL, and 7.3 is now in security support only, I'd suggest that PHP 7.4 is used wherever possible.

PHP supported versions

0.5.3

Fix trailing comma / PHP 7.2 incompatibility (olepmac 010101 )

010101

IanM Ok, but FYI this was happening with 7.3.26. But, I’ll go to a higher version.

peopleinside

IanM FriendsOfFlarum/links33

IanM

010101 Interesting indeed. 7.3 should support it too https://laravel-news.com/php-trailing-commas-functions

Anyhow, updating to the latest version of the extension, updating PHP, or even both 😉 Should mean you are good to go again

Arnold

peopleinside I've had the same issue with this update. Turning the extension off and on solved the problem somehow. If you have access to your admin section, of course.

IanM

IanM php flarum migrate

peopleinside

Arnold

peopleinside

Arnold great thanks! Works!

Arnold

IanM thanks! It would be nice to copy update instruction to each new version post. Because it's pretty easy to forget about php flarum migrate 😉

IanM

0.5.4

Add rel="noopener" to external links FriendsOfFlarum/links35

Thank you @davwheat

Updating

composer require fof/links:"*"
php flarum cache:clear

Justoverclock

Some issue here:

clarkwinkelmann

Justoverclock the issue is tracked here FriendsOfFlarum/links20

There's no real other solution except using shorter or fewer links at this time. And people will always be able to break it by registering longer usernames.

gartaguel

Justoverclock
I use this solution is not perfect but it works:
.Navigation-back { pointer-events: auto !important; } .ButtonGroup>.Button:first-child:not(:last-child):not(.Dropdown-toggle) { pointer-events: none; }

JohnP

clarkwinkelmann And people will always be able to break it by registering longer usernames.

We had this issue on the site we are building, and decided that the users avatar was enough, so hid the username from the menubar with display:none.

fakruzaruret

clarkwinkelmann May be added dots show that there is more links. like this ghost theme

https://shoji.fueko.net/

ctml

Another option which I do is to add some css to set a max width to the username label and have the overflow as an ellipsis.

A second way if you have a lot of links is to increase the fixed width of the forum from the default, I do both of these but not specifically for the above issue.

Justoverclock

fakruzaruret May be added dots show that there is more links like this ghost theme

how can i do that, i think is an elegant solution

Trombert

fakruzaruret Justoverclock MikeJones

Some time ago I had the same doubt and @Pollux commented a very interesting CSS solution with which adapting it you can get the same result as in https://shoji.fueko.net/.

The @Pollux solution in question allows you to have links that allow you to directly display the dropdown menu when you click on them, actually what you are doing is hiding the text of the link itself and changing the content of the small down arrow of the FoF Links dropdown.

.item-link1 a, .item-link2 a {
    display: none;
}

.item-link1 .fa-caret-down::before {
    content: "Q & A";
}

.item-link2 .fa-caret-down::before {
    content: "Legal Stuff";
}

#header-primary .fa-caret-down {
    font-family: inherit;
    font-size: 100%;
}

I adapted this solution for https://brickdose.com (you can see it live there) to have just the three dots and have them act as a dropdown button

.item-link18 a {
      display: none;
 }

.item-link18 .fa-caret-down::before {
      font-family: "Font Awesome 5 Free";
      content: "\f141";
      font-size: 120%;
      margin-left: 10px;
 }

« Previous Page Next Page »