FriendsOfFlarum Split, separates posts to a new discussion

clarkwinkelmann

luceos well, yes and no 😂

Actually the first post is never automatically refreshed, so if the first post is deleted, no other post is assigned. I thought it might have worked like the last post which is updated by the discussion meta updater, but the first post relation is only updated by Flarum during discussion creation https://github.com/flarum/core/blob/v1.0.4/src/Discussion/Command/StartDiscussionHandler.php#L94

So with just the base Flarum, firstPost can be expected to be number 1.

But an extension could use the setFirstPost method to set something else.

I've had my fair share of issues with the Wordpress comments extension that sets an event post as the first post, which prompted the creation of flarum/core2105

I don't expect anything to crash by setting another number as first post, but I have multiple extensions that extend Post or CommentPost component and show additional fields or other information only if post number is one. If the post is an event post, these additional features might not render 😅

Hari

clarkwinkelmann luceos

I'm sponsoring a move extension it will be out in 2-3 weeks 🤞 i do understand the importance of the first post but why don't flarum consider the first post as a regular comment and also do allow to rearrange the post numbering based on posted time? maybe an extension should reset the posts ordering numbers based on the time. idk the limitations but it would be nice if we can treat all posts as same so we can easily play with post moving.

I have read so many explanations from flarum doctor clarkwinkelmann on this but you know if core allows us to play it would be a much easier job

-Flarum lover

Edit:

clarkwinkelmann But an extension could use the setFirstPost method to set something else.

yes yes ❤

clarkwinkelmann I've had my fair share of issues with the Wordpress comments extension that sets an event post as the first post, which prompted the creation of flarum/core#2105

😅

samtto

After the split action, the tags changes.is it ?

Flarum core 1.1.1
PHP version: 7.4.9

@FriendsOfFlarum

matteocontrini

Did anyone notice that after splitting, the user that performed the split keeps seeing the discussion as already read unless the number of posts exceeds the original number in the original discussion?

For example: original discussion with 100 posts, I split 5 posts, the "last read" post in the new discussion for my user is still number 100 instead of 5 (or 1).

Thanks!

luceos

matteocontrini that state might actually be copied along; sounds like a bug 👍️ Probably needs confirmation.

matteocontrini

matteocontrini Did anyone notice that after splitting, the user that performed the split keeps seeing the discussion as already read unless the number of posts exceeds the original number in the original discussion?

For example: original discussion with 100 posts, I split 5 posts, the "last read" post in the new discussion for my user is still number 100 instead of 5 (or 1).

I'm bumping this, does someone else experience the same issue?

I've tried looking at the source code but I don't understand where that could happen...

TB54

Hello,

When I split messages into a new discussion, there is a message displaying, informing there has been a split:

But this message displays at the end of the new discussion (because it's the last thing done, chronologically it's logical).

But wouldn't it be more useful to put it at the start of the new discussion, to explain why there is a discussion starting from nowhere, like if wat taken in the middle of a conversation?

It's maybe not the best option, but right now I'm forced to put a disclaimer on the top message to explain it's the split from a present discussion.

(an option could be to change the date of this disclaimer with the "Change author" extension, in order to put it as first message of the discussion), but it doesn't seem to work for now).

clarkwinkelmann

TB54 Maybe we would need something different than an event post for this.

It's not a good idea to put an event post as the first post of a discussion because that post has special meaning and is used to provide excerpts in the discussion list. At best it could be the second post.

We could add an additional property to the discussion model so that we can display a customized message at the top of the discussion that isn't a special post type.

Using an event post was the easiest option historically (and still is). It also has the benefit of being carried over if that part of the discussion is then split again. It also announces the place where old discussion switches to new discussion.

TB54

clarkwinkelmann A solution would probably to have the two (in the new merged post): a sign informing at which point the operation took place (in a way to indicate when the new discussion start indeed), but also a disclamer on the first message (there must be a way to exclude it from the synopsis).

That's not crazy important as any mod can add the message himself, but I think it would made merged posts more clear.

Hari

matteocontrini try move post extension 👀

matteocontrini

Hari I use it but it takes too much effort to move many posts. Split is easier/faster to use

Hari

matteocontrini actually, during the planning* of that extension, we thought of this issue and a select feature on the post area will be the right solution for it but it was not implemented SychO9/flarum-move-posts2 author has done a lot of work more than promised so I did not ask him for more. if possible could you submit a PR this feature already exists in the split extension you can copy the same code (i am not a dev) .. i feel shame to ask for a PR 😅 but it makes the move post extension the best.

CyberGene

If there’s an easier way to select multiple posts to move, then the move extension will be the bomb! It’s already very good.

CyberGene

I recently installed this extension (next to the move extension) and I used it to split a discussion and now there are new posts in the original discussion but it's shown as read. This is a bug. When splitting a discussion, the number of read posts should be decreased, by the number of posts that are extracted from it.

I'm not sure if the move extensions is suffering from the same bug but I think it's OK, so it seems like I will uninstall this and just use the move extension in future.

IanM

1.1.1

Fixes for core PR; add cancel split button by @davwheat in FriendsOfFlarum/split47
chore: enable phpstan, bump js deps by @IanM in FriendsOfFlarum/split57

CyberGene

I've recently reinstalled this extension because I've needed an easier way to move a lot of posts. I've completely forgotten that this extension has a serious bug which is the original discussion is marked as read even when there are new posts in it. I uninstalled it this morning. Is that bug fixed in 1.1.1?

IanM

CyberGene unfortunately not. Would you mind creating an issue for me please, I'll take a look when I can 🙂 FriendsOfFlarum/split

m4v3rick

Is it possible to split like 10k posts to a new discussion?
Whenever I try to "split from here", the "split to here" seems to be 7-8 posts away at max.

CyberGene original discussion is marked as read

Doesn't sound that good. Although I think in my case it wouldn't matter, because the old part would be locked after the split.

tolgaaaltas

Tag changing modal doesn't disappear when I split post from the original one to under the new discussion. I don't know it's happening because of FoF Split but I wanted to report it.

P.S. It's not even closing. I need to refresh the page.

davetodave178

tolgaaaltas Can you please share the output of php flarum info ?

tolgaaaltas

davetodave178 Sure.

Flarum core: 1.8.5
PHP version: 8.0.26
MySQL version: 8.0.31-cll-lve
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, hash, filter, ftp, gettext, gmp, SPL, iconv, json, pcntl, readline, Reflection, session, standard, shmop, SimpleXML, mbstring, tokenizer, xml, i360, bcmath, dom, fileinfo, gd, igbinary, imagick, imap, intl, exif, mcrypt, mysqlnd, mysqli, PDO, pdo_mysql, pdo_sqlite, Phar, posix, soap, sockets, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+------------------------------------+---------+--------+
| Flarum Extensions                  |         |        |
+------------------------------------+---------+--------+
| ID                                 | Version | Commit |
+------------------------------------+---------+--------+
| flarum-tags                        | v1.8.0  |        |
| flarum-mentions                    | v1.8.3  |        |
| flarum-subscriptions               | v1.8.0  |        |
| fof-sitemap                        | 2.2.1   |        |
| fof-impersonate                    | 1.1.1   |        |
| flamarkt-backoffice                | 0.1.3   |        |
| fof-follow-tags                    | 1.2.2   |        |
| flarum-markdown                    | v1.8.0  |        |
| webbinaro-calendar                 | 1.7.0   |        |
| v17development-user-badges         | v1.1.0  |        |
| v17development-seo                 | v1.8.0  |        |
| tohsakarat-tags-filter             | v1.0.5  |        |
| sycho-private-facade               | v0.1.16 |        |
| nearata-internal-links-noreload    | v2.2.0  |        |
| ianm-boring-avatars                | 1.0.0   |        |
| ganuonglachanh-search              | 0.5.2   |        |
| fof-upload                         | 1.5.4   |        |
| fof-split                          | 1.1.1   |        |
| fof-pretty-mail                    | 1.1.2   |        |
| fof-polls                          | 2.1.2   |        |
| fof-moderator-notes                | 1.2.2   |        |
| fof-merge-discussions              | 1.4.1   |        |
| fof-links                          | 1.2.2   |        |
| fof-linguist                       | 1.1.2   |        |
| fof-formatting                     | 1.0.3   |        |
| fof-default-user-preferences       | 1.2.1   |        |
| fof-best-answer                    | 1.4.1   |        |
| flarum-suspend                     | v1.8.1  |        |
| flarum-sticky                      | v1.8.0  |        |
| flarum-pusher                      | v1.8.0  |        |
| flarum-nicknames                   | v1.8.0  |        |
| flarum-lock                        | v1.8.0  |        |
| flarum-lang-turkish                | 1.25.0  |        |
| flarum-extension-manager           | v1.0.2  |        |
| datlechin-simple-tour-guide        | v0.0.1  |        |
| datlechin-offline-indicator        | v0.1.0  |        |
| datlechin-keyboard-shortcuts       | v0.1.1  |        |
| datlechin-discussion-overview      | v0.0.1  |        |
| club-1-cross-references            | v1.1.1  |        |
| clarkwinkelmann-who-read           | 1.4.1   |        |
| clarkwinkelmann-post-stream-search | 1.1.0   |        |
| blomstra-turnstile                 | 0.1.4   |        |
| blomstra-sort-order-toggle         | 0.2.0   |        |
| blomstra-database-queue            | 1.1.0   |        |
| blomstra-cache-assets              | 0.5     |        |
| betterflarum-bettermobiledrawer    | 2.2.0   |        |
| askvortsov-pwa                     | v3.3.3  |        |
| askvortsov-markdown-tables         | v1.2.1  |        |
| askvortsov-help-tags               | v1.1.0  |        |
| askvortsov-checklist               | v1.3.1  |        |
| acpl-lscache                       | v2.3.1  |        |
+------------------------------------+---------+--------+
Base URL: https://support.bw.agency
Installation path: /home/samsunek/support.bw.agency
Queue driver: database
Session driver: file
Scheduler status: Aktif
Mail driver: smtp
Debug mode: off

« Previous Page