FriendsOfFlarum Merge Discussions

datitisev

Merge Discussions by FriendsOfFlarum

Merge two or more discussions into one.

Installation

Use Bazaar or install manually with composer:

composer require fof/merge-discussions

Updating

composer update fof/merge-discussions

Links

An extension by FriendsOfFlarum, commissioned by giffgaff.

matteocontrini

Nice!

It would be great to also have a similar (?) extension for moving specific posts to an existing discussion. The modal component can be reused, probably.

luceos

matteocontrini lovely idea, this one was commissioned though, so the requirements were set.

datitisev

matteocontrini That sounds more like flagrow/split instead of fof/merge-discussions... though you could combine the two and split those posts, then merge them (the whole new discussion) into another discussion.

matteocontrini

datitisev yeah of course, it wasn't a feature request for this extension, but the modal thing is something that would be required to choose the destination discussion. The combination of the two is something I did not think about, but it's still a bit unnatural and probably confusing for users...

Anyway, a question about this extension: when merging two discussions, is the chronological order of the posts preserved, so that they are inserted at the right place between existing posts?

Thanks!

luceos

matteocontrini Anyway, a question about this extension: when merging two discussions, is the chronological order of the posts preserved, so that they are inserted at the right place between existing posts?

Yes. Both discussions are merged together, posts are renumbered based on post creation time, this includes the OP.

luceos

Let me clarify that even though the initial version was commissioned we'd love to see where we get with this extension based on your input, experiences and use cases 💝

datitisev

0.1.1

Fixed incorrect post numbering on merge post event (FriendsOfFlarum/merge-discussions#1)

Updating

composer update fof/merge-discussions

datitisev

0.2.0

Added button to preview discussion after all discussions have been merged
Added help text to avoid confusion as to where the merged discussions will be merged to

Updating

composer update fof/merge-discussions

datitisev

0.2.1

Fix discussion data relating to participants and posts not being updated
- FriendsOfFlarum/merge-discussions#4

Updating

composer update fof/merge-discussions

datitisev

0.2.2

Allow searching discussions by ID
- bypasses search issues on large forums such as this one

Updating

composer update fof/merge-discussions

datitisev

0.3.1

Add option to merge current discussion into another
- Before 0.3.0, you could only merge other discussions into the current one
Clarify wording of what will be merged where
Add discussion title to the preview so it's clearer which discussion the other discussion(s) are being merged into
0.3.1 Fix width of the preview hero

Updating

composer require fof/merge-discussions

luceos

datitisev great job David 🤘

tolgaaaltas

I've got this error message when i try merge any discussion. (I tried with three methods of FoF-Transliterator)

[Sun Aug 25 22:35:50.619072 2019] [php7:notice] [pid 21349] [client 66.249.76.87:60547] PHP Notice: Undefined index: id in /home/zincirsiz/web/XinXirsiX.XeX/public_html/storage/views/64bf5edd6d58f570ff2964ba03dadb35f88cf2dd.php on line 17

Thank you for your effort to improve Flarum.

luceos

tolgaaaltas can you open that exact file and post what is on line 17, it's very hard to see what template that is when you reference a cached file.

datitisev

tolgaaaltas Wait, sorry. So does this error message occur when using fof/merge-discussions and fof/transliterator, or just fof/merge-discussions ?

tolgaaaltas

luceos Sure, i forgot that sorry. 🙂
`<?php echo '<'.'?xml version="1.0" encoding="utf-8"?'.'>'; ?>

<title><![CDATA[<?php echo $title; ?>]]></title>
<subtitle><![CDATA[<?php echo $description; ?>]]></subtitle>
<link href="<?php echo e($self_link); ?>" rel="self" />
<link href="<?php echo e($link); ?>" />
<id><![CDATA[<?php echo $link; ?>]]></id>
<updated><?php echo e($pubDate->format(DateTime::ATOM)); ?></updated>

<?php $__currentLoopData = $entries; $__env->addLoop($__currentLoopData); foreach($__currentLoopData as $entry): $__env->incrementLoopIndices(); $loop = $__env->getLastLoop(); ?>
<entry>
    <title><![CDATA[<?php echo $entry['title']; ?>]]></title>
    <link rel="alternate" type="text/html" href="<?php echo e($entry['permalink']); ?>"/>
    <id><?php echo e($entry['id'] or $entry['permalink']); ?></id>
    <updated><?php echo e($entry['pubdate']->format(DateTime::ATOM)); ?></updated>
    <summary><![CDATA[<?php echo $entry['description']; ?>]]></summary>
    <content type="html"><![CDATA[<?php echo $entry['content'] or $entry['description']; ?>]]></content>
    <author>
        <name><?php echo e($entry['author']); ?></name>
    </author>
</entry>
<?php endforeach; $__env->popLoop(); $loop = $__env->getLastLoop(); ?>

</feed>`

luceos

tolgaaaltas can you post all of it, if possible?

tolgaaaltas

luceos Edited. 🙂

tolgaaaltas

datitisev Now i disabled fof/transliterator and checked again, result is same. I got this error again.

datitisev

tolgaaaltas That looks to be an incompatibility with the Syndication extension, that view being part of the atom feed.