FriendsOfFlarum Merge Discussions

[deleted]

IanM on 🔥

Hari

Hari after the stable* release everyone is on fire 😁

🔥

Wadera

Mearging isn't working for me 🙁

[2021-08-19 12:49:38] flarum.ERROR: [fof/merge-discussions] Failed to merge discussions.  
[2021-08-19 12:49:38] flarum.ERROR: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1184-1020' for key 'posts_discussion_id_number_unique' in /home/(...)/flarum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:112
Stack trace:
#0 /home/(...)/flarum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php(112): PDOStatement->execute()
#1 /home/(...)/flarum/vendor/illuminate/database/Connection.php(510): Doctrine\DBAL\Driver\PDOStatement->execute()
#2 /home/(...)/flarum/vendor/illuminate/database/Connection.php(685): Illuminate\Database\Connection->Illuminate\Database\{closure}()
#3 /home/(...)/flarum/vendor/illuminate/database/Connection.php(652): Illuminate\Database\Connection->runQueryCallback()
#4 /home/(...)/flarum/vendor/illuminate/database/Connection.php(517): Illuminate\Database\Connection->run()
#5 /home/(...)/flarum/vendor/illuminate/database/Connection.php(450): Illuminate\Database\Connection->affectingStatement()
#6 /home/(...)/flarum/vendor/illuminate/database/Query/Builder.php(2999): Illuminate\Database\Connection->update()
#7 /home/(...)/flarum/vendor/illuminate/database/Eloquent/Builder.php(896): Illuminate\Database\Query\Builder->update()
#8 /home/(...)/flarum/vendor/illuminate/database/Eloquent/Model.php(1020): Illuminate\Database\Eloquent\Builder->update()
#9 /home/(...)/flarum/vendor/illuminate/database/Eloquent/Model.php(935): Illuminate\Database\Eloquent\Model->performUpdate()
#10 /home/(...)/flarum/vendor/illuminate/database/Eloquent/Model.php(877): Illuminate\Database\Eloquent\Model->save()
#11 /home/(...)/flarum/vendor/illuminate/database/Eloquent/Model.php(889): Illuminate\Database\Eloquent\Model->push()
#12 /home/(...)/flarum/vendor/fof/merge-discussions/src/Api/Commands/MergeDiscussionHandler.php(105): Illuminate\Database\Eloquent\Model->push()
#13 /home/(...)/flarum/vendor/illuminate/database/Concerns/ManagesTransactions.php(29): FoF\MergeDiscussions\Api\Commands\MergeDiscussionHandler->FoF\MergeDiscussions\Api\Commands\{closure}()
#14 /home/(...)/flarum/vendor/fof/merge-discussions/src/Api/Commands/MergeDiscussionHandler.php(129): Illuminate\Database\Connection->transaction()
#15 /home/(...)/flarum/vendor/illuminate/bus/Dispatcher.php(122): FoF\MergeDiscussions\Api\Commands\MergeDiscussionHandler->handle()
#16 /home/(...)/flarum/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}()
#17 /home/(...)/flarum/vendor/illuminate/pipeline/Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#18 /home/(...)/flarum/vendor/illuminate/bus/Dispatcher.php(132): Illuminate\Pipeline\Pipeline->then()
#19 /home/(...)/flarum/vendor/illuminate/bus/Dispatcher.php(78): Illuminate\Bus\Dispatcher->dispatchNow()
#20 /home/(...)/flarum/vendor/fof/merge-discussions/src/Api/Controllers/MergeController.php(68): Illuminate\Bus\Dispatcher->dispatch()
#21 /home/(...)/flarum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(110): FoF\MergeDiscussions\Api\Controllers\MergeController->data()
#22 /home/(...)/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle()
#23 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#24 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ExecuteRoute->process()
#25 /home/(...)/flarum/vendor/kilowhat/flarum-ext-audit-free/src/Middlewares/SetLoggerActor.php(28): Laminas\Stratigility\Next->handle()
#26 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Kilowhat\Audit\Middlewares\SetLoggerActor->process()
#27 /home/(...)/flarum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#28 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\ThrottleApi->process()
#29 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(44): Laminas\Stratigility\Next->handle()
#30 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\CheckCsrfToken->process()
#31 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#32 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ResolveRoute->process()
#33 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#34 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\SetLocale->process()
#35 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(56): Laminas\Stratigility\Next->handle()
#36 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithHeader->process()
#37 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#38 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithSession->process()
#39 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle()
#40 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\RememberFromCookie->process()
#41 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#42 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\StartSession->process()
#43 /home/(...)/flarum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle()
#44 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\FakeHttpMethods->process()
#45 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#46 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ParseJsonBody->process()
#47 /home/(...)/flarum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#48 /home/(...)/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\HandleErrors->process()

and:

$ php flarum info
Flarum core 1.0.4
PHP version: 7.4.21
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, gettext, SPL, iconv, intl, json, mbstring, session, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, mysqli, SimpleXML, soap, sockets, sodium, exif, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, imagick, ionCube Loader
+----------------------------------+--------------+--------+
| Flarum Extensions                |              |        |
+----------------------------------+--------------+--------+
| ID                               | Version      | Commit |
+----------------------------------+--------------+--------+
| flarum-subscriptions             | v1.0.0       |        |
| flarum-tags                      | v1.0.3       |        |
| flarum-flags                     | v1.0.0       |        |
| afrux-forum-widgets-core         | v0.1.5       |        |
| fof-follow-tags                  | 1.0.1        |        |
| flarum-sticky                    | v1.0.0       |        |
| flarum-lock                      | v1.0.0       |        |
| flarum-approval                  | v1.0.0       |        |
| afrux-news-widget                | v0.1.0       |        |
| fof-split                        | 1.0.0        |        |
| clarkwinkelmann-group-invitation | 1.0.0        |        |
| the-turk-diff                    | 1.1.1        |        |
| fof-user-directory               | 1.0.2        |        |
| fof-formatting                   | 1.0.0        |        |
| fof-polls                        | 1.0.3        |        |
| fof-bbcode-details               | 1.0.0        |        |
| askvortsov-discussion-templates  | v0.8.0       |        |
| fof-drafts                       | 1.0.1        |        |
| fof-upload                       | 1.0.2        |        |
| flarum-statistics                | v1.0.0       |        |
| flarum-mentions                  | v1.0.0       |        |
| flarum-markdown                  | v1.0.1       |        |
| flarum-likes                     | v1.0.0       |        |
| fof-user-bio                     | 1.0.0        |        |
| fof-spamblock                    | 1.0.0        |        |
| fof-reactions                    | 1.0.0        |        |
| fof-profile-image-crop           | 1.0.0        |        |
| fof-oauth                        | 1.0.1        |        |
| fof-nightmode                    | 1.0.0        |        |
| fof-merge-discussions            | 1.0.0        |        |
| fof-links                        | 1.0.0        |        |
| fof-best-answer                  | 1.1.0        |        |
| askvortsov-categories            | v3.0.0       |        |
| clarkwinkelmann-author-change    | 1.0.1        |        |
| flarum-emoji                     | v1.0.0       |        |
| kilowhat-audit-free              | 1.4.1        |        |
| flarum-lang-english              | v1.0.0       |        |
| michaelbelgium-discussion-views  | v7.0.0       |        |
| kyrne-websocket                  | 3.1.1        |        |
| fof-byobu                        | 1.0.0-beta.8 |        |
| the-turk-flamoji                 | 1.0.2        |        |
| afrux-forum-stats-widget         | v0.1.0       |        |
| afrux-top-posters-widget         | v0.1.2       |        |
+----------------------------------+--------------+--------+
Base URL: (...)
Installation path: /home/(...)/flarum
Debug mode: off

I've notice that in posts table some of posts with value 1184 in column discussion_id (so the one which I want to merge into) I have missing post. In column number there is:

(...)
925
926
928
929
(...)

It's probably after use Split to move some post out to different discussion or after Delete forewer option.

m4v3rick

Wadera Delete forewer

This is/was an issue on my forum. That's why we don't (or can't?) move any posts anymore.

Wadera

Yes, but that's not solution. We have bug somewhere here. All of the processes manipulating with posts in discussions (removing, splitting, merging etc) should recalculate posts numbers and update also all collumns in discussions table (like comment_count, post_number_index etc). Otherwise we will endup with inconsistent and broken DB.

I've face this kind of issues multiple times:

I've got written some python script and later sponsored extension (thanks @clarkwinkelmann ) to get my DB fixed and needed use it multiple times already, as some actions keep breaking it.

Example - not use

$ cat dbfix.py 
#!/bin/python

import mysql.connector as mysql

db = mysql.connect(
    host = "localhost",
    user = "db_username",
    passwd = "db_password",
    database = "database_name"
)

cursor = db.cursor()

## defining the Query
query = "SELECT id FROM discussions WHERE first_post_id=1"

cursor.execute(query)
discussions = cursor.fetchall()

for discussion_id in discussions:
  query = "SELECT id FROM posts WHERE discussion_id=%s and number=1"
  values = (discussion_id,)
  cursor.execute(query, discussion_id)
  first_post_id = cursor.fetchone()
  print(first_post_id)

  if first_post_id:
    query = "UPDATE discussions SET first_post_id = %s WHERE id = %s"
    values = (first_post_id[0], discussion_id[0])
    cursor.execute(query, values)
    db.commit()

Example - not use

m4v3rick

Wadera

Does this work for quotes aswell? Guess the quoted post id inside a post should also be changed then.

datitisev

m4v3rick Replies use the post ID, not the post number. Therefore there shouldn't a problem with changing the numbers, as far as I'm aware.

Wadera

I've just added note that python script was just a simple fix script to check somethig, but it will keep DB messy anyway (meta information in discussions table won't be updated), so if you have a problem - plese use this solution:
https://github.com/migratetoflarum/recalculate-meta (it may not be set as compatible with flarum 1.0)

fluid-decanter

Hello. Having recently started using this extension, I have found that the search feature does not work well. Sometimes even if I give the exact title of the thread I want to merge into, it will not appear in the search results, so I cannot do the merge. So far I am able to work around this by going to the thread and choosing to merge other discussions into that thread. However it's frustrating that I know the exact discussion and cannot manually choose it, instead relying on the search box.

Rather than jumping directly to asking for a possibly-complicated fix to the search feature, may I ask why it is impossible to simply input the thread's unique ID number, as a fallback option, instead of using a search box?

hrvoje_hr

fluid-decanter usually when you search only for Discussion ID it lists the correct one. There is no nead to search for complete title.

fluid-decanter

hrvoje_hr In my experience, if I just enter numerals, I get no search results at all.

datitisev

fluid-decanter I believe the number may have to be at least 3 digits long, because of Flarum's core search component.

However, that reminded me that the solution is a simple core PR, so I did just that - flarum/core3130.

fluid-decanter

datitisev That may be it then. Our forum is small yet. Thanks!

vprelovac

Thank you for the extension. It would be great if it asked (via checkboxes) if tags should be merged too (default: no)

vprelovac

Also if it didn't delete the merged post, but instead set up a redirect.

Jishnu

Merge fails ! Whats the reason

Edit : I tried to merge this discussion into another . That works . But can't merge to one specific Discussion that mentioned above

Hari

Jishnu Its A known and reported issue that we can not merge something into two digit numbered discussions ex 99.

Try "move post" extension 😍 it has everything you got both merge, split. Idk give it a try.

PS: Frist create a dummy discussion and make tests before using "move extension" 🙂

poVoq

Would it be possible to leave behind a redirection link for the original post after merging it?

Right now http links to the original post just fail after merging it.

IanM

poVoq Would it be possible to leave behind a redirection link for the original post after merging it?

Right now http links to the original post just fail after merging it.

We have an open issue for this FriendsOfFlarum/merge-discussions21

Hopefully soon 🤞

IanM

1.0.1

Better handling of post renumbering failures, which often produce Integrity constraint errors FriendsOfFlarum/merge-discussions30

I'm uncertain if this fully addresses FriendsOfFlarum/merge-discussions5 yet, feedback is welcome 🙏

Updating

composer require fof/merge-discussions:"*"
php flarum cache:clear

« Previous Page Next Page »