datitisev

FriendsOfFlarum/merge-discussions9
imorland commented: By adding an additional sort on the discussion first, setting the number out of the current range, then continuing with the merge, everything works again 😄

should I need to add a few more posts? then need to merge?

      Hari No, that's not what that means. The code that was added was to avoid two posts having the same number (not allowed in DB because the column must be unique) by making them extremely big and then sorting back down to normal. You can't fix the issue yourself.

        next time i will not delete or split posts. lets hope for a bug fix . fingers crossed

        Edited :

        ok i have tried to merge d-437 & d-438 to d-431

        whenever I try to do this I got an error. then i merged d-431 to d-437 it worked, next i merged d-438 to d-437 .

        renamed d-437 as d-431 luckily all posts are posted on time-based. - this resolved my issue temporarily.

          Hari basically you can't merge newer discussion into the older one. And it's really annoying, because 95% of merging is splitting some posts from one topic and merge them into another. But now you need to merge your big old topic into splitted couple of posts and then rename it, Sometimes after that some topics stop being highlighted when there are new posts. So I'm waiting for that bug fix too.

            Hello everyone, unable to merge discussions is a big issue like mentioned by goofy and others, all the time we can not pull all old discussion to new threads.

            I request FOF to fix this. I would like to contribute $20 USD towards it. (I respect the efforts, at the same time others who are getting benefited by this plugin I request them to contribute for the same)

            please bring these features :

            if a discussion is deleted. reserve space for that discussion and mention in the same page as post is deleted.
            if a discussion is moved. reserve a page mentioning newly moved discussion link
            if a discussion is merged. reserve a page mentioning newly merged discussion link

            i do not know this is a perfect solution or not, but I think this is an easy way to avoid surprising flarum core.

            in addition, creating a new rule / new extension: it should search for all flarum discussion numbers d/1 or d/3 .. to latest discussion numbers. where the new extension will create empty pages mentioning "this page is not available" and those newly created discussions to fill gaps will be automatically flagged and will not displayed to the public.
            so our FoF merge plugin will not show errors I guess

              13 days later

              Hari if a discussion is deleted. reserve space for that discussion and mention in the same page as post is deleted.
              if a discussion is moved. reserve a page mentioning newly moved discussion link
              if a discussion is merged. reserve a page mentioning newly merged discussion link

              we need these features ... PLEASE

                  Hari

                  if a discussion is deleted. reserve space for that discussion and mention in the same page as post is deleted.
                  if a discussion is moved. reserve a page mentioning newly moved discussion link

                  These don't seem to be in the scope of this extension?

                  if a discussion is merged. reserve a page mentioning newly merged discussion link

                  This could be done.

                  in addition, creating a new rule / new extension: it should search for all flarum discussion numbers d/1 or d/3 .. to latest discussion numbers. where the new extension will create empty pages mentioning "this page is not available" and those newly created discussions to fill gaps will be automatically flagged and will not displayed to the public.
                  so our FoF merge plugin will not show errors I guess

                  I'm not sure what you mean by this.

                      datitisev if a discussion is merged. reserve a page mentioning newly merged discussion link

                      This could be done.

                      Personally, I've long thought that at least a redirect being in place, but a view showing where to find the merged content would be good too..

                          IanM Yeah, I'm more in favor of a redirect as well. That's probably how I would implement it.

                            datitisev in addition, creating a new rule / new extension: it should search for all flarum discussion numbers d/1 or d/3 .. to latest discussion numbers. where the new extension will create empty pages mentioning "this page is not available" and those newly created discussions to fill gaps will be automatically flagged and will not displayed to the public.
                            so our FoF merge plugin will not show errors I guess

                            now the issue is occurring due to the empty gap between discussion numbers right?

                            as we are deleting or moving pages it's creating empty space in discussion

                            numbers and merge extension could not handle it. so I am asking to run a corn job or something to create dummy pages to fill empty discussion numbers.

                            datitisev These don't seem to be in the scope of this extension?

                            when merge discussions extension is creating gap between posts .. it should leave a note in the old pages. and old deleted or / moved page should not be visible in forum timeline. these deleted pages should be visible to for those who have direct link access. (like spiders, search engines)

                                  Hari I think you misunderstood what the issue relating to numbers is. It is not about discussion IDs, but about the post numbering in a discussion (post #1, post #2, etc... in discussion x).

                                    Whenever a discussion is completely merged into another discussion, we should redirect requests to the discussion that no longer holds posts to the one that the posts were merged into. Personally, it seems to me to make the most sense.

                                      5 days later

                                      Hari What are you trying to say with this? We know of the issue. We don't know how to/how we want to fix it.

                                      A temporary solution would be to order the posts with the number starting at a very high number, but that could cause issues, specially with a large number of posts in a discussion, so we haven't done that.

                                        Hey guys, can someone say if a bug when you can't merge newer discussion into older discussion is connected with the issue you talked about earlier? If no, can you please fix it, because now the extension is almost unusable (at least it is very hard to use) because of this.

                                          Arnold The only way currently to avoid this problem is to never delete posts permanently.

                                          Alternatively, you can merge something into a new thread without deleted posts, but that will break pretty much every link to the original thread because the extension doesn't edit the post references when merging that way.

                                          Frankly I'm unsure why post numbers are such a problem. If this is a problem that is solvable by:

                                          • split every discussion fragment (blocks of posts without missing posts in between) of the problematic discussion into a new discussion
                                          • merge all new discussions into a single discussion
                                          • merge the discussion you initially wanted to merge into the newly created discussion

                                          then it's not like we don't know how to solve it. Just because it isn't the most elegant solution doesn't mean someone should wait until Flarum core changes this with the 20th rewrite in the year 2030. If I knew more about this problem then perhaps we could develop a more sophisticated mechanism, but at this time I barely have the time to develop priority stuff we need, let alone scout the code to understand a seemingly trivial bug.

                                            7 days later

                                            I have a problem with this extension, when I type title of some existing discussion to merge with current one it doesn't show it in search. I have a lot discussions and when I start typing or enter whole title one of them it doesn't show it so I'm not able to merge because can't choose any new or existing discussion, what is the problem?

                                              bryantmilan a hidden trick is to enter the discussion Id into the search field, for our current discussion the id is 19460.