Catch The Fish

clarkwinkelmann

Are you running the latest version ? Can you share your php flarum info ? I'll try replicating.

theportablegeek

clarkwinkelmann

theportablegeek thanks! I had a similar report on the Masquerade extension and did a few tests to see whether double-submitting is possible, and was not able to reproduce.

Here are the same instructions I've posted in the Masquerade discussion, if you could give me more details:

How do you submit the forms ? Pressing Enter, clicking the button ?
If you clicked the buttons, did you double-click ?
How fast is form submission on your website ? Does it appear to be slow to save the data and refresh the view or is it nearly instantaneous ?

Can you check the browser development console for javascript errors while trying again ?

Can you try to disable some extensions to see if the problem goes away ? There are way too many extensions there for me to try reproducing with all of them.

theportablegeek

clarkwinkelmann Thanks for following up 🙂

I have disabled all but the stock extension and it is still doing the same thing.

In terms of clicking I am generally using the mouse but pressing enter does the same thing.

In terms of the form submission it is nearly instantaneous.

In terms of the JS Errors, here is what was pushed out just now:

mithril.js:2191 POST https://xxx.xxx.xxx/api/catch-the-fish/fishes/60/place 422 (anonymous) @ mithril.js:2191 (anonymous) @ mithril.js:2199 m.request @ mithril.js:2288 e.request @ Application.js:300 saveNameAndPlacement @ CaughtFishModal.js:42 onclick @ CaughtFishModal.js:128 L.t.<computed> @ mithril.js:1286

In terms of behaviour, it appears that whenever I attempt to push either of the buttons when catching and renaming the fish it actually pushes both buttons.

theportablegeek

@clarkwinkelmann Do you think it is an 8.2 issue? Also, here is a GIF of what is happening:

DimitrisLiaropoulos

I just install this plugin but i dont know how to edit the settings to create the game

clarkwinkelmann

DimitrisLiaropoulos the settings are shown in the first post

clarkwinkelmann Configuration

You will find the settings for this extension in 3 different places:

Extension settings modal: global day-based, minute-based and animation settings

Flarum permissions: all access related settings

Front end page (not in admin): Round and fish configuration

The round settings in the front end can be accessed from links underneath "new discussion"

DimitrisLiaropoulos

clarkwinkelmann when i go to index all posts are gone and link dont work ;

Cathas9lives

clarkwinkelmann Catch The Fish Setting couldn't load, resource not found in beta 10.

clarkwinkelmann

DimitrisLiaropoulos maybe there's a javascript error. You can check that in the browser javascript console under web development tools.

Cathas9lives

Could fish image use a gif?

clarkwinkelmann

Cathas9lives yes I think GIF upload is enabled.

But just like Flarum avatars, the automated cropping means the GIFs lose their animation (everything is saved as PNG). You could manually upload the animated GIF to the assets folder (assets/catch-the-fish) and update the image property of the fish in the database to point to your GIF file.

Cathas9lives

clarkwinkelmann Could I through change some codes turn off the automated cropping ?

Hari

clarkwinkelmann yes I think GIF upload is enabled.

But just like Flarum avatars, the automated cropping means the GIFs lose their animation (everything is saved as PNG). You could manually upload the animated GIF to the assets folder (assets/catch-the-fish) and update the image property of the fish in the database to point to your GIF file.

Got it 👍

clarkwinkelmann

Cathas9lives Yes, but unless you plan to upload GIFS many different times, it's probably not worth the effort of rewriting that code. The way it's written it's not as simple as adding or removing some lines.

Of course you can fork the extension and make your changes if you need.

Cathas9lives

clarkwinkelmann how can I adjust the moving speed and the moving range of images?

clarkwinkelmann

Cathas9lives that's a CSS animation, you can customize the duration via custom CSS https://github.com/clarkwinkelmann/catch-the-fish/blob/master/resources/less/forum.less#L70

If you have more details about the drag-and-drop issue (javascript error? which browser(s), etc) I'm happy to take a look, but I don't have much free time to invest in debugging/improving this extension. It was just meant as a joke/example.

Cathas9lives

And my fishes can't be placed anywhere via drag-and-drop

Cathas9lives

thanks for the reply , when I try to drop the image to somewhere, It always shows

clarkwinkelmann

Cathas9lives maybe the target doesn't fulfill the activity configured in the extension setting ? I don't remember if there's a feedback saying it's too old or not.

Can you describe steps to reproduce the issue reliably (conflict with other extension, specific browser, ?), or link to an online forum where I can see the issue ? It's working fine for me, and apparently so for all other users of the extension, so I'll need details.

Cathas9lives

clarkwinkelmann https://gametogeek.club All I could say is thanks

KuroiDark

Can't work in Chinese language...

Cathas9lives

KuroiDark

KuroiDark It works for me

« Previous Page Next Page »