FancyBox extension beta

luceos

Kylo hasn't been active for over a month. Perhaps it's time to cut your loss?

[deleted]

luceos or create a fork. In reality, it's not too difficult and could be done without an extension. It's something I'm looking at now and already have it working for pages.

Trombert

luceos @Kylo posted this on his profile "Hey everyone, I've signed up a new contract as an engineer in a merchant ship. Since we have limited quota here (25$ for 500MB, can you believe it?), it seems impossible for me to update my extensions - or to spend some spare time with the magnificent Flarum software. I've just wanted to let you guys know. Thanks for understanding!" so for now it is impossible for him, a pity...

Amarok

Trombert In this discussion in fact : https://discuss.flarum.org/d/22779-diff-for-flarum/132

We have to wait or someone could make a fork. Sad I don't know how to make that 😅

[deleted]

@datitisev @IanM @clarkwinkelmann @Kyrne @Ralkage @askvortsov

Sorry for calling you out directly (I don't normally do this), but I wanted to know if any of you were interested in taking on this extension for Beta 15 ? I'm happy to sponsor development.

malago

[deleted] Hey! I finally decided to check what was wrong with the extension for the new Flarum versions and got it updated! It was just one change in one line and it seems to be working.

Took me a while to figure out how to set up the developer environment but it was easy after knowing what I needed to do.

I can post it on a GitHub if you want! I can do it in a few days.

[deleted]

malago Whoop !! That'd be great !! Why not post it on packagist like the other extensions ?

malago

[deleted] Sure, but I would not want to claim authorship of this, as I said it was a one-line change 🤷‍♂️

I'll try to figure out how to do it, give me a few days!

[deleted]

malago Great ! What did you change, out of curiosity ?

malago

[deleted] Give it a try!

composer require malago/flarum-ext-fancybox

https://packagist.org/packages/malago/flarum-ext-fancybox

This is the only change I made, and updated the name of the extension to avoid confusions, as well as some other compatibility requirements.

[deleted]

malago not working for me sadly. I see this in the log

2021-01-27 22:57:57] flarum.ERROR: RuntimeException: Tag 'IMG' does not exist in /var/www/vhosts/metabullet.com/httpdocs/vendor/s9e/text-formatter/src/Configurator/Collections/TagCollection.php:34

malago

[deleted] Interesting... do you have the BBCode extension activated?

Can you post images in your forum with this code?

[img]https://discuss.flarum.org/assets/logo-y6hlll2o.png[/img]

I have tried my modified extension in my testing forum and my production forum and it works in both 🤔

MikeJones

malago in think [deleted] uses the upload extension so images are probably tagged differently then using bbcode for images.

[deleted]

MikeJones that's correct.

malago

[deleted] Was this extension working before for you? That part of the code is untouched.

I can add some checks to see if the tag exists, I'll do my own debug with the upload extension. I will let you know when you can update and try again.

Amarok

malago using fof/upload
one of bbcod unsing is : [upl-image-preview url=XXX.jpg]
worked with the original fancybox 🙂

ctml

Does this allow you to resize uploaded images?

Amarok

malago working for me both with [img] and [upl-image-preview url=XXX.jpg]
just having to refresh the page

Post test on my test forum

Amarok

A big plus if fof formatting add this option (fancybox) for both contents it can manage (images, youtube video, etc)

But, for now, it's just awesome having this extension working in beta 15. Thx @malago for this

malago

Amarok I'm glad to see it working!

So it has to be some other problem if it works for you with the upload extension 🤔

I didn't have time to debug it yet though...

Also, if I have more time (I have a lot to learn about Flarum extensions) I can try to improve the extension. I have to see if fancybox can also work with videos, but it might not be possible.

« Previous Page Next Page »