• [deleted]

  • Edited

Amarok This is the issue. If you look at the HTML, you'll see that the image after clicking is in fact still there

The issue is that there is an inline display: none; which is being set by the Login2See extension, and not by my extension. You can test this by disabling the Login2See extension to see if this resolves the issue.

EDIT: I could fix this by adding an inline style display: inherit. What may be happening here is that the CSS called by the extension is the stock from Fancybox itself, and that may have some bearing. However, I cannot replicate this on my own forums, and do not use Login2See, so I really do not think that is it.

I may add a note on the extension itself to note that there is an issue with Login2See, but I'd appreciate if you could disable this extension (Login2See) and let me know if it's still an issue, or if it disappears.

    [deleted]

    One thing, I don't have Login2See extension but see the same behaviour regardless of the post number.

      • [deleted]

      @Amarok @ctml This appears to be a known issue - https://stackoverflow.com/questions/14163967/how-to-make-fancybox-not-hide-original-inline-block

      However, I'm not entirely convinced that this is the actual fix. What concerns me is that the images on the site provided by @Amarok seem to have a white border around them, whereas mine do not....

      AAAANNNNNDDDD - It's reflar/recache which is the reason why I can't reproduce it. I've just disabled LazyLoad of images, and now I can reproduce exactly the same issue 🙂

      I'll work on a fix, and publish ASAP.

        [deleted] uf, it's not just us ^^ GJ anyway 😃

        The Css have some padding :

        .fancybox-slide > * {
            display: inline-block;
            position: relative;
            padding: 24px;
            margin: 44px 0 44px;
            border-width: 0;
            vertical-align: middle;
            text-align: left;
            background-color: #fff;
            overflow: auto;
            box-sizing: border-box;

        maybe it's a remnant of the other version made by @malago

          • [deleted]

          Amarok yes, I noticed this also on your site

          [deleted] I am trying to debug your error but I can't see why it is happening. It is not the fof/upload extension.

          MikeJones I tried with this extension and everything seems to be working just fine, it was also confirmed here:
          Amarok

          Anyway, I added a couple checks that should fix the issue you had if you want to try @[deleted]

          composer update malago/flarum-ext-fancybox

          or

          composer require malago/flarum-ext-fancybox

          The original extension I forked allow for captions and videos too if you have flarum/bbcode, it's on the readme:

          [url fancy=video][/url]
          [img title="Caption this."][/img]
          [url title="Caption this." fancy]![](src)[/url]
          [url title="Caption this." fancy=video][img][/img][/url]
          [url fancy][img title="Caption this."][/img][/url]

          Is anyone having issues with this forked extension?

            Does anyone know if this works with recache plugin? I think the first version did which is why I shut it off originally.

              • [deleted]

              • Edited

              MikeJones My version does composer require phenomlab/fancybox - recently updated to 0.1.4 to resolve the image disappearing bug

              @ctml @Amarok updated to resolve your issues

                MikeJones the latest is a 4k (added now). Are you sure you use the latest extension version ?
                Because you have some white borders around your pictures...

                  Amarok yea I just installed the extension. I can check the version later.

                  I noticed there is an odd animation on yours when you close the images though... Do you see that?

                  • [deleted]

                  MikeJones can you provide the output of php flarum info ? I think you have an older version.