FancyBox extension beta

solo1988

MikeJones Yep it works perfect!)))

MikeJones

solo1988 sweet! Going to try this one out tonight!

iosmall

Images that use external links are not available.

squeevee

iosmall They should be. Could you open an issue on the GitHub repo? https://github.com/squeevee/flarum-ext-fancybox

iosmall

iosmall 使用外部链接的图像不可用。

Is this problem solved?

MikeJones

Just installed! This extension is exactly what I wanted since day one! You are a hero!

My Flarum is an outdoor adventure FLarum and thus has a tone of pictures! I love how clean and simple this Fancy box is too!

If anyone is interested in seeing this extension in production you can check out all my pictures on my flarum here: https://www.seekadventure.net

squeevee

MikeJones I'm glad it's working for you! Thanks for providing a demo

MikeJones

squeevee No, thank you for building this! Literally been wanting this extension forever!

Romellie

this breaks the Sticky extension

Romellie

and hide text-input block to write messages

squeevee

Romellie The text input bug should be fixed with the next beta release. I don't have an ETA for that yet.

Would you mind opening the Sticky bug as an issue on the github repo? https://github.com/squeevee/flarum-ext-fancybox

Thanks

squeevee

Romellie This release should fix your problem.

squeevee

I have issued a new Beta release which fixes 2 bugs and updates the Readme.

iosmall I suspect that this release will fix your problem. However, I have not been able to reproduce your problem on my own setup, so I don't know. Please try it out and let me know on GitHub.

squeevee

iosmall I know it has been a while, my apologies. Please see my most recent reply to your issue on GitHub

MikeJones

squeevee how do we update to the latest release?

squeevee

MikeJones

composer update
php flarum cache:clear

SezginYILDIRIM

squeevee sorry, not corrected ;

MikeJones

squeevee That updated a whole bunch of things not just this extension...

What version should I be running to make sure its up to date?

clarkwinkelmann

MikeJones composer require vendor/package is the command that will always install the latest possible version of a package, without updating other extensions.

[deleted]

@squeevee not sure if you are aware, but with this extension enabled, the ability to post or respond is no longer possible. Pressing F12 and viewing the console shows this

Uncaught TypeError: this.isEditing is not a function
    at e.<anonymous> (forum-a47e66a5.js:1084)
    at e.t.<computed> [as config] (forum-a47e66a5.js:1)
    at Object.e.attrs.config (forum-a47e66a5.js:1)
    at forum-a47e66a5.js:1
    at forum-a47e66a5.js:1
    at v (forum-a47e66a5.js:1)
    at Function.m.render (forum-a47e66a5.js:1)
    at forum-a47e66a5.js:1
    at v (forum-a47e66a5.js:1)
    at ut (forum-a47e66a5.js:1)

Disabling the extension resolves it.

MikeJones

@squeevee new error for you. Your extension sometimes breaks the post scrubber on the right. I have captured the details in this post: https://discuss.flarum.org/d/20064-scroll-bar-on-the-right-broken-on-one-post