FriendsOfFlarum Follow Tags

mrXmr

What is the difference between "Following: be notified of all new discussions", and, "Lurking: be notified of all new discussions and replies" ?
They sound quite the same, so what new functionality does this extension add?

Teddan

mrXmr This is the feature about following a tag. "following" only notifies you for every new discussion in the tag you are followed. "lurking" notifies you every new discussions and every new posts under every discussions.

IanM

1.2.0

What's changed?

feat: extensible subscriptions by @IanM in FriendsOfFlarum/follow-tags63
- Introduces a new extensible SubscriptionModal to select the tag subscription options, in place of the old menu.
- Added a new event SubscriptionChanging, which developers can listen for in order to extend the subscription behaviour
- Removes SubscriptionMenuItem and SubscriptionMenu

Screenshot

Updating

composer update fof/follow-tags
php flarum cache:clear

IanM

1.3.0

What's changed?

feat: Localized notifications based on discussion language by @IanM in FriendsOfFlarum/discussion-language44
- Full integration with fof/follow-tags to allow users to subscribe to tags, but only recieve notifiations for discussions/posts that are written in the language they choose.

Requires fof/follow-tags v`1.2.0 or greater IanM

Screenshot

Updating

composer require fof/discussion-language"*"
php flarum migrate
php flarum cache:clear

rafaucau

IanM This is broken on mobile: FriendsOfFlarum/follow-tags64

Litalino

rafaucau I use css some solved steps..

@media (max-width: 767.98px) {

    .App--index {
       /**Enable Search Menu Mobi**/
        & .Header-controls {

            & .item-search {
                display: block !important;
            }
        }
       /**Enable Follow Mobi **/
        & .item-subscriptionButton {

            & .SubscriptionButton {
                width: auto  !important;
                right: 10%;
                margin-top: 5px !important;
            }
        }
       /**Disable Icon checkin**/
        & .item-forum-checkin-1  .App-primaryControl {
                display: none;
            }
        }
    }

}

@media (max-width: 767.98px) {

    .App--index {
       /**Enable Search Menu Mobi**/
 
       /**Enable Follow Mobi **/
        & .item-subscriptionButton {

           & .SubscriptionButton {
                margin-top: 5px !important;
            }
            & .App-primaryControl {
                top: unset !important;
                position: relative !important;
                border-radius: 4px;
                flex: 1;
               padding-left: 20px;
              padding-right: 20px;
            }
        }
       /**Disable Icon checkin**/
     
    }

}

rafaucau

Litalino

  @media @phone {
    .IndexPage-nav .SubscriptionButton {
      background: transparent;
      width: auto;
      height: var(--header-height-phone);
      right: 46px;

      i {
        margin-right: 0;
      }

      .Button-label {
        display: none;
      }
    }
  }

Litalino

rafaucau

Depending on how the icon is displayed, you should adjust it like this to make the icon look beautiful

  @media @phone {
    .IndexPage-nav {

        & .SubscriptionButton {
            background: transparent;
            width: auto;
            height: var(--header-height-phone);
            right: 35px;

            i {
                font-size: 20px;
                display: block;
                margin: 0;
            }

            .Button-label {
                display: none;
            }
        }
    }
  }

DEMO ICON

Located on the Discussion button

@media @phone {

    .App--index {
       /**Enable Search Menu Mobi**/
 
       /**Enable Follow Mobi **/
        & .item-subscriptionButton {

            & .SubscriptionButton {
                margin-top: 5px !important;
            }
            & .App-primaryControl {
                top: unset !important;
                position: relative !important;
                border-radius: 4px;
                flex: 1;
                padding-left: 20px;
                padding-right: 20px;
            }
        }
       /**Disable Icon checkin**/
     
    }
}

DEMO BUTTON

IanM

rafaucau Litalino

Thanks for coming up with a solution for this. Feel free to PR it to the repository: FriendsOfFlarum/follow-tags

rafaucau

IanM Done: FriendsOfFlarum/follow-tags66

IanM

1.2.1

fix: mobile SubscriptionButton styles by @rafaucau in FriendsOfFlarum/follow-tags66

Full Changelog: FriendsOfFlarum/follow-tags1.2.0 → 1.2.1

Updating

composer update fof/follow-tags
php flarum cache:clear

ToneLune

Hello,

Thank you for this superb application, which works wonders when coupled with email discussion lists (Sympa works very well together).

Only, I have a small problem when I want to change the translation string of flarum-mentions.email.user_mentioned.subject

If I leave the original value, the subject of the email is displayed correctly. But if I save a new value in FoF-Linguist (even for an identical value): the subject is displayed with a brace at the end -> }
Same problem for other character strings, for example with fof-follow-tags.email.body.newPostInTag, {recipient_display_name} {actor_display_name} (etc) are replaced by their value but surrounded by braces -> { }

Thank you very much & happy new year !

davetodave178

ToneLune I have run into this also already a couple of times. In the case of email translations within fof/follow-tags you can just not include them, and it will still parse correctly. For these sorts of situations, you can always check out the Blade Templates and verify how it's being parsed; in your case it would be /resources/views/emails/newPost.blade.php. Hope this helps!

ToneLune

Hello, thanks for your help !

Unfortunately, I didn't quite understand how to resolve my problem with your instructions?

In /resources/views/emails/newPost.blade.php :

{!! $translator->trans('fof-follow-tags.email.body.newPostInTag', [
    'recipient_display_name' => $user->display_name,
    'actor_display_name' => $blueprint->post->user->display_name,
    'discussion_title' => $blueprint->post->discussion->title,
    'post_url' => $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]),
    'post_content' => $blueprint->post->content,
]) !!}

What should I modify?

Edit : I simply modified the translation lines in the .yml file of my language pack (/vendor/flarum-lang/french/locale/fof-follow-tags.yml for me), everything is displayed correctly.

datitisev

1.2.4

Improve performance when loading the user's state for tags
- There's some instances when the data loaded by Flarum is not for the current user, and so the state is incorrect, needing another query to find the right one
- See FriendsOfFlarum/follow-tags72 and flarum/framework4007
1.2.2 Support GDPR export (FriendsOfFlarum/follow-tags69)

xhz588

datitisev

Warning: Attempt to read property "user_id" on null in exmaple.com/vendor/fof/follow-tags/src/AddTagSubscriptionAttribute.php on line 41

I got this problem

clarkwinkelmann

xhz588 you should disable PHP Warnings in production.

datitisev

xhz588 Clark is correct - PHP warnings should be disabled in prod. But the report is still helpful.

I've released v1.2.5 also addressing this.

xhz588

clarkwinkelmann

I got Fatal error just after that warning:

Fatal error: Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in example.com/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:20 Stack trace: #0 example.com/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(42): Laminas\HttpHandlerRunner\Exception\EmitterException::forOutputSent() #1 example.com/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(21): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->assertNoPreviousOutput() #2example.com/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(75): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->emit() #3 example.com/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #4 example.com/public/index.php(26): Flarum\Http\Server->listen() #5 {main} thrown in example.com/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php on line 20

datitisev

xhz588

datitisev

Sorry I'm a bit unfamiliar with php, what is the correct way for disable warnings for flarum? I did some research and there are 10+ ways for doing it.

datitisev

xhz588 The fatal error is caused by the warning, since it prints output to the response.

xhz588

datitisev

Oh ok, I thought it was an error.

datitisev

xhz588 Nah - the "output has been emitted previously" error actually means something happened before it that prevented the page content from being returned from the server normally. Usually caused by warnings & deprecations that just print out and don't stop the request from processing, which makes the server attempt to send a response as if nothing has been returned yet.

xhz588 You do this through the php.ini configuration file. It does seem like the default PHP config is to not disable warnings though. But I think that doesn't matter since it display_errors should be off in prod, so warnings should just be logged. See php/php-srcblob/master/php.ini-production#L97-L115

« Previous Page