Looking to pay someone to fix my adsense issue

MikeJones

You can read my issue here: https://discuss.flarum.org/d/4785-flagrow-ads-bombarding-your-users-with-ads-everywhere-if-you-want/159

I am willing to pay $60 to fix this issue and to have the ads reload each time you visit a new page.

luceos

I'll add 60 Euro if the fix is a quality pr against the ads repository and thus benefits all users. Paid through PayPal or bank transfer only.

MikeJones

luceos thanks for adding your own money to this too.

I forgot to mention my payment will be through PayPal

Kyrne

I'm willing to give this a shot, can you DM me on discord so I can get a few more details?

MikeJones

Kyrne I will hit you up in the morning. I have some posts on Google that may help narrow down the issue. Is your user name the same on discord?

Prosperous

Awesome incentive here to fix a problem for a lot of users, so good to see!

Kyrne

MikeJones sounds good, CDK2020#9728, you can find me in the flarum discord

Kyrne

I've pinned down the problem:

Problem #1: Ads don't display when visiting a discussion page directly.
Cause: It seems Flarum displays the content and runs the "show ads" script from google before the script is even ready, so it must be run after verifying the script is ready to go.

Problem #2: Ads don't update on page change
Cause: This one was harder, the header isn't refreshed when the page changes so the element isn't redrawn, not only that but google ads are essentially redraw proof to prevent people from refreshing ads on the same page. The solution was manually redraw the elements with jquery so Google detects the URL change and sends a new ad over.

I am waiting for my adsense approval, as soon as I get it I will fully test it and PR it to the main repo.

matteocontrini

Kyrne runs the "show ads" script from google before the script is even ready, so it must be run after verifying the script is ready to go.

When you say "show ads" script do you mean this part?

(adsbygoogle = window.adsbygoogle || []).push({});

As far as I know this line is specifically written like that to allow ads to be "enqueued" before the adsbygoogle.js script is loaded. There should be no need to delay it.

https://stackoverflow.com/a/42033159/1633924

MikeJones

@Kyrne solved all my issues! I should see a lot more ad hits on my site, thanks again man you were a pleasure to work with!

YusufYldrm

This is a general problem. Can the team update the ads extension?

Kyrne

YusufYldrm I have submitted the PR and we are in the process of reviewing it. It will be updated soon

Kyrne

matteocontrini That script tells the ad spots on the page to render, it can't render them if it is ran if Flarum runs the script before the ad spots are put on the page and thus it must be delayed.

I have gotten it to work, the only thing the user has to change is to remove that script from their ads settings.

luceos

Tagged as 0.2 Kyrne send me your paypal info through discord dm 👍️

MikeJones

It works, it's running on my flarum now if you want to check it out www.seekadventure.net