Wlork What I believe they said is that if a user doesn't have "change vote" permission, they can't currently vote for more than 1 option. How the extension currently works is that you vote for one option, then either vote for more (if you can) or unvote from that one and vote for another. Thus, a user without "change vote" permission can only vote for that first option in polls that allow multiple votes.

Adding a button to confirm votes would fix this, but that seems like worse UI to me. Where'd you put that button? At the bottom of a long list of poll options that people on mobile phones might miss? UX wise, I believe the current implementation is best, but that does cause issues with changing votes.

I think the "change vote" permission could be refactored into not allowing vote changes after some time, similar to editing tags. That would probably make it work without degrading the user's experience 🤔

      datitisev You're right !

      Polls are easy to use thanks to the light interface and I think it's important not to break this.

      Change or not our votes for a limited time.... Yes, your idea seems better to me 🙂

        Wlork I'm not sure I understood his request ?

        Sry, it was late and I was tired. Guess that's why it sounded really awkward. 🙁

        Wlork OK, a button

        datitisev Adding a button

        Yep, I thought the same, but I can totally understand your ( @datitisev ) concerns.

        datitisev I think the "change vote" permission could be refactored into not allowing vote changes after some time, similar to editing tags. That would probably make it work without degrading the user's experience 🤔

        It would be the same as "Allow post editing" (Indefinitely, 10min, until next reply) but maybe with a custom time interval. This solutions sounds great actually.

                6 days later

                I'm sorry to ask again, but I haven't had a reply 🙁

                Several weeks ago, I made a proposal to be able to post a poll in any post. And I'd like to know if this was feasible (I suppose so, otherwise you wouldn't have opened a bounty.) or if this is something that is difficult or not to develop ?

                Thanks in advance 🙂

                  Wlork I believe it's definitely possible. However, it'd require changing the association of polls from discussions to polls, which would be a large refactor of both backend & frontend -- at least this is how I would accomplish this feature.

                    Wlork please understand that a bounty opens a possibility to provide money as an incentive to implement this. Developers decide depending on complexity when that is the case. If you want to have something implemented on a contract basis you need to make a request inServices

                      Hello all!

                      I've been hard at work refactoring this extension and adding new features for a v2. Some of the often request changes included are: adding polls to posts, and having multiple polls per discussion/poll.

                      The operation that converts the poll association from discussions to posts is destructive in the case that fof/polls cannot find an associated 'first post'. I don't believe this is an issue, since in those cases the poll shouldn't be currently appearing in the forum anyways (aside from the badge).

                      However, just to be safe, I would prefer that others (with a lot more "old data") test these changes. Just to be safe that everything seems to work as it should migrating to this new version.

                      🛑 DISCLAIMER: THIS IS NOT BACKWARDS COMPATIBLE. DO NOT TEST IN PRODUCTION. BACKUP DATA 🛑

                      That out of the way, there's one PR to test: FriendsOfFlarum/polls73. This PR contains potentially destructive behavior that is unwanted - I want to verify that it only deletes what it should, and nothing else unintentionally. I also have a 2nd PR that builds off this first one, but that one doesn't require testing to avoid unintentional data loss.

                      If you know how to clone extensions & test their PRs already - great, feel free to do that. If not, you can test these PRs by running composer require fof/polls:dev-ds/move-polls-to-posts.

                      With a DB backup ready to restore (!), running php flarum migrate will perform the migrations that have a chance to delete polls. You'll know if it does if the logs contain a line with a count of how many polls were deleted - and their IDs. Knowing their IDs, you can restore the backup, go back to the latest v1 version of fof/polls, and check whether the poll showed up in its discussion. If it didn't, then there's no issue. If there is an issue, please provide info on what the discussions whose polls were deleted when they shouldn't have been.

                      Note: the purpose of testing this is to verify that migrating from v1 to v2 works as intended. Testing this PR in a new, blank installation won't be nearly as helpful.

                        datitisev and having multiple polls per discussion/poll.

                        You mean it will be possible to create several polls in any post ? If yes, that's great news! Thank !

                        I won't be able to test it 🙁 I don't meet the conditions and, above all, I don't have the skills yet. Flarum is still new to me, I'm still learning. I hope you will find volunteers.

                        I can't wait to install and use it in its final version 🙂

                            Wlork Those conditions are mainly to get the best data. Data that has been through a lot of other extension use for a long period of time, as it'd lead to more unpredictable scenarios. You can test it if you want; any amount of testing is helpful.

                            Wlork You mean it will be possible to create several polls in any post ?

                            Indeed! See FriendsOfFlarum/polls74.

                                  datitisev

                                  I'd like to test, but I don't have much data (I have only two polls that are actually used) and as I'm not 100% familiar with Flarum yet, I don't want to take any risks on my forum which is active 🙁

                                  The best I can do is create a test forum, create 10 or 20 polls with v1 and then test v2. But I don't know if that would be as effective?

                                  I like the changes you've made to the buttons 🙂

                                      Hi @datitisev would it be possible to show the number of votes in a poll? Right now you can only see the activity of a poll by entering the voters, it's not a problem when there are few votes, but if a poll has a lot of activity (100 votes, for example) you wouldn't be able to see that data.

                                      I was wondering if it would be possible to add a line of text below the poll "Total votes: 100".

                                        Oshvam It's definitely possible. I don't love the idea of just adding this info underneath with more lines of text, but also can't really think of a simple way to show it. Either way, I won't include it in my initial bulk of changes coming, as that's convoluted enough.

                                          @datitisev

                                          I create 20 polls in my forum test in v1.

                                          What next ?

                                          I type these commands :

                                          composer require fof/polls:dev-ds/move-polls-to-posts
php flarum migrate

                                          I test v2 and tell you if the v1 polls have been deleted or not. Is this correct? 🙂

                                            Wlork Indeed. If you just created normal discussions with polls without doing much else, there's less of a chance that any of the polls will be deleted. The deletion comes into place when the first post associated with a discussion can't be found -- which means v1 polls would not be showing that poll anyways, leading to the deletion to not destroy any visible data.

                                            If any polls have been deleted, you can go ahead and restore from a DB backup and see if their discussions showed that poll in v1. If not, then there's no issue.

                                            To go back from v2 to v1, you'll need to disable polls & click the "Purge" button to delete all the fof/polls data from the DB. Then you can use composer to go back to a stable version.

                                                datitisev

                                                So.... 🙂

                                                • I created 10 polls with v1
                                                • I left the extension enabled. No purge
                                                • I typed the command :

                                                composer require fof/polls:dev-ds/move-polls-to-posts

                                                • And :

                                                php flarum migrate

                                                Many errors :

                                                In Connection.php line 712:

                                                SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list' (SQL: update NameDBpolls inner join
                                                NameDBdiscussions on NameDBpolls.discussion_id = NameDBdiscussions.id and NameDBdiscussions.first_post_id is not null
                                                set NameDBpolls.discussion_id = discussions.first_post_id)

                                                In Exception.php line 18:

                                                SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list'

                                                In PDOStatement.php line 117:

                                                SQLSTATE[42S22]: Column not found: 1054 Unknown column 'discussions.first_post_id' in 'field list'

                                                My forum (test) has turned empty. There's only the navigation bar.

                                                I had to deactivate the extension to see my forum again. And it's impossible to reactivate FoF Polls without purging. The v1 polls have disappeared. I was able to test the v2 polls and at first sight they work fine.

                                                    Wlork Well, that was helpful testing! My code didn't work with Flarum setups that utilized SQL table prefixes. That should be resolved with my last changes. Before trying them out, either have a v1 setup or purge the extension (I split a migration file into two, so that'd run again and cause issues). I do remember composer sometimes being finicky with updating dev branches that are required, so I don't know if running that command again will update successfully or not.

                                                        datitisev

                                                        Glad I could help you !

                                                        • I created polls in v1
                                                        • FoF Polls v1 enabled. No Purge.
                                                        • I typed these two commands in order.

                                                        No problem with SQL !

                                                        However, the v1 polls have disappeared. BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

                                                        I've noticed a small issue with v2 polls. When I edit a poll, I have to refresh the page to see modifications.

                                                        I don't know if this is a bug or if it's intentional ? If it's intentional, then everything's fine.

                                                        Tomorrow I'll do some more test. It's getting late here 😛

                                                            @datitisev

                                                            I tried again and no problem with SQL 🙂
                                                            However, you need to remember to deactivate (no purge !) and reactivate extension FoF Polls to "transform" v1 polls into v2

                                                            And I was able to test more v2 polls.

                                                            Bugs :

                                                            Affected : everyone

                                                            • If we make any changes (title, answers, images, options, end date, etc.) to our survey, we have to refresh the page manually to see the changes.

                                                            You've made changes to the way you edit a poll (and I like it). I think this bug comes from this modification, because v1 doesn't have this problem.

                                                            Affected : those who don't have "View results without voting" permission.

                                                            • If we cancel our vote (our last choice, in the case of multiple answers), the count (%) remains. You'll have to refresh the page manually to reset it to zero.

                                                            I haven't noticed any other issues 🙂

                                                            If you want me to test v2 polls in its entirety, I'll do it 🙂

                                                              Wlork This is my fault for bundling those changes with that PR, I thought I had separated them into the other one to be honest. But that's good, because those are not breaking issues and just simple regressions. Thank you, though.

                                                              Wlork BUT ! By deactivating FoF Polls (no purge) and reactivating it, the polls reappeared in v2 🙂 !

                                                              You probably needed a cache clear. You were using the old code which had polls associated with discussions, of which it found none once the move to post association was made.

                                                              EDIT: I've fixed the issue with the vote count remaining. The issue regarding changes to the poll is fixed in the 2nd PR, which if you want to test, you can do with composer require fof/polls:dev-ds/more-breaking-v2-changes (contains v2 DB breaking changes from ds/move-polls-posts)