FriendsOfFlarum Polls

Justoverclock

Works fine on beta 16 on Flarum.it

clarkwinkelmann

Versions 0.3.3 and 0.4.0

Version 0.3.3:

Improved performance by no longer loading the list of all votes all the time
Added new permission to see vote results before voting. Defaults to administrators
Added new permission to control the ability to change vote. Defaults to administrators. Change it in the admin panel if you want to keep the old behavior.
Security: when disabling "Allow people to see who voted", the API now no longer returns the details of the votes
Security: the vote results are now hidden from the API until the user votes or has the new "see vote results" permission
Fixed Pusher integration

This update is compatible with both Flarum beta 15 and 16.

Version 0.4.0:

Updated deprecated Flarum beta 16 code.
Allowed to set "see vote results before voting" permission to guests.

This update is compatible with only Flarum beta 16.

Update instructions

To update (for both Flarum beta 15 and 16), run:

composer require fof/polls:*
php flarum migrate
php flarum fof:polls:refresh

The last command might take longer to run on forums with a large number of polls.

If you use the Polls websocket messages as part of a custom integration, please give us feedback at FriendsOfFlarum/polls38

ctml

clarkwinkelmann fantastic, I have started using the poll extension more recently so I am very glad to see it getting some enhancements. thank you fof team & clark! 🧡

JohnP

clarkwinkelmann Since updating it seems that 'Allow people to see who voted' is on for existing polls when it wasn't before, and editing poll and turning it on and off makes no difference.

phloo

clarkwinkelmann Security: the vote results are now hidden from the API until the user votes or has the new "see vote results" permission

Is this the permission "View results without voting"?
It's set to users but even as admin I cannot see the results.

clarkwinkelmann

Version 1.0.3

I have released version 1.0.3 with a fix for the error on user profiles.

sylv38 if I open older polls posted with beta 15, everything is 0%

You need to run this command https://github.com/FriendsOfFlarum/polls#metadata-update when updating from a version before 0.3.3 . The explanation was also copied in this post clarkwinkelmann

clarkwinkelmann

Version 0.4.1

Fixed issue introduced in 0.3.3/0.4.0 where having "View results without voting" permission would allow you to see voters of private polls.

Compatible with Flarum beta 16 only.

If you are updating from version 0.3.2 or older, check the update instructions in the 0.4.0 release notes above.

JohnP I think that was your issue. Let me know if this new version resolves it.

JohnP

clarkwinkelmann Yep, that resolves it, thanks.

huuduy216

Is it me or the poll result take a significant amount of time to load after this update? (about 3 seconds)
Also, seems like I can't edit an expired poll?

clarkwinkelmann

huuduy216 the poll result take a significant amount of time to load

You mean the time between click and seeing the % ? Or the time to open the modal when clicking "View votes"?

For both it's "normal" that there is a new delay because the data is now only loaded when you actually click it instead of being pre-loaded with the page. But if it's really too long maybe there's an issue.

Previously it was really "instantaneous" when clicking on an option because the refresh would be done entirely client-side at the exact moment you clicked. Now it waits for the server to confirm the vote was submitted.

I think the extension would benefit from some loading spinners, but the new features already took a lot of time so I skipped that. But it's definitely something I would consider adding if I make another update.

huuduy216 I can't edit an expired poll

As a normal user, or admin? Is there a message? Or maybe there's a javascript error in the browser console? I don't think I actually tested that, I didn't think there would be any difference from the code. You mean change the polls settings under the 3-dot menu? Does the modal appear at all?

huuduy216

clarkwinkelmann as an admin, trying to edit a user created poll. I don't see the option anymore 🤔

clarkwinkelmann

huuduy216 looking at the code, it doesn't seem the behavior changed in yesterday release.

However I can confirm that admins were indeed unable to edit polls that had ended. I have created a PR to fix it, I'll merge this weekend FriendsOfFlarum/polls39

huuduy216

clarkwinkelmann maybe it were never available and nobody thought about it? 😅

clarkwinkelmann

huuduy216 there's unfortunately still a lot of mystery and odd behavior in the source code of this extension. It's what happens with extensions that are this old 😅

At the very least, now information that's supposed to be hidden from view is also properly hidden from the API.

During the update I have removed some code that checked whether the user had permissions that never existed... That code probably wasn't very useful. The internal naming of the permission is completely nonsensical. There's also some incredible code duplication, which is slowly being taken care of by the latest PRs.

The frontend is still a bit messed up. The code for DiscussionPoll isn't very readable, but I'm reluctant to introduce massive changes because first it's a lot of work, and also because I know clients have custom code and CSS for it that will break when I do 😭

The way a checkbox input is used for the vote choice also isn't a good choice with Mithril, it can lead to the checkbox not showing the correct state after an error, and there's no way to fix it without rewriting most of that component and the CSS 😬

Ralkage

clarkwinkelmann The way a checkbox input is used for the vote choice also isn't a good choice with Mithril, it can lead to the checkbox not showing the correct state after an error, and there's no way to fix it without rewriting most of that component and the CSS

I figured as much 😉 once Flarum reaches stable, so to, will FoF extensions become slowly stable and improved (for the old extensions that is 😂)

Kakifrucht

I have a problem on Flarum beta16 and polls v0.4.1.
When accessing a user profile page containing a poll, the post preview won't load anymore, and any subsequent post previews aren't loaded either. The javascript console displays this error:

TypeError: t.poll().options().map is not a function
    exports addPollToDiscussion.js:34
    needsRebuild SubtreeRetainer.js:47
    needsRebuild SubtreeRetainer.js:46
    check SubtreeRetainer.js:67
    exports addPollToDiscussion.js:20
    e extend.js:27
    a render.js:30
    M render.js:917
    l render.js:153
    l render.js:160
    l render.js:66
    u render.js:50
    l render.js:134
    l render.js:63
    u render.js:50
    h render.js:277
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    f render.js:488
    f render.js:419
    h render.js:315
    f render.js:444
    f render.js:415
    f render.js:488
    f render.js:419
    h render.js:302
    exports render.js:964
    a mount-redraw.js:14
    c mount-redraw.js:25
    c mount-redraw.js:23
    parseResults PostsUserPage.js:154
    promise callback*flarum.core</ke</n.refresh PostsUserPage.js:111
    show PostsUserPage.js:97
    promise callback*flarum.core</le</n.loadUser UserPage.js:105
    oninit PostsUserPage.js:44
    a render.js:30
    M render.js:917
    l render.js:153
    l render.js:160
    l render.js:66
    u render.js:50
    h render.js:374
    f render.js:444
    f render.js:415
    f render.js:488
    f render.js:419
    h render.js:302
    exports render.js:964
    a mount-redraw.js:14
    c mount-redraw.js:25
    c mount-redraw.js:23
    v router.js:111
    promise callback*t router.js:126
    S router.js:95
    f setImmediate.js:40
    f setImmediate.js:69
    a setImmediate.js:109
    core setImmediate.js:114
    core setImmediate.js:186
    core

From this point on the entire forum seems to break in different ways. I hope this is enough to reproduce this issue.

clarkwinkelmann

Kakifrucht can you create a GitHub issue? There must be an issue with the way I wrote the SubtreeRetainer condition... it probably doesn't handle correctly when the discussion is partially loaded.

Kakifrucht

clarkwinkelmann done FriendsOfFlarum/polls40

fakruzaruret

@FriendsOfFlarum Will be added non-member guest voting?

clarkwinkelmann

[deleted] can you explain on which screen(s) you see the performance issues? and which version of the extension you are using? Is it only the voters modal or other part of the app?

A recent update brought a huge performance improvement to browser Polls results in discussion.

However the voters modal still doesn't use pagination because of the weird layout. We should add pagination but this requires completely redesigning that modal and the way the detailed votes are retrieved which is not an easy task.

fakruzaruret that will probably never be implemented in the open-source extension, it's too complex. I implemented it for a client in https://extiverse.com/extension/kilowhat/flarum-ext-guest-posting (and it's still very limited)

[deleted]

@FriendsOfFlarum It hangs a lot and sometimes takes too much time to even view voters however it disturbs user experience very much, Please fix this issue.

fakruzaruret

clarkwinkelmann This make me sad but I cant do anything. I am waiting for little possibility at future. 😀

« Previous Page Next Page »