FriendsOfFlarum Polls

huuduy216

clarkwinkelmann as an admin, trying to edit a user created poll. I don't see the option anymore 🤔

clarkwinkelmann

huuduy216 looking at the code, it doesn't seem the behavior changed in yesterday release.

However I can confirm that admins were indeed unable to edit polls that had ended. I have created a PR to fix it, I'll merge this weekend FriendsOfFlarum/polls39

huuduy216

clarkwinkelmann maybe it were never available and nobody thought about it? 😅

clarkwinkelmann

huuduy216 there's unfortunately still a lot of mystery and odd behavior in the source code of this extension. It's what happens with extensions that are this old 😅

At the very least, now information that's supposed to be hidden from view is also properly hidden from the API.

During the update I have removed some code that checked whether the user had permissions that never existed... That code probably wasn't very useful. The internal naming of the permission is completely nonsensical. There's also some incredible code duplication, which is slowly being taken care of by the latest PRs.

The frontend is still a bit messed up. The code for DiscussionPoll isn't very readable, but I'm reluctant to introduce massive changes because first it's a lot of work, and also because I know clients have custom code and CSS for it that will break when I do 😭

The way a checkbox input is used for the vote choice also isn't a good choice with Mithril, it can lead to the checkbox not showing the correct state after an error, and there's no way to fix it without rewriting most of that component and the CSS 😬

Ralkage

clarkwinkelmann The way a checkbox input is used for the vote choice also isn't a good choice with Mithril, it can lead to the checkbox not showing the correct state after an error, and there's no way to fix it without rewriting most of that component and the CSS

I figured as much 😉 once Flarum reaches stable, so to, will FoF extensions become slowly stable and improved (for the old extensions that is 😂)

Kakifrucht

I have a problem on Flarum beta16 and polls v0.4.1.
When accessing a user profile page containing a poll, the post preview won't load anymore, and any subsequent post previews aren't loaded either. The javascript console displays this error:

TypeError: t.poll().options().map is not a function
    exports addPollToDiscussion.js:34
    needsRebuild SubtreeRetainer.js:47
    needsRebuild SubtreeRetainer.js:46
    check SubtreeRetainer.js:67
    exports addPollToDiscussion.js:20
    e extend.js:27
    a render.js:30
    M render.js:917
    l render.js:153
    l render.js:160
    l render.js:66
    u render.js:50
    l render.js:134
    l render.js:63
    u render.js:50
    h render.js:277
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    h render.js:302
    f render.js:477
    f render.js:416
    f render.js:488
    f render.js:419
    h render.js:315
    f render.js:444
    f render.js:415
    f render.js:488
    f render.js:419
    h render.js:302
    exports render.js:964
    a mount-redraw.js:14
    c mount-redraw.js:25
    c mount-redraw.js:23
    parseResults PostsUserPage.js:154
    promise callback*flarum.core</ke</n.refresh PostsUserPage.js:111
    show PostsUserPage.js:97
    promise callback*flarum.core</le</n.loadUser UserPage.js:105
    oninit PostsUserPage.js:44
    a render.js:30
    M render.js:917
    l render.js:153
    l render.js:160
    l render.js:66
    u render.js:50
    h render.js:374
    f render.js:444
    f render.js:415
    f render.js:488
    f render.js:419
    h render.js:302
    exports render.js:964
    a mount-redraw.js:14
    c mount-redraw.js:25
    c mount-redraw.js:23
    v router.js:111
    promise callback*t router.js:126
    S router.js:95
    f setImmediate.js:40
    f setImmediate.js:69
    a setImmediate.js:109
    core setImmediate.js:114
    core setImmediate.js:186
    core

From this point on the entire forum seems to break in different ways. I hope this is enough to reproduce this issue.

clarkwinkelmann

Kakifrucht can you create a GitHub issue? There must be an issue with the way I wrote the SubtreeRetainer condition... it probably doesn't handle correctly when the discussion is partially loaded.

Kakifrucht

clarkwinkelmann done FriendsOfFlarum/polls40

fakruzaruret

@FriendsOfFlarum Will be added non-member guest voting?

clarkwinkelmann

[deleted] can you explain on which screen(s) you see the performance issues? and which version of the extension you are using? Is it only the voters modal or other part of the app?

A recent update brought a huge performance improvement to browser Polls results in discussion.

However the voters modal still doesn't use pagination because of the weird layout. We should add pagination but this requires completely redesigning that modal and the way the detailed votes are retrieved which is not an easy task.

fakruzaruret that will probably never be implemented in the open-source extension, it's too complex. I implemented it for a client in https://extiverse.com/extension/kilowhat/flarum-ext-guest-posting (and it's still very limited)

[deleted]

@FriendsOfFlarum It hangs a lot and sometimes takes too much time to even view voters however it disturbs user experience very much, Please fix this issue.

fakruzaruret

clarkwinkelmann This make me sad but I cant do anything. I am waiting for little possibility at future. 😀

IanM

1.0.0

Flarum 1.0 ready

Once again, we thank our friends @glowingblue for updating this extension for Flarum 1.0. 🎁

Installation

composer require fof/polls:"*"
php flarum cache:clear

User24

IanM Any idea of bringing multiple polls to single thread or discussion?

IanM

User24 Any idea of bringing multiple polls to single thread or discussion?

At this stage no

IanM

1.0.1

Address inconsistency between frontend and backend abilities (FriendsOfFlarum/polls39)

Installation

composer require fof/polls:"*"
php flarum cache:clear

Hari

can we set the poll bar in one line like Twitter and youtube poll? currently its showing horizontally

wloot

I have this error on web console:

Uncaught (in promise) TypeError: Cannot read property 'bind' of undefined

After a quick check, it seems the error is comes from: https://github.com/FriendsOfFlarum/polls/blob/52e02711a1c5546f35a0def96782789b4f083205/js/src/forum/addPollToDiscussion.js#L46

luceos

wloot which websocket extension do you use?

wloot

luceos pusher

luceos

wloot and it is enabled and configured properly?

« Previous Page Next Page »