Increased JS errors after switching to beta9

wwwn

Hi everybody. I updated my Flarum site from Beta 8 to beta 9. Today I noticed that there are JS errors in the browser. Why is this possible? flarum.org does not have such an error!

Flarum core 0.1.0-beta.9
PHP version: 7.2.19-0ubuntu0.18.04.1
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, sodium, session, standard, mysqlnd, PDO, xml, apcu, apc, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, intl, json, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, soap, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlrpc, xmlwriter, xsl, zip, Zend OPcache
+-------------------------------+-------------------+--------+
| Flarum Extensions             |                   |        |
+-------------------------------+-------------------+--------+
| ID                            | Version           | Commit |
+-------------------------------+-------------------+--------+
| flarum-approval               | v0.1.0-beta.8     |        |
| flarum-bbcode                 | v0.1.0-beta.8     |        |
| flarum-emoji                  | v0.1.0-beta.8     |        |
| flarum-flags                  | v0.1.0-beta.9     |        |
| flarum-likes                  | v0.1.0-beta.9     |        |
| flarum-lock                   | v0.1.0-beta.9     |        |
| flarum-markdown               | v0.1.0-beta.9     |        |
| flarum-mentions               | v0.1.0-beta.9     |        |
| flarum-statistics             | v0.1.0-beta.9     |        |
| flarum-sticky                 | v0.1.0-beta.9     |        |
| flarum-subscriptions          | v0.1.0-beta.9     |        |
| flarum-suspend                | v0.1.0-beta.9     |        |
| flarum-tags                   | v0.1.0-beta.9     |        |
| flarum-auth-facebook          | v0.1.0-beta.9     |        |
| flarum-auth-twitter           | v0.1.0-beta.9     |        |
| flarum-auth-github            | v0.1.0-beta.9     |        |
| flarum-pusher                 | v0.1.0-beta.9     |        |
| flarum-lang-english           | v0.1.0-beta.9     |        |
| kilowhat-mailing              | 0.1.1             |        |
| cagatayldzz-lang-turkish      | v0.1.0-beta.8.1   |        |
| flagrow-ads                   | 0.2.0-beta.1      |        |
| flagrow-linguist              | 0.3.1             |        |
| flagrow-sitemap               | 0.2.0             |        |
| fof-follow-tags               | 0.2.0             |        |
| fof-formatting                | 0.1.2             |        |
| fof-links                     | 0.1.1             |        |
| fof-pages                     | 0.2.4             |        |
| fof-profile-image-crop        | 0.1.1             |        |
| fof-share-social              | 0.1.1             |        |
| fof-transliterator            | 0.1.1             |        |
| fof-user-bio                  | 0.1.2             |        |
| fof-user-directory            | 0.3.1             |        |
| saleksin-auth-google          | v0.1.0-beta.8.0.2 |        |
| reflar-nightmode              | 0.2.0             |        |
| kvothe-reply-to-see           | v0.1.2            |        |
| flagrow-upload                | 0.7.1             |        |
| clarkwinkelmann-circle-groups | 0.2.1             |        |
| flagrow-byobu                 | 0.3.0-beta        |        |
| fof-auth-discord              | 0.1.1             |        |
| flagrow-analytics             | 0.8.0             |        |
| fof-split                     | 0.4.1             |        |
+-------------------------------+-------------------+--------+

screenshot: http://prntscr.com/ocmvfn

clarkwinkelmann

wwwn can you click on the "Console" tab of the browser tools ? That's where the error messages will be.

EDIT: Hi David

datitisev

wwwn I don't see any errors when visiting the page. Can you send a screenshot of the contents of the developer tools when in the Console tab ?

EDIT: Hi clark

wwwn

datitisev http://prntscr.com/ocmxuo

clarkwinkelmann

wwwn looks like those are network errors, not javascript errors.

You might be able to see exactly which resources timed out in the Network tab.

matteocontrini

That could also be a browser extension actually

luceos

Also note one extension is logging to console. We should try to pinpoint the source because this is a nuisance in production.

datitisev

luceos It's fof/user-directory lol

clarkwinkelmann

luceos datitisev fixed it https://github.com/FriendsOfFlarum/user-directory/issues/30

Sorry for introducing it in the first place 🙉

Ralkage

Adblock browser extension warnings are another prime suspect that pops up in the console constantly as well, gets me every time 👌

wwwn

Ralkage I'm just using alexa traffic rank as chrome plugin. No other add-ons.

[deleted]

Ralkage and me

wwwn

Today I updated flagrow ads to version 0.2.0 and it failed. Start new discussion button didn't work, admin menu didn't open while on main page. I've disabled the ads plug-in. Now the error I mentioned above does not exist anymore. I think this was due to the plugin!

@luceos @clarkwinkelmann @datitisev Ralkage

Edit: problem persists

matteocontrini

wwwn about Flagrow Ads, cross-posting:

If you use AdSense, make sure you removed this line from your ad slots code:

<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>

AdSense doesn't behave nicely if you execute that more than you should.