FriendsOfFlarum Gamification

SKevo

karaok thanks, that fixed my issue 😃

karaok

SKevo Glad that's fixed it for you

010101 This is annoying me that it's not behaving for you. Could you please share your php flarum info? I'd like to replicate your setup as closely as possible to see if I can get to the bottom of this for you

010101

karaok Thanks for working on this. This update didn’t resolve my issue. Voting triggers the error log in my post above.

010101

karaok

Flarum core 0.1.0-beta.14.1
PHP version: 7.4.13
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, hash, fileinfo, filter, ftp, gd, gettext, gmp, SPL, iconv, session, intl, json, mbstring, standard, mysqlnd, pcntl, mysqli, PDO, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, readline, Reflection, imap, shmop, SimpleXML, soap, sockets, sodium, exif, sysvmsg, sysvsem, tidy, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, memcached, ionCube Loader, Zend OPcache
+-------------------------------------+------------------+--------+
| Flarum Extensions                   |                  |        |
+-------------------------------------+------------------+--------+
| ID                                  | Version          | Commit |
+-------------------------------------+------------------+--------+
| flarum-approval                     | v0.1.0-beta.14   |        |
| flarum-emoji                        | v0.1.0-beta.14   |        |
| flarum-lang-english                 | v0.1.0-beta.14.1 |        |
| flarum-flags                        | v0.1.0-beta.14.1 |        |
| flarum-lock                         | v0.1.0-beta.14   |        |
| flarum-mentions                     | v0.1.0-beta.14   |        |
| flarum-statistics                   | v0.1.0-beta.14   |        |
| flarum-sticky                       | v0.1.0-beta.14   |        |
| flarum-subscriptions                | v0.1.0-beta.14   |        |
| flarum-suspend                      | v0.1.0-beta.14   |        |
| flarum-tags                         | v0.1.0-beta.14   |        |
| fof-linguist                        | 0.4.4            |        |
| clarkwinkelmann-first-post-approval | 0.1.2            |        |
| fof-user-bio                        | 0.3.1            |        |
| fof-upload                          | 0.11             |        |
| clarkwinkelmann-bookmarks           | 0.1.1            |        |
| fof-drafts                          | 0.2.0            |        |
| fof-ignore-users                    | 0.2.0            |        |
| fof-links                           | 0.4.1            |        |
| fof-merge-discussions               | 0.4.0            |        |
| fof-nightmode                       | 0.6.0            |        |
| fof-profile-image-crop              | 0.2.0            |        |
| fof-share-social                    | 0.2.0            |        |
| fof-spamblock                       | 0.3.0            |        |
| fof-split                           | 0.5.0            |        |
| fof-stopforumspam                   | 0.3.1            |        |
| zerosonesfun-hashtags               | 3.7              |        |
| zerosonesfun-elint                  | 1.8              |        |
| askvortsov-pwa                      | v1.1.2           |        |
| fof-terms                           | 0.5.0            |        |
| flarum-pusher                       | v0.1.0-beta.14.1 |        |
| fof-pages                           | 0.5.0            |        |
| v17development-seo                  | 1.4              |        |
| fof-sitemap                         | 0.5.4            |        |
| zerosonesfun-chords                 | 1.2              |        |
| fof-oauth                           | 0.1.0            |        |
| fof-gamification                    | 0.3.2            |        |
+-------------------------------------+------------------+--------+

karaok

010101 thanks for sharing.

I've replicated your install as closely as I can, and am able to vote without error.

That said, I see you have pusher enabled, could you try disabling that for a moment and seeing if that helps at all? I'm not currently in a position to setup pusher locally...

010101

karaok That’s it. It’s Pusher. And I really don’t care about live updates and so if this can’t be fixed for a while I’m cool with keeping Pusher disabled.

Yay, finally for the first time in a year or more I can use this extension! Thank you!! 🙏

To think, I just had to disable Pusher... I disabled other extensions trying to fix this but I never disabled Pusher... I just didn’t think Pusher could be the issue. 😳

karaok

010101 Great 🙂 I'm not that familiar with how pusher works, so I'd ping @Kyrne or @datitisev for a potential fix.. Might also be worth opening an issue on the repo with the log output if/when you have a moment

EvilExecutor

010101 looks like pusher & gamification has a hard time together...

POST http://localhost/flarum/public/api/posts/23

BadMethodCallException: Call to undefined method Flarum\Post\CommentPost::votes() in P:\xampp\htdocs\flarum\vendor\illuminate\support\Traits\ForwardsCalls.php:50
Stack trace:
#0 P:\xampp\htdocs\flarum\vendor\illuminate\support\Traits\ForwardsCalls.php(36): Illuminate\Database\Eloquent\Model::throwBadMethodCallException('votes')
#1 P:\xampp\htdocs\flarum\vendor\illuminate\database\Eloquent\Model.php(1622): Illuminate\Database\Eloquent\Model->forwardCallTo(Object(Illuminate\Database\Eloquent\Builder), 'votes', Array)
#2 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Database\AbstractModel.php(205): Illuminate\Database\Eloquent\Model->__call('votes', Array)
#3 P:\xampp\htdocs\flarum\vendor\fof\gamification\src\Listeners\SaveVotesToDatabase.php(204): Flarum\Database\AbstractModel->__call('votes', Array)
#4 P:\xampp\htdocs\flarum\vendor\fof\gamification\src\Listeners\SaveVotesToDatabase.php(133): FoF\Gamification\Listeners\SaveVotesToDatabase->pushNewVote(Object(FoF\Gamification\Vote))
#5 P:\xampp\htdocs\flarum\vendor\fof\gamification\src\Listeners\SaveVotesToDatabase.php(95): FoF\Gamification\Listeners\SaveVotesToDatabase->vote(Object(Flarum\Post\CommentPost), false, true, Object(Flarum\User\User), Object(Flarum\User\User))
#6 P:\xampp\htdocs\flarum\vendor\illuminate\events\Dispatcher.php(389): FoF\Gamification\Listeners\SaveVotesToDatabase->handle(Object(Flarum\Post\Event\Saving))
#7 P:\xampp\htdocs\flarum\vendor\illuminate\events\Dispatcher.php(218): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}('Flarum\\Post\\Eve...', Array)
#8 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Post\Command\EditPostHandler.php(79): Illuminate\Events\Dispatcher->dispatch('Flarum\\Post\\Eve...')
#9 P:\xampp\htdocs\flarum\vendor\illuminate\bus\Dispatcher.php(90): Flarum\Post\Command\EditPostHandler->handle(Object(Flarum\Post\Command\EditPost))
#10 P:\xampp\htdocs\flarum\vendor\illuminate\pipeline\Pipeline.php(130): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Flarum\Post\Command\EditPost))
#11 P:\xampp\htdocs\flarum\vendor\illuminate\pipeline\Pipeline.php(105): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Flarum\Post\Command\EditPost))
#12 P:\xampp\htdocs\flarum\vendor\illuminate\bus\Dispatcher.php(98): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#13 P:\xampp\htdocs\flarum\vendor\illuminate\bus\Dispatcher.php(76): Illuminate\Bus\Dispatcher->dispatchNow(Object(Flarum\Post\Command\EditPost))
#14 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Api\Controller\UpdatePostController.php(57): Illuminate\Bus\Dispatcher->dispatch(Object(Flarum\Post\Command\EditPost))
#15 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Api\Controller\AbstractSerializeController.php(96): Flarum\Api\Controller\UpdatePostController->data(Object(Laminas\Diactoros\ServerRequest), Object(Tobscure\JsonApi\Document))
#16 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\RouteHandlerFactory.php(38): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Laminas\Diactoros\ServerRequest))
#17 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\DispatchRoute.php(65): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#18 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\DispatchRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#19 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#20 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#21 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\CheckCsrfToken.php(45): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#22 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#23 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\AuthenticateWithHeader.php(55): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#25 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#26 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#27 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\RememberFromCookie.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#28 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#29 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#30 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#31 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Api\Middleware\FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#32 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#33 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#34 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#35 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Middleware\HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#36 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#37 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#38 P:\xampp\htdocs\flarum\vendor\middlewares\request-handler\src\RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#39 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#40 P:\xampp\htdocs\flarum\vendor\middlewares\base-path-router\src\BasePathRouter.php(97): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#41 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#42 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Middleware\OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#43 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#44 P:\xampp\htdocs\flarum\vendor\middlewares\base-path\src\BasePath.php(53): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#45 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#46 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#47 P:\xampp\htdocs\flarum\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#48 P:\xampp\htdocs\flarum\vendor\laminas\laminas-httphandlerrunner\src\RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#49 P:\xampp\htdocs\flarum\vendor\flarum\core\src\Http\Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#50 P:\xampp\htdocs\flarum\public\index.php(26): Flarum\Http\Server->listen()
#51 {main}

When pusher is disabled everything works fine.

Pika

EvilExecutor

Note: This extension is meant as a replacement for the Flarum Likes extension. Therefore, they are not compatible and it's recommended to disable the Likes extension.

EvilExecutor

Pika Yep I know,.. I've already disabled it. Pusher is the thing causing issues.

010101

Pika It’s not the Likes extension. It really is Pusher. I confirmed that yesterday.

Pika

010101 EvilExecutor sorry, my bad. i did not use pusher...

010101

New small bug for me. Has anyone tested viewing voters on a live server? I have the view voters permission set to members. But, whether I use a regular member account or my admin account, clicking view voters brings up a blank modal.

EvilExecutor

010101 Yep same here 😅

JoshuaPack

010101 Same, also a bug on one profile page where it won't load the profile. I have disabled the extension for now.

010101

@karaok just in case you aren’t following this thread... it sounds like you’re updating a ton of extensions so obviously no rush. Just want to be sure a dev sees that this still has a couple pretty big bugs.

karaok

010101 I pushed some fixes for this a few minutes ago 😉 @EvilExecutor is just doing some QA on it, then 🤞 it can be released

https://github.com/FriendsOfFlarum/gamification

karaok

0.3.3

Fix incompatibility with fof/filter auto-merge when auto-upvote is enabled
Fix 'View Voters' issue where no users were listed
Fix links to user profile from rankings page
Don't show ranking page link to guests, remove everyone permission (guests would previously simply be redirected to /)
Fix profile page issue
Add meta ready for beta.15 👀

Updating

composer require fof/gamification:^0.3.3
php flarum cache:clear

MartinJD

karaok great work. 😊

JoshuaPack

karaok Great work!!! Voters works great!

I am still getting an issue on one profile with the extension enabled. The issue is, I am not 100% sure what the issue is. I am getting this in the javascript console:

TypeError: Cannot read property 'key' of undefined

My guess is some data missing within the database for a post causing it to error out on the profile page.

Is there a way to go into dev mode, so I can see actual javascript issue?

i see it is coming from the render.js file when running function updateNodes

    mount-redraw.js:15 TypeError: Cannot read property 'key' of undefined
    at h (render.js:314)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)```

JoshuaPack

JoshuaPack OK, so, creating a new post seems to have solved the issue...... idk what happened. Thanks for all your hard work!!!

EDIT: after another post, it seems the error has came back. I think when I edit a post.

EvilExecutor

Pika JoshuaPack I didn't notice anything like this, tested once again but nothing 😕. Any idea how I can reproduce this?

« Previous Page Next Page »