FriendsOfFlarum Gamification

JoshuaPack

010101 Same, also a bug on one profile page where it won't load the profile. I have disabled the extension for now.

010101

@karaok just in case you aren’t following this thread... it sounds like you’re updating a ton of extensions so obviously no rush. Just want to be sure a dev sees that this still has a couple pretty big bugs.

karaok

010101 I pushed some fixes for this a few minutes ago 😉 @EvilExecutor is just doing some QA on it, then 🤞 it can be released

https://github.com/FriendsOfFlarum/gamification

karaok

0.3.3

Fix incompatibility with fof/filter auto-merge when auto-upvote is enabled
Fix 'View Voters' issue where no users were listed
Fix links to user profile from rankings page
Don't show ranking page link to guests, remove everyone permission (guests would previously simply be redirected to /)
Fix profile page issue
Add meta ready for beta.15 👀

Updating

composer require fof/gamification:^0.3.3
php flarum cache:clear

MartinJD

karaok great work. 😊

JoshuaPack

karaok Great work!!! Voters works great!

I am still getting an issue on one profile with the extension enabled. The issue is, I am not 100% sure what the issue is. I am getting this in the javascript console:

TypeError: Cannot read property 'key' of undefined

My guess is some data missing within the database for a post causing it to error out on the profile page.

Is there a way to go into dev mode, so I can see actual javascript issue?

i see it is coming from the render.js file when running function updateNodes

    mount-redraw.js:15 TypeError: Cannot read property 'key' of undefined
    at h (render.js:314)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)```

JoshuaPack

JoshuaPack OK, so, creating a new post seems to have solved the issue...... idk what happened. Thanks for all your hard work!!!

EDIT: after another post, it seems the error has came back. I think when I edit a post.

EvilExecutor

Pika JoshuaPack I didn't notice anything like this, tested once again but nothing 😕. Any idea how I can reproduce this?

Pika

same to me, visit xxx.com/u/profile and this js error will happen.

mount-redraw.js:15 TypeError: Cannot read property 'key' of undefined
    at h (render.js:314)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
a @ mount-redraw.js:15
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
n.show @ UserPage.js:78
n.show @ PostsUserPage.js:95
(anonymous) @ UserPage.js:100
n.loadUser @ UserPage.js:97
n.oninit @ PostsUserPage.js:42
a @ render.js:30
M @ render.js:917
(anonymous) @ render.js:153
(anonymous) @ render.js:160
l @ render.js:66
u @ render.js:50
(anonymous) @ render.js:103
l @ render.js:62
(anonymous) @ render.js:487
f @ render.js:419
h @ render.js:302
(anonymous) @ render.js:964
a @ mount-redraw.js:14
v @ router.js:114
Promise.then (async)
t @ router.js:126
S @ router.js:95
a @ render.js:30
(anonymous) @ render.js:971
mount @ mount-redraw.js:45
y @ router.js:160
e.mount @ Application.js:196
n.mount @ ForumApplication.js:121
e.boot @ Application.js:176
(anonymous) @ Pika:100
mount-redraw.js:15 TypeError: Cannot read property 'key' of undefined
    at h (render.js:314)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
a @ mount-redraw.js:15
(anonymous) @ mount-redraw.js:25
requestAnimationFrame (async)
c @ mount-redraw.js:23
t.onload @ User.js:91
load (async)
calculateAvatarColor @ User.js:88
(anonymous) @ User.js:43
(anonymous) @ computed.js:32
n.view @ UserCard.js:28
t.<computed> @ extend.js:25
a @ render.js:30
(anonymous) @ render.js:155
(anonymous) @ render.js:160
l @ render.js:66
u @ render.js:50
(anonymous) @ render.js:134
l @ render.js:63
(anonymous) @ render.js:162
l @ render.js:66
u @ render.js:50
(anonymous) @ render.js:103
l @ render.js:62
(anonymous) @ render.js:487
f @ render.js:419
h @ render.js:302
(anonymous) @ render.js:964
a @ mount-redraw.js:14
v @ router.js:114
Promise.then (async)
t @ router.js:126
S @ router.js:95
a @ render.js:30
(anonymous) @ render.js:971
mount @ mount-redraw.js:45
y @ router.js:160
e.mount @ Application.js:196
n.mount @ ForumApplication.js:121
e.boot @ Application.js:176
(anonymous) @ Pika:100
mount-redraw.js:15 TypeError: Cannot read property 'key' of undefined
    at h (render.js:314)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)
    at render.js:477
    at f (render.js:416)
    at h (render.js:302)

JoshuaPack

EvilExecutor I really wish I could reproduce. I tried creating another user. seems to only happen to the first admin user, from a previous version of gamification at least for me.

Is there a way for me to go into a developer mode. The key error I saw was from Javascript trying to do console.error, but console was set to undefined, so, it wasn't able to write to the console. That's as far as I got, and I haven't been able to get it back to see the error exactly again. I will try again as soon as I have time.

JoshuaPack

EvilExecutor
Looking a bit into it right now, i apparently had a little time.

Looks to be the render.js file and with the updateNodes function function updateNodes(parent, old, vnodes, hooks, nextSibling, ns):
Specifically on the oe.key part if (oe.key !== ve.key) break

				// bottom-up
				while (oldEnd >= oldStart && end >= start) {
					oe = old[oldEnd]
					ve = vnodes[end]
					if (oe.key !== ve.key) break
					if (oe !== ve) updateNode(parent, oe, ve, hooks, nextSibling, ns)
					if (ve.dom != null) nextSibling = ve.dom
					oldEnd--, end--
				}

datitisev

JoshuaPack This code is from mithril. The error stack trace won't really help you figure out the source of the error itself. I can only assume that some null/undefined object is being passed to mithril somehow. This stuff is hard to debug.

JoshuaPack

datitisev You are right. So, you think if I compare data with and without the extension i may get a better idea?

datitisev

JoshuaPack This error could originate from many different places, specially if the extensions weren't properly updated & in a rare scenario a undefined value is passed. If you're able to narrow down what causes the issue outside the code, i.e. what you do on the forum that causes it, and make it error, that'd be helpful.

Wow your last message just popped up, basically providing what I was asking for. Could you create a fresh forum with gamification and try to create the same environment with the ranks to see if the error pops up there? Thanks!

JoshuaPack

@datitisev @EvilExecutor I may have figured it out. On the page with the error it is sending 2 ranks over, because my account has enough posts for the second rank, which is causing the problem I am guessing. I am the only user currently on rank 2. This is purely a guess, but from comparing the data, the only thing I can figure out that could be messing it up.

JoshuaPack

datitisev Yeah, when i get back from running an errand, I will see if I can setup a local environment with a new forum. in the mean time, I will try lowering the upping the second rank to see if it makes more issues or fixes issues.

JoshuaPack

datitisev Putting myself back to rank 1 by upping the limit for rank 2 then upvoting or down voting a post fixes my profile page.

Also, lowering the rank to a number that puts other people within rank 2, errors out their pages too. So looks like going to rank 2, it errors out the profile page.

EDIT: Also, I noticed if I select to show all Ranks, it will also fix the issue.

this option How many rank badges should be shown? if set to the same number of ranks available, will fix the issue. if a user has more ranks then that number the profile page will error out.

EDIT2: so, an acceptable solution for the time being 😁

Amarok

JoshuaPack this option How many rank badges should be shown? if set to the same number of ranks available, will fix the issue. if a user has more ranks then that number the profile page will error out.

same for me 😅

Pika

JoshuaPack EDIT: Also, I noticed if I select to show all Ranks, it will also fix the issue.

this option How many rank badges should be shown? if set to the same number of ranks available, will fix the issue. if a user has more ranks then that number the profile page will error out.

EDIT2: so, an acceptable solution for the time being 😁

@karaok @Kyrne @datitisev are there anyway i can solve this problem? sorry to bother you again.

IanM

0.4.0

Flarum beta 15 support

JoshuaPack

Pika you can set this option How many rank badges should be shown? to the number ranks you have. And the profile page will work again.

« Previous Page Next Page »