Just a quick heads up, I accidentally removed the "ReCached: 1" header from the current version (since 2.0.8)

The "ReCached: 0" header is still in place. So if you see no ReCached header it's working, if you see the 0 header, it's not working.

I'll fix this soon.

a month later

Kyrne Add support for @askvortsov's PWA Extension

As I've reported a few months ago, there's still an incompatibility or slight issue together with the PWA extension, causing thousands of PHP NOTICEs in days being reported to Sentry and logged on disk.

PWA is using and recache triggering notices on following paths:

  • /sw
  • /webmanifest
  • /offline

Edit: Apologies, (for some reasons( I completely forgot to add the actual PHP NOTICE for your convenience:

ErrorException: Undefined offset: 0
#43 /vendor/reflar/recache/src/Replacers/Data.php(66): FoF\Sentry\SentryServiceProvider::handleError
#42 /vendor/reflar/recache/src/Replacers/Data.php(66): Reflar\ReCache\Replacers\Data::replaceInCachedResponse
#41 /vendor/reflar/recache/src/Middlewares/CacheResponse.php(65): Reflar\ReCache\Middlewares\CacheResponse::process
    20 days later

    • [deleted]

    • Post #250

    @Kyrne does recache support the most recent version of fof/nightmode ? Periodically, my session flips between night and day mode but the problem isn't evident with recache disabled.

      22 days later

      While I won't be able to update this extension for just a bit because of school. It should still work on beta 14 with one caveat. Before updating to beta 14 turn off Lazy image Loading. It should then work just fine.

        Kyrne thanks for the heads up. I will probably be waiting a bit to update than.

        Hopefully it won't be too long!

          a month later

          Kyrne

          If I am installing this extension fresh onto Beta 14, will it break, or will I be able to disable lazy image loading somehow?

            2.1.0

            • Beta 14
            • Bug fixes with data replacers (more resilient)
            • Re-add "ReCached" headers.
            12 days later

            • [deleted]

            • Post #257

            Hey @Kyrne I noticed an issue with Beta 14.1, plus FoF/Pages. It seems that sometimes, the pages rendered by this extension will not display fully - only the spinning logo appear. If you disable ReCache, it works fine.

            In my CSS, I'm using

            .Pages-container {
    white-space: inherit;
}

            I'm using this to strip the amount of white space as it looks really odd. What's even more odd is that if I remove this CSS line, it then works ! I have no idea why, but wondered if you could take a look ?

            Thanks

              [deleted]

              2.1.1

              • Fix pages not displaying with or without custom CSS

              Run php flarum cache:clear after updating.

                  • [deleted]

                  • Post #261
                  • Edited

                  Kyrne you rock. Thanks

                  However, this doesn't fix the issue for me. It's still there.

                      • [deleted]

                      • Post #263

                      Kyrne validated as working. Thanks again

                        Umbe this is a paid extension and requires an active subscription on extiverse

                          17 days later
                          19 days later

                          Kind of random and may or may not be related, but since you have lazy loading for images:

                          Any way to add lazy loading to embedded YouTube videos? I have noticed that pages with more then one YouTube video embedded get dinged on loading time in google web master console.