- Edited
[deleted] did you check if there are errors shown in the Dev Tools console?
[deleted] did you check if there are errors shown in the Dev Tools console?
matteocontrini Yes, there is nothing. I've also spoken to @Kyrne over Discord.
Kyrne you rock. Thanks
However, this doesn't fix the issue for me. It's still there.
Kyrne validated as working. Thanks again
Kind of random and may or may not be related, but since you have lazy loading for images:
Any way to add lazy loading to embedded YouTube videos? I have noticed that pages with more then one YouTube video embedded get dinged on loading time in google web master console.
MikeJones Yup!
Clear the caches after updating.
Quick reminder:
php flarum cache:clear
will clear both the Flarum cache and ReCache (this is the one you should use most of the time) whilephp flarum recache:clear
will only clear the ReCache.
Kyrne Upgrade went smooth an easy! New version now running on Seek Adventure.
Excited to see how this affects the site in the long run for SEO. I think it will help out a bunch because I was seeing some slow loading speeds on discussions with more than one YouTube Video. Thanks again for the amazing extension!
Love how this extension is building on features, i can't wait to use (waiting for my community grow first)
Wondering @Kyrne if you could add this feature "delaying JS" in the future?
similar to https://wordpress.org/plugins/flying-scripts/
SallyMelek unlikely, Flarum's front end is built entirely on JavaScript, without it, it won’t run.
Kyrne ohhh i see, if thats the case however about even delaying external js ?
SallyMelek External js would only really be introduced by extensions, and is generally the responsibility of each extension to pull it in only when needed.
askvortsov just thinking outside of the box on this one slightly. Is it possible to use extend.php for example to load assets locally rather then call them from external sources ?