FriendsOfFlarum Subscribed

Leanna

[2019-08-02 04:08:16] production.ERROR: Swift_TransportException: Expected response code 354 but got code "503", with message "503 Error: need RCPT command
" in /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php:457
Stack trace:
#0 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(341): Swift_Transport_AbstractSmtpTransport->assertResponseCode('503 Error: need...', Array)
#1 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/EsmtpTransport.php(305): Swift_Transport_AbstractSmtpTransport->executeCommand('DATA\r\n', Array, Array, false, NULL)
#2 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(390): Swift_Transport_EsmtpTransport->executeCommand('DATA\r\n', Array, Array)
#3 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(497): Swift_Transport_AbstractSmtpTransport->doDataCommand(Array)
#4 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(516): Swift_Transport_AbstractSmtpTransport->doMailTransaction(Object(Swift_Message), 'admin@sescse.co...', Array, Array)
#5 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php(206): Swift_Transport_AbstractSmtpTransport->sendTo(Object(Swift_Message), 'admin@sescse.co...', Array, Array)
#6 /www/wwwroot/vendor/swiftmailer/swiftmailer/lib/classes/Swift/Mailer.php(71): Swift_Transport_AbstractSmtpTransport->send(Object(Swift_Message), Array)
#7 /www/wwwroot/vendor/illuminate/mail/Mailer.php(483): Swift_Mailer->send(Object(Swift_Message), Array)
#8 /www/wwwroot/vendor/illuminate/mail/Mailer.php(259): Illuminate\Mail\Mailer->sendSwiftMessage(Object(Swift_Message))
#9 /www/wwwroot/vendor/flarum/core/src/Notification/NotificationMailer.php(45): Illuminate\Mail\Mailer->send(NULL, Array, Object(Closure))
#10 /www/wwwroot/vendor/flarum/core/src/Notification/NotificationSyncer.php(202): Flarum\Notification\NotificationMailer->send(Object(FoF\Subscribed\Blueprints\DiscussionCreatedBlueprint), Object(Flarum\User\User))
#11 /www/wwwroot/vendor/flarum/core/src/Notification/NotificationSyncer.php(188): Flarum\Notification\NotificationSyncer->mailNotifications(Object(FoF\Subscribed\Blueprints\DiscussionCreatedBlueprint), Array)
#12 /www/wwwroot/vendor/flarum/core/src/Notification/NotificationSyncer.php(120): Flarum\Notification\NotificationSyncer->sendNotifications(Object(FoF\Subscribed\Blueprints\DiscussionCreatedBlueprint), Array)
#13 /www/wwwroot/vendor/fof/subscribed/src/Listeners/DiscussionCreated.php(74): Flarum\Notification\NotificationSyncer->sync(Object(FoF\Subscribed\Blueprints\DiscussionCreatedBlueprint), Array)
#14 /www/wwwroot/vendor/illuminate/events/Dispatcher.php(360): FoF\Subscribed\Listeners\DiscussionCreated->whenDiscussionWasStarted(Object(Flarum\Discussion\Event\Started))
#15 /www/wwwroot/vendor/illuminate/events/Dispatcher.php(209): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}('Flarum\\Discussi...', Array)
#16 /www/wwwroot/vendor/flarum/core/src/Foundation/DispatchEventsTrait.php(35): Illuminate\Events\Dispatcher->dispatch('Flarum\\Discussi...')
#17 /www/wwwroot/vendor/flarum/core/src/Discussion/Command/StartDiscussionHandler.php(100): Flarum\Discussion\Command\StartDiscussionHandler->dispatchEventsFor(Object(Flarum\Discussion\Discussion), Object(Flarum\User\User))
#18 /www/wwwroot/vendor/illuminate/bus/Dispatcher.php(90): Flarum\Discussion\Command\StartDiscussionHandler->handle(Object(Flarum\Discussion\Command\StartDiscussion))
#19 /www/wwwroot/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Flarum\Discussion\Command\StartDiscussion))
#20 /www/wwwroot/vendor/illuminate/pipeline/Pipeline.php(104): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Flarum\Discussion\Command\StartDiscussion))
#21 /www/wwwroot/vendor/illuminate/bus/Dispatcher.php(98): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#22 /www/wwwroot/vendor/illuminate/bus/Dispatcher.php(76): Illuminate\Bus\Dispatcher->dispatchNow(Object(Flarum\Discussion\Command\StartDiscussion))
#23 /www/wwwroot/vendor/flarum/core/src/Api/Controller/CreateDiscussionController.php(73): Illuminate\Bus\Dispatcher->dispatch(Object(Flarum\Discussion\Command\StartDiscussion))
#24 /www/wwwroot/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(98): Flarum\Api\Controller\CreateDiscussionController->data(Object(Zend\Diactoros\ServerRequest), Object(Tobscure\JsonApi\Document))
#25 /www/wwwroot/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(24): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Zend\Diactoros\ServerRequest))
#26 /www/wwwroot/vendor/flarum/core/src/Http/RouteHandlerFactory.php(40): Flarum\Api\Controller\AbstractCreateController->handle(Object(Zend\Diactoros\ServerRequest))
#27 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(67): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Zend\Diactoros\ServerRequest), Array)
#28 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\DispatchRoute->process(Object(Zend\Diactoros\ServerRequest), Object(Closure))
#29 /www/wwwroot/vendor/reflar/recache/src/Middlewares/OptimizeImages.php(44): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#30 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Reflar\ReCache\Middlewares\OptimizeImages->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#31 /www/wwwroot/vendor/reflar/recache/src/Middlewares/CacheResponse.php(87): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#32 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Reflar\ReCache\Middlewares\CacheResponse->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#33 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#34 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\SetLocale->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#35 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(33): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#36 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#37 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(56): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#38 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#39 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(34): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#40 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#41 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#42 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\RememberFromCookie->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#43 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/StartSession.php(62): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#44 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\StartSession->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#45 /www/wwwroot/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(31): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#46 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#47 /www/wwwroot/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(29): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#48 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Http\Middleware\ParseJsonBody->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#49 /www/wwwroot/vendor/flarum/core/src/Api/Middleware/HandleErrors.php(42): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#50 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Flarum\Api\Middleware\HandleErrors->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#51 /www/wwwroot/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(83): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#52 /www/wwwroot/vendor/middlewares/request-handler/src/RequestHandler.php(84): Zend\Stratigility\MiddlewarePipe->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#53 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\RequestHandler->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#54 /www/wwwroot/vendor/middlewares/base-path-router/src/BasePathRouter.php(97): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#55 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\BasePathRouter->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#56 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Middleware/OriginalMessages.php(41): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#57 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Zend\Stratigility\Middleware\OriginalMessages->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#58 /www/wwwroot/vendor/middlewares/base-path/src/BasePath.php(53): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#59 /www/wwwroot/vendor/zendframework/zend-stratigility/src/Next.php(60): Middlewares\BasePath->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\Next))
#60 /www/wwwroot/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(83): Zend\Stratigility\Next->handle(Object(Zend\Diactoros\ServerRequest))
#61 /www/wwwroot/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(72): Zend\Stratigility\MiddlewarePipe->process(Object(Zend\Diactoros\ServerRequest), Object(Zend\Stratigility\EmptyPipelineHandler))
#62 /www/wwwroot/vendor/zendframework/zend-httphandlerrunner/src/RequestHandlerRunner.php(95): Zend\Stratigility\MiddlewarePipe->handle(Object(Zend\Diactoros\ServerRequest))
#63 /www/wwwroot/vendor/flarum/core/src/Http/Server.php(46): Zend\HttpHandlerRunner\RequestHandlerRunner->run()
#64 /www/wwwroot/public/index.php(22): Flarum\Http\Server->listen()
#65 {main}

datitisev

Leanna That looks like a mailing error... not sure what it means though.

Leanna

datitisev Enable the "subscribed" extension, post a discussion prompt error, I disable this extension, no error message, the error log does not know what it means.

datitisev

Leanna It is still an issue with mailing error, as it is unable to send an email notifying subscribed users about the discussion.

katos

Leanna The errors are telling you that your SMTP (outgoing mail) connection was not properly authenticated by your email server.

The two most common causes of this error are:

Your host requires checking on all outbound email. (Checking email first is one way your email provider manages the security of your email account.)
Your installation of Flarum contains erroneous mail details.

Are you able to receive emails on signing signing up to your forum?

Leanna

katos I can sign my mail normally.

Leanna

katos

I can also receive emails normally using this extension ("Post Notification"),
registered members can receive emails normally.

EricEndo

Hi, sorry for bugging you, but can someone please describe exactly to which events are these subscriptions? Thanks in advance!

Ralkage

EricEndo my apologies, I was to provide some screenshots today but I became VERY busy and didn't have time.

The two event notification types available are for when a new user joins and when a user creates a new discussion.

katos

Leanna can you please provide steps to reproduce, as well as more details on your hosting environment. I will have to attempt to replicate this myself and see if I get the same issue.
/ CC @Ralkage

Ralkage

Hi @EricEndo and to those who are wondering what this extension actually does, I added some screenshots to my first post just to clear any concerns and mystery 😃

Also, feel free to suggest any other events you think would be good candidates for this extension!

Pollux

The localisation file of this extension mentions two options I can't find anywhere:

defaults_label: Set "{setting}" enabled by default
forced_label: Force enable "{setting}" for everyone

Is this a planned feature or just hidden well enough?

Ralkage

Pollux possibly a planned feature 😉 this is continued work and I mainly just worked on completing the implementation of the initial features/events as well as the update to Beta 9.

Leanna you seem to be the only one having this issue and @katos previously replied to it. Unless someone else reports something similar, even I myself cannot reproduce your issue.

Leanna

Ralkage Is the problem I mentioned solved?

ctx

Greetings. Well done on this extension! I'm seeing a little issue with the subject line content. Rather than some generic subject, I'm seeing what appears to be metadata in the subject line.

Is this perhaps by design? Seeing this on beta.9 and beta.10 - thoughts?

Example ( --- = redacted by me):

Date: Sun, 22 Sep 2019 16:43:28 +0000
Subject: {"username":"Mike","email":"----@---.com","password":"$2y$10$TGOvI9cxgsXB---","joined_at":"2019-09-22
16:43:28","id":12}
From: FLUM --- --- <noreply@---.---.com>
To: arborist <---@---.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Environment:

Flarum 0.1.0-beta.10
PHP 7.2.21
MySQL 10.4.7-MariaDB

Flarum core 0.1.0-beta.10
PHP version: 7.2.21
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, gettext, SPL, iconv, intl, json, mbstring, session, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, mysqli, SimpleXML, soap, sockets, sodium, exif, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, apcu
+----------------------+----------------+--------+
| Flarum Extensions | | |
+----------------------+----------------+--------+
| ID | Version | Commit |
+----------------------+----------------+--------+
| flarum-lang-english | v0.1.0-beta.10 | |
| flarum-approval | v0.1.0-beta.8 | |
| flarum-bbcode | v0.1.0-beta.8 | |
| flarum-emoji | v0.1.0-beta.10 | |
| flagrow-sitemap | 0.2.0 | |
| flagrow-terms | 0.3.1 | |
| flarum-flags | v0.1.0-beta.9 | |
| fof-ban-ips | 0.1.0 | |
| fof-ignore-users | 0.1.4 | |
| fof-subscribed | 0.1.0 | |
| fof-user-directory | 0.3.3 | |
| flarum-likes | v0.1.0-beta.9 | |
| flarum-lock | v0.1.0-beta.9 | |
| flarum-markdown | v0.1.0-beta.10 | |
| flarum-mentions | v0.1.0-beta.10 | |
| v17development-seo | 1.0.2 | |
| flarum-statistics | v0.1.0-beta.9 | |
| flarum-sticky | v0.1.0-beta.9 | |
| flarum-subscriptions | v0.1.0-beta.9 | |
| flarum-suspend | v0.1.0-beta.9 | |
| flarum-tags | v0.1.0-beta.10 | |
| flagrow-upload | 0.7.1 | |
+----------------------+----------------+--------+

datitisev

ctx That's not good 🙈. Looks like this code is the issue, there was never an actual subject set for the email it seems:

    /**
     * Get the subject line for a notification email.
     *
     * @return string
     */
    public function getEmailSubject()
    {
        return $this->user;
    }

Ralkage

datitisev whoops 🙈

0.1.1

This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject's meta info which was reported here https://discuss.flarum.org/d/20917-friendsofflarum-subscribed/24.

For those of you that have this extension installed, it is advised that you update it ASAP.

Updating

composer require fof/subscribed

ctx

Ralkage 0.1.1
This security related bug fix should stop user information (such as passwords and email addresses) from being added to the email subject

Thank you! I have re-tested and can confirm this issue has been resolved with v0.1.1 on Flarum v0.1.0-beta.10

ctx

Greetings. On your next development pass, please consider updating the subject line for new user subscriptions to include the forum name. This may help those who maintain multiple-forums quickly know where the new user request came from. Understood, the forum name is included in the body, but having it in the subject too would be icing on the cake.

Currently: [New User] CrashTestDummy
Proposed: [Oakhurst at Kingwood] New User CrashTestDummy

Thank you for everything that you do.

Respectfully submitted, Eric

Ralkage

ctx does the following subject line work? 🙂

Proposed: [Forum Name] New User Registration

This should keep things generic (something I think WordPress does?) and simple, leaving the body of the email to include additional useful information and links.

We can also try for:

[Forum Name] New User - ExampleUsername
[Forum Name] New User Registration - ExampleUsername
[Forum Name] New User Just Registered - ExampleUsername

Others that use this extension as well, please let me hear your thoughts! I am considering adding more translations in the future, especially for the email templates so that you can freely edit with fof/linguist (if at all possible 😉).

« Previous Page Next Page »