Hashtags

010101

[deleted] I’d have to take a look at your site and see if I see anything that could be causing it. Now that it is working for both me and @Aleram it’s going to be even harder to troubleshoot. If I could visit your forum I could view the page source and at least see if the right JavaScript is loading or not.

010101

Version 3.3 is here! 🥳

Fixed a bug (sometimes a single lone hashtag was not converting)

... and that is all that is new with 3.3. But, 3.0 brought:

Compatible with all languages
Ignores punctuation (it did before but, making it compatible with all languages meant re-doing this part as well as the following feature)
Ignores hashtag if something precedes it (which helps to avoid html and markup conflicts)

To update you may try the regular update command (see first post of this thread), but sometimes depending on caches and other factors that does not work for me personally. You may instead deactivate and remove the old version completely using composer remove zerosonesfun/hashtags and then reinstall with composer require zerosonesfun/hashtags. Then of course reactivate the extension. 🙂

If you have issues with this extension I can try to help but at a minimum I need a link to a post at your forum which has hashtags. This allows me to view your source code where I am able to confirm if the latest version got installed or not. Plus, I might see something else which could help to solve your issue. Thank you!

[deleted]

@010101 version 3.3 solved problem! 😁
Hope to see more extensions from you!

P.S. Noticed that hashtags are not working with words in lists

010101

[deleted] Good to hear! Not working in lists is a “feature.”

The code purposely will not create a linked hashtag if it is up against markdown or HTML. I don’t recall 100%, but I think I added this feature because long ago this extension was conflicting with another one. And it was because it was conflicting with some dynamically added HTML that the other extension was adding.

In short, you can only have hashtags either alone on their own line, or within a normal sentence. 🙂

[deleted]

010101 In short, you can only have hashtags either alone on their own line, or within a normal sentence. 🙂

All clear. Thanks, man!

djalmasi

The hashtags not working with FoF Formating. Because i got this message

Hozzászólás keresése ugyan ilyen jelöléssel c#c0392b; color: white;\' class=\'uncited\'>
'+app.translator.trans('fof-secure-https.forum.removed')+' | '+app.translator.trans('fof-secure-https.forum.show')+'

');$(this).hide();" onload="$(this).next().empty();" class="securehttps-replaced" src="https://djalmasi.hu/privat/fulltimehosting/01.png" title="" alt=""> Loading Image

010101

djalmasi More information is needed. This does not show how/why this would be the hashtags extension. I see the fof secure https extension may be having trouble loading an image?

clarkwinkelmann

djalmasi 010101 I suspect this is an issue with Secure HTTPS, which inserts HTML with a HEX color (background-color: #c0392b;) as well as some URL-encoded quotes (&#92) that might be interpreted as hashtags by this extension.

In fact, I'm pretty sure the way this extension is implemented will break if there's a # character in any HTML attribute or script tag (with the required spacing around it), since the code performs a replace on the raw HTML instead of the text parts.

djalmasi

010101
If i turning on the Hashtags, somehow the code complicated. Certain words preceded by a # sign. And so the automatic code converter gets stuck and can't perform automatic image loading.
I attached a video. (Sorry for the background noise, I forgot to turn off the microphone.)

010101

djalmasi I’ve been busy, just taking a look at your video. It’s too blurry. I cannot tell what you’re trying to do. I assume it is an image URL that happens to have a “#” in it? Is that what’s happening? So you are posting something like:

https://www.website.com/#image.png

djalmasi

clarkwinkelmann Thank you. Then I'll try to get help there.

clarkwinkelmann

djalmasi the problem is definitely this extension, because it's replacing raw HTML where it shouldn't.

Another way to reproduce without Secure HTTPS is to insert an image alt text with a hashtag, like

An image ![Nice #description](http://lorempixel.com/400/200)

djalmasi

clarkwinkelmann In fact, this script should be improved if I understand correctly.

clarkwinkelmann

010101 see my post above. In @djalmasi case the # is added by Secure HTTPS itself as part of its HTML, so it will basically happen anytime Secure HTTPS replaces an image. In my simpler example clarkwinkelmann the # is added by myself as part of an alt image attribute.

I doubt this can be fixed just by editing the regular expression. It's impossible to "parse" HTML via a regular expression to isolate text nodes vs markup.

My suggested solution without re-writing how the whole extension works would be to "walk" down the HTML nodes and run the regex on each text node that's inside a paragraph, instead of altering the innerHTML of the whole paragraph.

clarkwinkelmann

djalmasi yes, this extension is super basic. If you look at the source on GitHub you will see it performs a regular expression replace on the innerHTML value of paragraphs, which is not a very good practice. But apart from breaking formatting under some circumstances like these, I don't think there's any easy XSS.

The ideal implementation would be as a TextFormatter custom tag, but it's more advanced for developers.

010101

Hey there folks! This is probably fixable by adjusting the regular expression. In fact, a regular expression I used in the past might have prevented this, but I recently re-did the regular expression so that other languages would work. I guess we all have our opinions but with the perfect regular expression the way this is coded is fine.

010101

clarkwinkelmann Thanks! I’ll see if I can figure this out. It might be above my experience level though. During my lunch break today I got close to finding a solution... but not quite. 🙂

010101

Update: Recently a bug was reported for this basic yet satisfying extension. A fix has been found and within the next 8 hours or less the new version will be pushed out. The fix will prevent more HTML/Markdown conflicts.

010101

Version 3.4 Released

Fixed conflict with the formatting, secure HTTPS, and other extensions. To eliminate these and future conflicts hashtags will no longer be turned into links if they are included within a paragraph which also includes formatting. I'm sure some will not like this, however it is the best I can do for right now. Hashtags will still work anywhere else in a post (in a plain text paragraph or in their own paragraph/line). Nothing major will break if someone does try to post a hashtag in a heavily formatted paragraph - the hashtag just won't become a link.
Suggestion: If you have a page or post at your form explaining how things work, recommend that users put their hashtags on their own line at the end of their post. Or, in a paragraph without added formatting.
Fun fact: Even hashtags which are not turned into links will still be in your search results when a linked hashtag with the same word/phrase is clicked. And hey, at least this works with all languages and is super minimal so it won't slow anything down. Think positive! 🙂

djalmasi

010101
Thank You! Now working. I have a comment when there is a hashtag and an image insert directly below each other, without skipping Eg:
-hashtag
-image link
Then the hashtag not working, but if i skipping a line
-hashtag

-image link
then working.

010101

djalmasi Yep, that’s how it is designed for now. It was conflicting with formatting and image changes from other extensions. To prevent the conflict you can no longer have a hashtag in the same paragraph as formatted text or images.

Hashtags are now only allowed in plain text paragraphs like this one or on a new line by themselves.

Due to lack of spare time, this is the best I can do right now. At least it will no longer break images or anything.

« Previous Page Next Page »