Flarum-markdown fork with missing options!

Veriael

Hello! I forked the "flarum-markdown" extension, as I realized it lacks of "underline", "strikethrough" and "center" options, and you need to apply them manually.

Markdown
Added options are marked with green color.

It took just some copies and pastes, but I hope it will spare some of you unecessary trouble. 😀
Fork also contains locale files, so you don't need to worry about missing translations when using Flarum in English or Polish.

To download, use the command:
composer require veriael/markdown
Then you need to disable Markdown extension and enable fork named "Markdown+".

What if you're using other languages?
Well, I don't think that the fork will be updated frequently, so you can just rename "en.yml" to yourlanguagecode.yml and translate the lines.

Update:
I was educated that those are not Markdown options, so they shouldn't be in this extension. I mean... Whatever. 😅 It's just a fork.

ADDITIONAL BUTTONS REQUIRES BBCODE EXTENSION ENABLED!

rob006

Veriael I was educated that those are not Markdown options, so they shouldn't be in this extension. I mean... Whatever. 😅 It's just a fork.

These buttons probably doesn't work if you disable bbcode extension. I suggest merge these two extensions (bbcode and markdown) into one if you want to have such advanced editor.

jordanjay29

Would you be interested in submitting a PR for those changes to the flarum/markdown extension?

Veriael

jordanjay29 I thought that you intentionally didn't add these options. 😅 Sure.

I had been educated that these options are not Markdown ones.

However, pull request made, I changed the repo to only add these options and do nothing more. It needs some additional translations in flarum-english extension, which I specified in commentary.

Pollux

jordanjay29 Would you be interested in submitting a PR for those changes to the flarum/markdown extension?

If these additional buttons should find their way into the existing mardown extension, this extension could (and should) check whether the BBCode extension is active. If not, these bottons should obviously not be shown.

Veriael everyone has BBCode extension enabled anyway, don't they?

No, I haven't and I don't intend to activate it. First, I don't like the aestetics of the mark up, second, we don't miss the added functionality of BBCode.

Veriael

rob006 Hmm, yeah, that would probably be nice. It isn't that urgent though - everyone has BBCode extension enabled anyway, don't they?

rob006

Veriael At this scale I'm pretty sure that there are some instances without this extension. 🙂 IMO markdown is enough to express your thoughts, most of additional features provided by BBcode is pure noise which makes posts less readable, so I would not be surprised if someone will disable them.

BTW: You may consider changing keys for your translations: flarum-markdown is already used by flarum/markdown so they're conflicting each other - it could be a problem for language packs (see flarum/core1837).

Veriael

You're right again - I simply doesn't expect it to be used by many people, that's why it was made as simple for me as it can. Will work on this though. 🙂

phloo

on a mac "command + c" is the default shortcut for copying text, etc.
it's not helpful in edit mode if you want to copy something as it's automatically converted to [center] shortcode

Veriael

phloo I will just remove this shortcut. Should have done that earlier. 😉

phloo

Veriael I will just remove this shortcut. Should have done that earlier.

We updated veriael/markdown (v1.0.2 => v1.0.2.1)
Shortcut is still there.

Veriael

phloo Please, try clearing cache. 😉

phloo

clearing the app cache from the dashboard helped. browser cache update didnt 🙂

phloo

Any chance to make it compatible with beta 15?