FriendsOfFlarum Night Mode

datitisev

1.1.5

Fix theme select going off the screen in mobile-sized screens (Umutcan)
1.1.2 Fix both stylesheets loading when theme is set to 'auto'
1.1.4 Fix 'auto' loading neither stylesheet if the browser does not support preferred color scheme

Umutcan

peopleinside

datitisev there is some hope to see an option for not registered users that will allow tu turn off or on night mode? I see the feature request on GitHub exist since 2020
Thanks.

It require big and complex work?

IanM

1.1.6

Add button for guests to toggle forum theme by @datitisev in FriendsOfFlarum/nightmode54

Updating

composer require fof/nightmode:"*"
php flarum cache:clear

peopleinside

IanM thank you!
Can I report a small issue maybe present also before?

Checkboxes like when you flag a post and need select an option or the check box to stay logged still have dark background if the light theme is active. Can be this fixed? The issue is resolved if the extension night mode is turned off.

Another small issue with the new extension is that night mode miss the night mode text.

Screenshots:

Thanks.
FriendsOfFlarum/nightmode55

Darkle

IanM One question, what does this third icon mean/does?

Valeyard

peopleinside Can I report a small issue maybe present also before?

Checkboxes like when you flag a post and need select an option or the check box to stay logged still have dark background if the light theme is active. Can be this fixed? The issue is resolved if the extension night mode is turned off.

Another small issue with the new extension is that night mode miss the night mode text.

Yes it can I've just reported this issue on the repo. In the meantime if you wish to fix it yourself use HTML Head Items to add:

<meta name="color-scheme" content="light dark">

It won't remove the wrong meta tat but adding a duplicate tag will fix the issue there, and then in Appearance > Custom Styles add this to your custom CSS:

:root {
  color-scheme: light dark;
}

Walys Can be hide via custom CSS?

#header .Header-controls>.item-nightmode {
  display: none;
}

peopleinside

Darkle this new icon is for allow guest (not registered users) to choose if use dark, light or automated theme. If you press it you will see forum theme change.

Darkle

peopleinside Ahh ok, yeah I was referring to the automated theme icon, as my system was in dark mode it didn't do anything and that's why I didn't understand what it was for, I completely forgot about that... 😅

datitisev

Darkle Do you have a better suggestion for an icon? I couldn't really think of a good one, and feel like at least this one makes sense when you understand what it does... but I guess getting there is the hard part.

peopleinside

datitisev I like it

Darkle

datitisev Yeah, I think so too, the tricky thing is to guess that (although I have to say that if I had the system in light mode I probably would have realised). I had a look at FA and I couldn't find another icon, the one you have chosen is really the best for this case.

datitisev

1.1.7

Fix buttton label in logged in dropdown not appearing
Fix browser color scheme logic not working
- Used for e.g. page load white/black screen
- Some browsers use it to style input elements
- Guests will have it set to dark light regardless of their per-device choice (if they select something other than auto)

Gatsu

datitisev I found a bug for guest user:

With google chrome and edge (pc desktop) The remaining items in the bar end up below. This happens with all resolutions (tested 1366x768 and on 1920x1080). It only happens with visitors, once logged in it's OK. I assume it's too long text from dar / night mode

https://i.imgur.com/WJeqy9c_d.webp?maxwidth=640&shape=thumb&fidelity=medium
https://i.imgur.com/B8wcsiT_d.webp?maxwidth=640&shape=thumb&fidelity=medium

datitisev

1.1.8

Fix guest button label not hiding in some browsers outside mobile view (thanks Gatsu)

Umutcan

datitisev A checkbox should be added to the plugin settings page such that this icon should appear and not appear

datitisev

Umutcan Why would you need it to not appear? If you want that it can be done through CSS as well.

Umutcan

datitisev When I updated, I saw that the text was removed and only the icon remained. That's enough, my previous request has thus become meaningless.

Walys

datitisev

In my case I prefer that icon should not appear because have many other icons and links with other extension "FoF Links".
In this case I prefer have the option to hide the icon view for all users. For me with the first option to change in menu only for a register user its ok!

Can be hide via custom CSS?
it would be very difficult to generate the code?

Thanks.

IanM

1.2.0 What's Changed

Flarum v1.2 override updates & fixing conflicts with other frontends by @datitisev in FriendsOfFlarum/nightmode57

Full Changelog: https://github.com/FriendsOfFlarum/nightmode/compare/1.1.8...1.2.0

Updating

composer require fof/nightmode:"*"
php flarum cache:clear

matteocontrini

Hello, would it be feasible to have the code block style adjusted depending on night mode? Currently syntax highlighting makes those blocks almost unreadable in dark mode but highlight.js should support different styles. Or as a workaround the block could be kept always in light mode (not sure how it would look like).

Walys

One question.
Stay now in Flarum 1.0.4 and this is my first core update to 1.2.0 and have problems to update this extension.

The extensions need to update after or before the update core?
Sorry not understand very well the Official Updating Notes.

I understand that go with this line to update Flarum core system:
1º Make sure all your extensions have versions compatible with the Flarum.
2º update all extensions or remove that are not compatible.
3º disabling third-party extensions in the admin dashboard before updating the Flarum Core.
4º Then run the command to update the core.

This is ok?

In this extension I have now 1.0.0
In my composer.json archive I view this: "fof/nightmode": "*",
To update I go with this problem and not update:

`$ *composer require fof/nightmode:"*"*
./composer.json has been updated
Running composer update fof/nightmode
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files
82 packages you are using are looking for funding.
Use the `composer fund` command to find out more!`

Then I test update without "*"

composer require fof/nightmode
Using version ^1.2 for fof/nightmode
./composer.json has been updated
Running composer update fof/nightmode
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires fof/nightmode ^1.2 -> satisfiable by fof/nightmode[1.2.0].
    - fof/nightmode 1.2.0 requires flarum/core ^1.2.0 -> found flarum/core[v1.2.0] but the package is fixed to v1.0.4 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Not understand very well where is the problem.
I run the command view in the ultimate version to update the extension: composer require fof/nightmode:"*"
But in the OP message view other command to update the extenion: composer update fof/nightmode

askvortsov

Walys Our recommendation is as follows. In composer.json, set the versions for all extensions to "*". Set the version for "flarum/core" to "v1.2". Then run composer update.

« Previous Page Next Page »