PHP and WordPress Single Sign On (SSO) with optional JWT Addon

lubos-h

Hey maicol07 ! I hope you are well.

Going through painful upgrade of my PHP application from PHP 7.4 to PHP 8.2 and noticed error related to "maicol07/flarum-sso-plugin/User::126". PHP 8.2 is now throwing error: Creation of dynamic property Maicol07\SSO\User\Attributes::$slug is deprecated,

Change details are documented on php.net:
https://www.php.net/manual/en/migration82.deprecated.php#:~:text=The%20creation%20of%20dynamic%20properties%20is%20deprecated%2C%20unless,dynamic%20properties%20deprecation%20warning%20can%20be%20addressed%20by%3A

Are you planning to add PHP 8.2 support?

Thanks and all the best!

lubos-h

Quick fix is to add #[\AllowDynamicProperties] before class src/User/Attributes definition.
Still maybe it would be better to define all variables within the class.

lucasf

I'm having a bit of trouble using this extension, and this is due to my current lack of knowledge. Could anyone give me some help?

When I set up the login URL to https://accounts.google.com/login?hl=pt-br&redirect_to=forum, for example, I'm not redirected to the forum afterwards. Does this work only for WordPress? My company has its own website and I'd like to use the login in this site to create a session on Flarum.

maicol07

lucasf hi! Yes, the redirect to flarum feature only works on WordPress. You'll have to do it yourself if you use a different auth system (if you use PHP you can integrate the PHP plugin (check in the docs))

maicol07

lubos-h sorry, didn't see your message. Surely I'll add support for PHP 8.2: actually, properties are already defined. What might trigger it are custom attributes. I'll look at it!

peteryang

What happen?

maicol07

peteryang there's indeed something wrong. Let me check.
Thanks for the feedback

maicol07

peteryang this has been fixed. For some reasons permissions were messed up...

jslirola

Yesterday I was deleting a user from the forum and an error occurred. I didn't think it could be related to this extension but checking the logs, I was wrong.

I copy them here in case you want to review it:

[2023-03-09 17:58:32] flarum.ERROR: TypeError: Maicol07\SSO\Listener\ProviderModeListener::deleteUserInClients(): Argument #1 ($event) must be of type Flarum\User\Event\Saving, Flarum\User\Event\Deleted given, called in /home/myuser/domain.com/flarum/vendor/illuminate/events/Dispatcher.php on line 424 and defined in /home/myuser/domain.com/flarum/vendor/maicol07/flarum-ext-sso/src/Listener/ProviderModeListener.php:89
Stack trace:
#0 /home/myuser/domain.com/flarum/vendor/illuminate/events/Dispatcher.php(424): Maicol07\SSO\Listener\ProviderModeListener->deleteUserInClients(Object(Flarum\User\Event\Deleted))
#1 /home/myuser/domain.com/flarum/vendor/illuminate/events/Dispatcher.php(249): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}('Flarum\\User\\Eve...', Array)
#2 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Foundation/DispatchEventsTrait.php(33): Illuminate\Events\Dispatcher->dispatch('Flarum\\User\\Eve...')
#3 /home/myuser/domain.com/flarum/vendor/flarum/core/src/User/Command/DeleteUserHandler.php(55): Flarum\User\Command\DeleteUserHandler->dispatchEventsFor(Object(Flarum\User\User), Object(Flarum\User\User))
#4 /home/myuser/domain.com/flarum/vendor/illuminate/bus/Dispatcher.php(122): Flarum\User\Command\DeleteUserHandler->handle(Object(Flarum\User\Command\DeleteUser))
#5 /home/myuser/domain.com/flarum/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Flarum\User\Command\DeleteUser))
#6 /home/myuser/domain.com/flarum/vendor/illuminate/pipeline/Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Flarum\User\Command\DeleteUser))
#7 /home/myuser/domain.com/flarum/vendor/illuminate/bus/Dispatcher.php(132): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#8 /home/myuser/domain.com/flarum/vendor/illuminate/bus/Dispatcher.php(78): Illuminate\Bus\Dispatcher->dispatchNow(Object(Flarum\User\Command\DeleteUser))
#9 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Api/Controller/DeleteUserController.php(39): Illuminate\Bus\Dispatcher->dispatch(Object(Flarum\User\Command\DeleteUser))
#10 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Api/Controller/AbstractDeleteController.php(24): Flarum\Api\Controller\DeleteUserController->delete(Object(Laminas\Diactoros\ServerRequest))
#11 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractDeleteController->handle(Object(Laminas\Diactoros\ServerRequest))
#12 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#13 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#14 /home/myuser/domain.com/flarum/vendor/kilowhat/flarum-ext-audit-free/src/Middlewares/SetLoggerActor.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#15 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Kilowhat\Audit\Middlewares\SetLoggerActor->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#16 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#17 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\ThrottleApi->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#18 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(44): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#19 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#20 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(69): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#21 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#22 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#23 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#24 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#25 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#26 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#27 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#28 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#29 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#30 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#31 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#32 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#33 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\FakeHttpMethods->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#34 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#35 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#36 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#37 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#38 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#39 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\InjectActorReference->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#40 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#41 /home/myuser/domain.com/flarum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#42 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#43 /home/myuser/domain.com/flarum/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#44 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#45 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#46 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#47 /home/myuser/domain.com/flarum/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#48 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#49 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#50 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ProcessIp->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#51 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#52 /home/myuser/domain.com/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#53 /home/myuser/domain.com/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#54 /home/myuser/domain.com/flarum/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#55 /home/myuser/domain.com/public/forum/index.php(26): Flarum\Http\Server->listen()
#56 {main}

maicol07

1.11.5

Released on March 10, 2023

🐛 Bug Fixes

2795bce 🐛 Fix wrong event type when deleting an user (jslirola)

📝 Docs changes

7fd176c 📝 Removed bazaar references

Other changes

91a8e68 🙈 Added composer.lock in .gitignore
f957f86 Added IDE settings
d389a1c Added composer.lock
55baf16 deps: ⬆️ Upgraded dependencies

⏪ Reverts

b109334 chore: Added composer.lock

This reverts commit d389a1c5df684b1a55bfba9bbad4d97f4afd6b28.

peteryang

I haven't finished my sso settings yet, but what should I do if it logs in by itself and I can't get in now

maicol07

peteryang if you are locked out you have to disable the extension manually from the database settings table (search for enabledExtensions and remove maicol07-sso)

peteryang

maicol07
Hello,why do i get this error when i log in

How to fix it?

maicol07

peteryang can you send the error mentioned in the message?
Thanks

maicol07

NOTICE: The server where the docs are hosted is having major network issues. For the time being, you can check the docs via Web Time Machine: http://web.archive.org/web/20221128090447mp_/https://docs.maicol07.it/en/flarum-sso/ext

jslirola

@maicol07 I think I finally found the problem in my forum when new users are registering. They do not need to confirm their email. Could you confirm that your extension is doing this?

I've been going through all the extensions I've installed since it's happening and this is the biggest, check out these links in your code:
https://github.com/maicol07/flarum-ext-sso/blob/master/src/JWTSSOController.php#L159
https://github.com/maicol07/flarum-ext-sso/blob/897c8b2e20f53211f31513f357753f96b3e51da6/extend.php#L28

To be honest I'm not sure but I don't lose anything by asking, after many hours without success or progress

maicol07

jslirola yes, new users shouldn't require activation, since it should be already handled by your auth system.

jslirola

maicol07 okay. Thank you!

In my case I am using the Flarum code to sign up and my auth system manages them just for login. Is that a bug in the extension?

maicol07

jslirola well, the extension is designed to automatically enable evey user that signs up (i.e. via the API), so I might not call it bug...

jslirola

maicol07 Is there an option to disable that feature? I could fork and comment out that part of the code but I still don't know how to add options to an extension so that something can be enabled or disabled.

maicol07

jslirola no, not at the moment

« Previous Page Next Page »