FriendsOfFlarum GitHub Autolink

rob006

Is this extension is installed on disquss.flarum.org? There is invalid link here: https://discuss.flarum.org/d/19301-keyboard-shortcuts/9

datitisev

rob006 Yes. It only affects new/edited posts as old posts already have their content rendered as HTML.

matteocontrini

There's an issue here as well 🤔: https://discuss.flarum.org/d/21865-account-deletion/2

datitisev

matteocontrini As I said, the fixes only affect posts when they have been created or edited after the extension has been updated - so old issues with github auto link will remain broken. This isn’t a bug - it’s how it’s intended to be as rerendering every single post would dramatically slow down the site.

matteocontrini

datitisev thanks, I didn't see any mention of fixes so I thought it was the same as before.

datitisev

matteocontrini

Now tagged with beta 8 support. Also supports pull request links and comments.

Though I didn't look at the bug before answering - my bad. Yeah, that seems like a bug with the new version, so I'll try to fix it now.

datitisev

0.1.1

Fix mentions that no longer resolve being converted into GitHub links (eg: Simdol)

Updating

composer require fof/github-autolink

tolgaaaltas

Can we make this for internal links? For example i paste this URL in text area https://discuss.flarum.org/d/21856-friendsofflarum-github-autolink/8 and an extension convert to FriendsOfFlarum GitHub Autolink/#8 (or 21856/#8) would be awesome!

datitisev

tolgaaaltas 🤔 that's an idea, though it'd require more work than just shortening existing text.

datitisev

0.1.2

Add support for links to commits with diffs (selected file or line(s))

Updating

composer require fof/github-autolink

clarkwinkelmann

Did something change recently ? All links to issues seem to show "(comment)" after them, even if they don't reference a comment.

Example: https://github.com/flarum/core/issues/1356 flarum/core1356

The preview doesn't show (example), but once posted it does.

matteocontrini

clarkwinkelmann I think the problem is the isset() call at line 35. I'm no PHP expert but I think the variable is always set even if there is no match, and it's instead empty.

Those lines should really be commented anyway, it's hard to understand what they're doing 🙂

datitisev

0.1.3

Fix issue with most links showing (comment) and/or (diff) when they don't have either
Fix potential issues when posting because of out of range match indexes

Updating

composer require fof/github-autolink
php flarum cache:clear

IanM

0.1.5

Updated meta ready for beta 15 (no code/functionality change)
Compatible with beta 14 and up

Updating

composer require fof/github-autolink

IanM

0.1.6

Updated composer to core beta 16 (so that Extiverse marks as compatible)
No code/functionality change

Updating

composer require fof/github-autolink:"*"

Littlegolden

IanM you forgot the :

IanM

Littlegolden Whoops 🙈 thanks for pointing that out 🙂

IanM

1.0.0

Updated composer to core 1.0 (so that Extiverse marks as compatible)
No code/functionality change

IanM

1.1.0

UI Overhaul, add support for PR comit, comment. FriendsOfFlarum/github-autolink1

Screenshots

Dark mode

Light mode

Updating

composer require fof/github-autolink:"*"
php flarum cache:clear

tolgaaaltas

Is it possible to add an option with this (IanM ) style?
Favicon -> tag name -> discussion title -> discussion id

GoodTimes

How about GitLab support? The link structure there is very similar to GitHub, so it would not be hard to implement and support.