matteocontrini
Now tagged with beta 8 support. Also supports pull request links and comments.
Though I didn't look at the bug before answering - my bad. Yeah, that seems like a bug with the new version, so I'll try to fix it now.
composer require fof/github-autolink
Can we make this for internal links? For example i paste this URL in text area https://discuss.flarum.org/d/21856-friendsofflarum-github-autolink/8 and an extension convert to FriendsOfFlarum GitHub Autolink/#8 (or 21856/#8) would be awesome!
tolgaaaltas 🤔 that's an idea, though it'd require more work than just shortening existing text.
Did something change recently ? All links to issues seem to show "(comment)" after them, even if they don't reference a comment.
Example: https://github.com/flarum/core/issues/1356 flarum/core#1356
https://github.com/flarum/core/issues/1356
The preview doesn't show (example), but once posted it does.
clarkwinkelmann I think the problem is the isset() call at line 35. I'm no PHP expert but I think the variable is always set even if there is no match, and it's instead empty.
isset()
Those lines should really be commented anyway, it's hard to understand what they're doing 🙂
(comment)
(diff)
composer require fof/github-autolink php flarum cache:clear
composer require fof/github-autolink:"*"
ianm you forgot the :
:
Littlegolden Whoops 🙈 thanks for pointing that out 🙂
