Redis sessions, cache & queues

matteocontrini

luceos thanks 😃

Looking at the Laravel documentation, is the failed_jobs table something that can be used with this extension, in order to still have some manual control on failed jobs?

luceos

matteocontrini I might have not made the differences too clear. This extension indeed also allows restarting failed jobs, but manually, same with horizon. But horizon offers more scalability, notification options and a full ux to see jobs, queues and horizon nodes.

matteocontrini

luceos sorry, it was clear, maybe I put the question in a weird way 🙂

So in general, with Flarum queues, how would I generate the failed jobs table? Looking at the source code of this extension it doesn't seem it's done automatically (and I can't find it in flarum/core either), so I was wondering if/how the relevant Laravel commands can be used with Flarum.

luceos

matteocontrini would make sense to have that table by default I guess. I think I've seen it in my database but not sure where it is migrated.

matteocontrini

luceos mmm ok 🙂 so if I wanted to have that table, how would I create it in practice? 😅

Thanks!

luceos

matteocontrini I can share that code when I'm behind a computer. Remind me if I forget, I seriously need a mark unread extension for flarum.

[deleted]

luceos can't agree with this more. A mark unread extension would be fantastic..

matteocontrini

luceos Remind me if I forget

Here's your reminder 😃

xkeyC

Can I use unixsocket to connect?

https://wiki.archlinux.org/index.php/redis#Listen_on_socket

luceos

xkeyC set the socket path as host, keep password and port empty. I haven't tested this, but it should work, see:

xkeyC

luceos No, I think it hardcodes the tcp protocol.

xkeyC

luceos

Is this a bug? I found that the email notification indicated that I reply myself. (It happened on my website, and discuss.flarum.org)

luceos

matteocontrini thanks 🙈

<?php

use Flarum\Database\Migration;
use Illuminate\Database\Schema\Blueprint;

return Migration::createTable(
    'queue_failed',
    function (Blueprint $table) {
        $table->bigIncrements('id');
        $table->text('connection');
        $table->text('queue');
        $table->longText('payload');
        $table->longText('exception');
        $table->timestamp('failed_at')->useCurrent();
    }
);

This would then be a local migration, you would have to create a command to make that table. I think it would make more sense for core to have this table by default, @askvortsov what do you think?

askvortsov

luceos we could definitely consider adding it in sometime after stable.

matteocontrini

luceos This would then be a local migration, you would have to create a command to make that table.

Not sure how to do this 😅

Would it be also fine to have a custom extension, which I actually already have, with a migration to create the table?

matteocontrini

luceos sorry, it's still me. I created that table, but I don't see anything being inserted when a job fails. I tried with both queue_failed and failed_jobs (from the Laravel docs) as table names, without success. (Database prefix excluded.)

Am I missing something?

askvortsov

xkeyC Yep, fixed in flarum/mentions9abc434, will be available with beta 16

xkeyC

askvortsov I have found Flarum/mentions hasn't made any major changes, can you push this fix in advance? (like v0.1.0-beta.15.1) ,This will solve the problems of a large part of people.

luceos

matteocontrini yeah for the time being.

matteocontrini

luceos thank you 🙂

luceos

matteocontrini I totally forgot that part 🙈


use Illuminate\Database\ConnectionInterface;
use Illuminate\Queue\Failed\DatabaseFailedJobProvider;
// ..
        $container->bind('queue.failer', function () use ($container) {
            return new DatabaseFailedJobProvider(
                $container->make(ConnectionResolverInterface::class),
                'flarum',
                'queue_failed'
            );
        });
// ..

This is what I added in my code as well. This could best be an extender.

TLDR this is becoming far more complicated than a simple "create the table"; if I have some time the coming weeks I will create a proper package/extension to add this logic.

« Previous Page Next Page »