Redis sessions, cache & queues

matteocontrini

luceos mmm ok 🙂 so if I wanted to have that table, how would I create it in practice? 😅

Thanks!

luceos

matteocontrini I can share that code when I'm behind a computer. Remind me if I forget, I seriously need a mark unread extension for flarum.

[deleted]

luceos can't agree with this more. A mark unread extension would be fantastic..

matteocontrini

luceos Remind me if I forget

Here's your reminder 😃

xkeyC

Can I use unixsocket to connect?

https://wiki.archlinux.org/index.php/redis#Listen_on_socket

luceos

xkeyC set the socket path as host, keep password and port empty. I haven't tested this, but it should work, see:

xkeyC

luceos No, I think it hardcodes the tcp protocol.

xkeyC

luceos

Is this a bug? I found that the email notification indicated that I reply myself. (It happened on my website, and discuss.flarum.org)

luceos

matteocontrini thanks 🙈

<?php

use Flarum\Database\Migration;
use Illuminate\Database\Schema\Blueprint;

return Migration::createTable(
    'queue_failed',
    function (Blueprint $table) {
        $table->bigIncrements('id');
        $table->text('connection');
        $table->text('queue');
        $table->longText('payload');
        $table->longText('exception');
        $table->timestamp('failed_at')->useCurrent();
    }
);

This would then be a local migration, you would have to create a command to make that table. I think it would make more sense for core to have this table by default, @askvortsov what do you think?

askvortsov

luceos we could definitely consider adding it in sometime after stable.

matteocontrini

luceos This would then be a local migration, you would have to create a command to make that table.

Not sure how to do this 😅

Would it be also fine to have a custom extension, which I actually already have, with a migration to create the table?

matteocontrini

luceos sorry, it's still me. I created that table, but I don't see anything being inserted when a job fails. I tried with both queue_failed and failed_jobs (from the Laravel docs) as table names, without success. (Database prefix excluded.)

Am I missing something?

askvortsov

xkeyC Yep, fixed in flarum/mentions9abc434, will be available with beta 16

xkeyC

askvortsov I have found Flarum/mentions hasn't made any major changes, can you push this fix in advance? (like v0.1.0-beta.15.1) ,This will solve the problems of a large part of people.

luceos

matteocontrini yeah for the time being.

matteocontrini

luceos thank you 🙂

luceos

matteocontrini I totally forgot that part 🙈


use Illuminate\Database\ConnectionInterface;
use Illuminate\Queue\Failed\DatabaseFailedJobProvider;
// ..
        $container->bind('queue.failer', function () use ($container) {
            return new DatabaseFailedJobProvider(
                $container->make(ConnectionResolverInterface::class),
                'flarum',
                'queue_failed'
            );
        });
// ..

This is what I added in my code as well. This could best be an extender.

TLDR this is becoming far more complicated than a simple "create the table"; if I have some time the coming weeks I will create a proper package/extension to add this logic.

matteocontrini

luceos it appears it's still not working...

I created an extender:

use Flarum\Extend\ExtenderInterface;
use Flarum\Extension\Extension;
use Illuminate\Contracts\Container\Container;
use Illuminate\Database\ConnectionResolverInterface;
use Illuminate\Queue\Failed\DatabaseFailedJobProvider;

class BindQueueFailer implements ExtenderInterface
{

    public function extend(Container $container, Extension $extension = null)
    {
        $container->bind('queue.failer', function () use ($container) {
            return new DatabaseFailedJobProvider(
                $container->make(ConnectionResolverInterface::class),
                'flarum',
                'queue_failed'
            );
        });
    }
}

Which I'm pretty sure is executed because with my advanced PHP skills I put a die() and it did die 🙂

The migration was run and the queue_failed table is there.

I run php flarum queue:work and made a job fail:

[2021-02-25 13:21:49][jaNSua02JCkpUeEP30Usn4bPJqZ2mGxl] Processing: Flarum\Notification\Job\SendNotificationsJob
[2021-02-25 13:21:49][jaNSua02JCkpUeEP30Usn4bPJqZ2mGxl] Processed:  Flarum\Notification\Job\SendNotificationsJob
[2021-02-25 13:21:49][NqDgK5eQotXESgiS1qToWFhNfQ2CKIpz] Processing: Flarum\Notification\Job\SendEmailNotificationJob
[2021-02-25 13:21:49][NqDgK5eQotXESgiS1qToWFhNfQ2CKIpz] Failed:     Flarum\Notification\Job\SendEmailNotificationJob
[2021-02-25 13:21:49][7WzqpIpXQe4KRPWLWdc6d6PFfJONWYOH] Processing: Flarum\Subscriptions\Job\SendReplyNotification
[2021-02-25 13:21:49][7WzqpIpXQe4KRPWLWdc6d6PFfJONWYOH] Processed:  Flarum\Subscriptions\Job\SendReplyNotification

The table is still empty. Something I could look at? 😅

Thanks! 😃

matteocontrini

Ok, an update. I looked at the logs and it says:

Next Illuminate\Database\QueryException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'connection' cannot be null (SQL: insert into `queue_failed` (`connection`, `queue`, `payload`, `exception`, `failed_at`) values (?, default, [...]

What am I doing wrong 😭

luceos

matteocontrini interesting 😂 truth be told I'm not even sure it works on my end yet. So I guess this is trial-and-error. Can you manually set the connection field to be nullable in your database editor?

matteocontrini

luceos done and it works now, finally 😃

connection is null obviously, but I'm not even sure what that should stand for so that's fine, I guess 😅

« Previous Page Next Page »