Removing welcome banner when there is no welcome banner

notakoder

When the forums doesn't have any welcome banner text configured, it makes no sense displaying an empty banner with a close button. Screeenshot here .

Yes, it is an additional computing to the server, but from UX standpoint, it's important not to show empty banners. Consider showing the banner only if there is some banner text added to the forum.

TheyCallMeTojo

I'm sure you could fix that pretty easily. You could edit WelcomeHero.js to something like:

Find: view() { if (this.hidden) return <div/>;

And under it add:
if (app.forum.attribute('welcomeTitle')=="") return </div>;

portals

Any solution for this yet? Is TheyCallMeTojo 's solution a good one or isn't there a CSS solution as UntrustableRus pointed out?

notakoder

How about we do that for Flarum out of the box as well?

jordanjay29

notakoder the Welcome Banner is likely to be removed so it can be more easily replaced by a robust extension. So like FoF User Bio, an extension will be written to replace it and then Flarum will remove it from core. Mostly because, as you've pointed out, there are some situations it could do better and an extension developer would have more freedom to iterate on the feature than core Flarum does right now.

notakoder

Very good.

UntrustableRus

Little css manipulation may be able to hide it.

hrvoje_hr

portals you can use:

header.Hero.WelcomeHero {
    display: none;
}

TeroBox

hrvoje_hr Thanks it works for me.

nbaever3

I hope this does gets implemented. For many people (I've been told those with hardware acceleration off) you have to scroll past the banner or else your discord lags badly. It's very annoying; the mouse cursor and entire pc gets quite jerky and I'm not the only one. So I have to go up, scroll down so the banner isn't visible blegh.

askvortsov

nbaever3 else your discord lags badly.

Could you elaborate a bit more on this? How does Flarum impact discord?

pierres

Are there any news on this issue? Will this feature be removed in an upcoming version or will a pull request be accepted to at least hide it when no message is given?