Premium WordPress Integration

hrvoje_hr

Unfortunately, the issue still persists after the update on my side

EDIT: Also, after the update login on the Flarum side doesn't work anymore. Instead of WP login windows now Flarum login is brought up with the error message:

This account is linked with Wordpress. Use the main website login form to connect.

clarkwinkelmann

hrvoje_hr are you using the Only allow Wordpress login option? If you disable the option, are you able to login by clicking the login link and then the Wordpress social login button inside of the login modal?

I'm not seeing that issue on my side. It must be an extension conflict or out of date cache.

hrvoje_hr

clarkwinkelmann I think it was something with the cache. Although I emptied it before going here this morning, 8 hours later the issue disappeared.

But the whole Flarum still loads into the comments iframe. Is there any way to rollback to a previous version?

clarkwinkelmann

hrvoje_hr the issue I have identified has existed in all versions of my extension and Flarum, so I don't think you can rollback to any version that would make a difference.

I tried checking your website again to see if I see something different but right now it fails to load with an error. It seems like forum.js is not being generated by Flarum. It returns a 404 and is not being generated even when I refresh the homepage.

Do you have any messages logged to the Flarum log file? Maybe there are some errors during the javascript compilation by Flarum?

hrvoje_hr

Can you check now? Now it's loading fine

clarkwinkelmann

hrvoje_hr both login and iframe target seem to work perfectly on your website right now. I tried clicking the logo, the user profile, the header nav links, all open in the parent window. Login link opens the Wordpress login in both iframe and from forum domain.

If you still experience issues, maybe it's a browser cache issue?

hrvoje_hr

clarkwinkelmann yes, that works great now, as I said in my previous posts. But I'm referencing on comments integration from this hrvoje_hr post

clarkwinkelmann

hrvoje_hr do you mean the header/navigation elements are not supposed to be visible?

This must be caused by your custom CSS. My extension hides it all by default.

You can add some additional CSS for the embed only if needed by going to Admin > Appearance > Edit custom CSS for Wordpress embed only.

hrvoje_hr

clarkwinkelmann Now I've completely removed custom CSS, and still, everything is shown.

clarkwinkelmann You can add some additional CSS for the embed only if needed by going to Admin > Appearance > Edit custom CSS for Wordpress embed only.

Actually, after the update comments iframe completely ignores custom CSS from your extension.

hrvoje_hr

clarkwinkelmann I found the culprit by deactivating all other extensions one by one.

FoF Night Mode:
https://discuss.flarum.org/d/21492-friendsofflarum-night-mode

With FoF Night Mode activated, Wordpress Comments Integration doesn't work

The whole Flarum is loaded instead of just comments
All custom CSS from the extension is ignored

Both extensions worked fine side by side on Flarum 1.3

clarkwinkelmann

hrvoje_hr ah yes Nightmode has been listed as incompatible in my documentation for a long time https://kilowhat.net/flarum/extensions/wordpress#compatibility

I'm surprised to hear it worked before. From what I've studied Night Mode is fundamentally incompatible with any extension that creates custom frontends, which include this Wordpress extension, my Backoffice extension and my Mithril2Html extension.

Still I'm surprised I didn't experience the issue when visiting your website. Was Nightmode temporarily disabled? Or maybe it has something to do with my system preferred theme and the auto mode of Nightmode, or just the fact I was logged out.

Unfortunately there is currently no way to make Nightmode compatible. A complete rewrite of Nightmode is needed.

hrvoje_hr

clarkwinkelmann Still I'm surprised I didn't experience the issue when visiting your website. Was Nightmode temporarily disabled?

Depends on when you visited my website. It's been deactivated for the last few hours, from 8 PM CET. Before, on 1.3 and earlier Flarum versions they both coexisted for two years without any issues. Through the CSS I forced all iframe comments elements into the day mode.

But after 1.3 > 1.6 Flarum upgrade yesterday, the comments iframe malfunctioned. Can there be a way to keep Night Mode on Flarum, but completely disable it in comments integration?

clarkwinkelmann

hrvoje_hr I'm not entirely sure where things stand with this. I would have to install Nighmode on my test forum and see what's wrong nowadays.

This is the issue I was originally referring to but I see it has been marked as fixed since version 1.2 of Nightmode FriendsOfFlarum/nightmode47

I see there were some important changes in both Nightmode versions 1.2 and 1.4. Maybe this was originally fixed and then broken again?

Do you know which version of Nightmode you were running prior to the update?

hrvoje_hr

clarkwinkelmann Do you know which version of Nightmode you were running prior to the update?

The previous one was 1.2.2. with Flarum 1.3. Before upgrading on Flarum 1.3 I was on Flarum Beta-16 with FoF Night Mode 0.4.0

hrvoje_hr

Does anyone have an issue when new WordPress comments threads on Flarum are automatically marked as read (greyed out) to users?

clarkwinkelmann

hrvoje_hr what's your setting for "Set the summary post as the last post of new discussions" under Comments integration?

If I remember correctly, when that setting is Off, discussions won't have a last post information and Flarum will show them like read discussions. This setting also impacts the sorting of discussions in the list.

https://kilowhat.net/flarum/extensions/wordpress#set-the-summary-post-as-the-last-post-of-new-discussions

hrvoje_hr

That was the first I checked, it's on. This issue occurred after I upgraded Flarum from 1.3 to 1.6

clarkwinkelmann

Version 1.7.6 - December 13, 2022

Fix "WordPress" case in the extension name, documentation and English translations. The namespaces and attributes are unchanged and keep their lowercase "p".
Fix new comment threads with no replies not showing as unread in Flarum discussion list. It will now show as unread + zero replies which Flarum would not natively do.

This problem appeared in version 1.7.4 when the reply count was fixed for new discussions.

hrvoje_hr this should fix the issue. Thanks for your report! It wasn't actually caused by the Flarum update, but by the change I made in a previous version to fix the reply count.

hrvoje_hr

clarkwinkelmann it works, thank you!

« Previous Page Next Page »