How to change syntax highlighting

therealsujitk

How to change the highlightjs theme (syntax highlighting) that is currently being used at my forum?

clarkwinkelmann

therealsujitk it seems like there are some variables exposed in the TextFormatter code template. There must be a way to change them via an an extension, or completely replace the template https://s9etextformatter.readthedocs.io/Plugins/BBCodes/Add_from_the_repository/#code

Maybe @JoshyPHP can give us some hints if he's around.

JoshyPHP

I'm always around. 😉

If you want to make it configurable within Flarum's BBCode plugin you'd need to add the style's name to this line:

$config->BBCodes->addFromRepository('CODE', 'default', ['style' => 'dracula']);

You'll need a recent version of the repository though because I don't remember when the style became configurable.

therealsujitk

JoshyPHP It doesn't work.... It still shows the default style. Using Flarum beta11, BBcode beta8.

All I did was update the line you gave in extend.php in the BBcode extension. It still shows the default theme.

Littlegolden

JoshyPHP This method seems doesn't work in Flarum-beta.12.

JoshyPHP

Yes, it depends on the version of the BBCode repository in use. I don't know Flarum's dependencies off the top of my head so it's possible it uses an older version that doesn't have a hardcoded style name.

tankerkiller125

JoshyPHP Yeah it's a little behind in Flarum, something that will probably need to be updated at some point before stable.

therealsujitk

JoshyPHP tankerkiller125, so there's no way to change the theme at this point?

tankerkiller125

therealsujitk Currently Flarum uses TextFormatter ^1.2.0 so I'm guessing the answer is no. The current version is 2.2.3 I'll we will haveto see what changes were made between the two versions and update the core accordingly. I've added a ticket on Github so that we don't lose track of this. flarum/core1979

therealsujitk

tankerkiller125 Thankyou!!

tankerkiller125

therealsujitk A pull request to bring s9e/text-formatter up to date has been created. flarum/core1982

therealsujitk

tankerkiller125 Awesome!! I hope this will get implemented in beta12

therealsujitk

tankerkiller125 Is there any way I can update s9e/text-formatter on my current beta-11 so that I don't have to wait until Flarum stable 0.1?

tankerkiller125

therealsujitk based on testing you can probably upgrade via just composer (check PR file changes) be aware however I can not guarantee compatibility with any other extensions other than Markdown, BBCode, FoF Formatting and Mentions.

therealsujitk

tankerkiller125 I made the changes in composer.json and ran

composer update s9e/text-formatter

But it gave:

Loading composer repositories with package informationUpdating dependencies (including require-dev)Your requirements could not be resolved to an installable set of packages.  Problem 1    - flarum/core v0.1.0-beta.11.1 requires s9e/text-formatter ^1.2.0 -> satisfiable by s9e/text-formatter[1.2.0, 1.2.1, 1.2.2, 1.3.0, 1.3.1, 1.3.2, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5] but these conflict with your requirements or minimum-stability.    - flarum/core v0.1.0-beta.11.1 requires s9e/text-formatter ^1.2.0 -> satisfiable by s9e/text-formatter[1.2.0, 1.2.1, 1.2.2, 1.3.0, 1.3.1, 1.3.2, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5] but these conflict with your requirements or minimum-stability.    - flarum/core v0.1.0-beta.11.1 requires s9e/text-formatter ^1.2.0 -> satisfiable by s9e/text-formatter[1.2.0, 1.2.1, 1.
2.2, 1.3.0, 1.3.1, 1.3.2, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5] but these conflict with your requirements or minimum-st
ability.
    - Installation request for flarum/core (locked at v0.1.0-beta.11.1, required as ^0.1.0) -> satisfiable by flarum/core[v
0.1.0-beta.11.1].

tankerkiller125

Ah yes, unfortunately I don't think you'll be able to upgrade it then (unless someone knows more about how composer deals with these things can give some advice here). I forgot that core being a dependency in the actual installation makes it so that you can't upgrade core dependencies manually.

therealsujitk

tankerkiller125 Did Flarum change the Syntax Highlighting theme to Github Gist?

tankerkiller125

therealsujitk Flarum is still using whatever is default in TextFormatter

therealsujitk

tankerkiller125 Yeah, I guess it's changed to the GitHub Gist theme.

#include <iostream>
using namespace std;

void main() {
    cout << "Hello World!";
}

There is a bug though, the syntax gets highlighted only on reloading the page. This needs to be fixed.

tankerkiller125

therealsujitk we did notice a discrepancy there, on some browsers it highlights just fine while editing, and on others it doesn't.

therealsujitk

tankerkiller125 While editing it does, but when the post is published it doesn't get highlighted until the page is reloaded.

Kylo

therealsujitk same thing happens on Firefox 🤔