How to change syntax highlighting

therealsujitk

tankerkiller125 While editing it does, but when the post is published it doesn't get highlighted until the page is reloaded.

Kylo

therealsujitk same thing happens on Firefox 🤔

JoshyPHP

There's a bug in Blink that prevents scripts created by a DocumentFragment from being executed, that's why highlight.js doesn't get loaded in preview mode. There used to be a workaround for it but it stopped working some time ago. I filed a bug for it in 2013 and a fix was proposed in 2019 but never implemented in Blink. Firefox works fine as far as I can tell.

I'll look into implementing another workaround.

therealsujitk

JoshyPHP I worked on Firefox Ubuntu when I noticed this bug.

JoshyPHP

Firefox 73 works fine for me on the nightly site at https://nightly.flarum.site/

therealsujitk

JoshyPHP even I use Firefox 73. Can you try posting some random code like this here.

var1 = 'Hello'
var2 = 'World!'

print(var1 + var2)

The preview gets highlighted, but on clicking post reply it doesn't show any highlighting unless the page is reloaded.
Even after the page is reloaded, if you go back to all discussions and come back here, reloading is required again.

JoshyPHP

Oh, I haven't tested highlighting outside of preview so it's possible that part doesn't work on any browser. I don't know what happens after the post is previewed and I don't control that part of the code so I can't really debug it.

therealsujitk

JoshyPHP Alright. The preview works great, outside the preview is where the bug is...
@tankerkiller125, can you look into this bug?

JoshyPHP

Actually I thought about it and the syntax highlighting is only triggered during preview and the first time the page is loaded, that's probably why it doesn't re-run the syntax highlighting when a new post is added. I'll see what I can do about it.

therealsujitk

JoshyPHP Awesome!

JoshyPHP

I published a new version of the library with a new workaround for the Blink issue and a new version of the [code] BBCode that should trigger highlighting even when the content is added to the page via JavaScript DOM manipulation.

I think the beta demo has already picked it up because all of the syntax highlighting worked on Chrome when I tested it. I haven't tried with Firefox but I expect it to work fine.

tankerkiller125

JoshyPHP If it's a minor revision then beta may have picked it up and in theory people can update to it via composer update

therealsujitk

JoshyPHP Tested on beta.flarum.site. It works perfectly!

Kylo

JoshyPHP i'm working on the Diff extension and need to show rendered post in a modal. Full post content lies in db (not the xml version) and i'm simply rendering it using render() after parsing but code highlighting is not working as expected. Is there anything i can do to solve it? Any suggestions?

Kylo

JoshyPHP whops, I thought I've updated 😅 v2.3.7 did the magic.

JoshyPHP that should trigger highlighting even when the content is added to the page via JavaScript DOM manipulation

Okay I need to learn it, I've taken a look at the code and I don't really understand. Is there a way for extensions which are using custom BBCodes to achive this?

clarkwinkelmann

tankerkiller125 it's safer to run composer update with some more arguments in order to not update everything at once. I believe you could do something like (written out of the top of my head, untested) composer update s9e/text-formatter to update just the text formatter, or composer update flarum/core --with-all-dependencies to update core and all its dependencies.

Running update without arguments will also update all extensions immediately and could make it harder to debug an issue if something breaks after the command.

therealsujitk

clarkwinkelmann I believe you could do something like (written out of the top of my head, untested) composer update s9e/text-formatter to update just the text formatter.

Tested, works!

Littlegolden

JoshyPHP This method seems doesn't work in Flarum-beta.12.

therealsujitk

Littlegolden JoshyPHP This method seems doesn't work in Flarum-beta.12.

It does work. I changed my theme to 'default'. Originally it was the GitHub theme. The thing is Flarum works well only with the default theme because half the theme's css is inbuilt in the site itself (like the beckground color of <pre> and all that). I've been trying to make an extension to allow other themes but haven't been that successful plus I'm short on time. So if you try changing it to a theme like 'dracula', you'll get some of the text having the dracula theme and some having the default theme.

therealsujitk

Littlegolden I just built this extension: highlight.js. You might find it helpful.

JoshyPHP

Kylo Make sure you have updated your dependencies recently and check your browser's console for errors. If that doesn't work, post the HTML here.

Also note that depending on how you insert the post's HTML in the page, browsers may not execute scripts.

« Previous Page Next Page »