Mithril Related Issues on PostStream Items

Kylo

It's me again! I finally wrote my "Diff" extension (which adds a "post revision history" feature) but I have two issues waiting to be solved.

Here's the GitHub link for the extension: Diff for Flarum

1-) Dropdown list is not showing up immediately after clicking the "Edited" button.

When i click the "Edited" button, i expect dropdown list to be show up with loading indicator (as in notification list) but it seems it is waiting for response from /api/diff/{postId} and initialize the list after that. Here's the related lines:

Create a list when "Edited" button clicked:
https://github.com/the-turk/flarum-diff/blob/b68c0b06438a13b964b76e2485e28f16631501eb/js/src/forum/components/DiffDropdown.js#L48
Preparing the dropdown list:
https://github.com/the-turk/flarum-diff/blob/b68c0b06438a13b964b76e2485e28f16631501eb/js/src/forum/components/DiffDropdown.js#L20
Set loading state in load() function before the request from URL:
https://github.com/the-turk/flarum-diff/blob/b68c0b06438a13b964b76e2485e28f16631501eb/js/src/forum/components/DiffList.js#L88

What am i doing wrong? Why it is not working as i expected?

2-) Dropdown list is not showing up on [deleted] user's post.

This is a strange one. I tracked it and it's working all the way up to the load() function (see above for the related line), requesting data from /api/diff/{postId} and returns 200 OK response but the list is not showing up. I tried with multiple [deleted] accounts with no luck.

clarkwinkelmann

Kylo this sounds like a SubtreeRetainer related issue.

I can't link to any example right now, but you'll need to tell the post that it must be redrawn when you change some of your data. To improve performance, post entries are not redrawn everytime by default.

Kylo

clarkwinkelmann i already did that for issue #1

https://github.com/the-turk/flarum-diff/blob/b68c0b06438a13b964b76e2485e28f16631501eb/js/src/forum/components/DiffList.js#L89

but it's just not working and waiting for the response. I see that NotificationList does the same thing also:

https://github.com/flarum/core/blob/bf8bc0222f6efb1f014fc264129b44d3832cb5d9/js/src/forum/components/NotificationList.js#L160

and it's working flawless.

Edit: after looking into SubtreeRetainer i think i pick the wrong fuction, will dive into core now.

Can't think any solutions for issue #2 though.

Kylo

clarkwinkelmann it turned out i wasn't calling m.redraw(); for post items at all! i fixed all of my issues by calling this line in button's onclick event:

post.save({ isHidden: false }).then(() => m.redraw());

it's super tricky but working and i am wondering what do you think about this approach? Are there any other ways to say post item to redraw itself?

clarkwinkelmann

Kylo nice to see it solved! Your approach seems correct.

After an onclick / onchange / oninput event, Mithril always redraws automatically. But if you start an async process in there, like m.request / app.request / model.save / app.store.find, you will need to call m.redraw() inside the then() callback.

Kylo

clarkwinkelmann Thank you so much for the info!

love_from_india

Great Job Kylo and clarkwinkelmann