rob006 okay now i need some help to decide a column type for compressed revisions. Since flarum uses MEDIUMTEXT for a post, i'm not sure if LONGBLOB will be enough to hold compressed data.

      Kylo LONGBLOB can store 4GB of data - you won't be able to work with such volumes way before you hit the column size limit. Even MEDIUMBLOB may be enough - it can store over 16MB of data which should be about 300 MB of text after decompression. I didn't check how do you handle decompression, but if you store the whole decompressed text in PHP variable, 300MB may be already too much for most environments.

      • Kylo replied to this.

          rob006 i am using PHP's \gzcompress('', -1) and \gzuncompress() functions fyi.

            After few tests I must say that dropdown with list of revisions is really confusing. If I create a post, and then edit it once, I have 2 revisions: original posts and version after edit. On GitHub in dropdown you have two entries, where first is labeled as "created" and displays diff between nothing and original post:

            In your plugin there is only one entry:

            And when I click it, there is no "revert" option available (it seems to be a bug). Since you switched from "diff approach" to "revisions approach", wouldn't be better to display revisions in similar way as GitHub? Then it should be more clear what is the target of "revert/rollback" and "delete revision" features.

            • Kylo replied to this.

              rob006 That was my intention to do so. I think there is no point to show the original post in the dropdown list because well, just look at the first revision for the original post?

              rob006 And when I click it, there is no "revert" option available (it seems to be a bug).

              this is the same question which @jordanjay29 asked before. See my answer Kylo

                      Kylo That was my intention to do so. I think there is no point to show the original post in the dropdown list because well, just look at the first revision for the original post?

                      How can I look at first revision? In my example (post with 1 edit) there are 2 revisions, but you're displaying 1 entry. It's clear that this is not a list of revisions, but a list of diffs between revisions. And if it is a diff, it is no longer clear which revision will be used for "rollback" or "delete" action - will it be revision before or after the change?

                      Kylo this is the same question which @jordanjay29 asked before. See my answer Kylo

                      Sorry, I don't get your answer. Why I can't revert last edit and restore original content of post? It seems to be valid use case for me.

                      • Kylo replied to this.

                            rob006 And if it is a diff, it is no longer clear which revision will be used for "rollback" or "delete" action - will it be revision before or after the change?

                            That is the real question that we need to find answers.

                            Kylo Should it be "revert" or "rollback"? If i go with revert than the post's content should be replaced with the revision's old content. If it is rollback than it sounds more reasonable to jump between revisions (so post's content will be replaced with the revision's new content).

                                rob006 Okay your points makes sense. Dropdown list should include all revisions and rollback should change one revision to another. I'll call the original post as revision 1 so when one rollbacks to revision 1, it'll revert the changes all the way to the original post then it'll be treated as new edit. Sounds good?

                                    Next version will be tagged as stable and i'll drop it in 2-3 weeks because i have another priorities for now. Sadly, it'll delete previous revisions for the last time, because i did some modifications on the DB side among other things. I also noticed some bugs on renderers (especially with long diffs), so sorry if you encounter one of them. It's up to you to wait for the stable one. Thanks for your patience & comprehension.

                                    12 days later

                                    Can we change the box size? just like Windows Form? Right now the view box is too small... can only see a few contents...
                                    image.png

                                    • Kylo replied to this.
                                      5 days later

                                      theportablegeek Yeah, just saw that but I won't support it. Because it seems pointless to put effort into it, we all already have an username on Flarum but that extension adds a secondary username called nickname. If you're not happy with your username what's the point of covering it with a nickname? What if I'm not happy with my nickname either? Should I cover it with a secondary nickname, too? I recommend you to use Username Request by FriendsOfFlarum instead.

                                          Kylo Totally makes sense - and glad I was able to figure out what was going on 😄

                                          Happy to drop the Nickname extension for this awesome extension - especially with the planned changes!