Diff for Flarum

Kylo

rob006 That was my intention to do so. I think there is no point to show the original post in the dropdown list because well, just look at the first revision for the original post?

rob006 And when I click it, there is no "revert" option available (it seems to be a bug).

this is the same question which @jordanjay29 asked before. See my answer Kylo

rob006

Kylo That was my intention to do so. I think there is no point to show the original post in the dropdown list because well, just look at the first revision for the original post?

How can I look at first revision? In my example (post with 1 edit) there are 2 revisions, but you're displaying 1 entry. It's clear that this is not a list of revisions, but a list of diffs between revisions. And if it is a diff, it is no longer clear which revision will be used for "rollback" or "delete" action - will it be revision before or after the change?

Kylo this is the same question which @jordanjay29 asked before. See my answer Kylo

Sorry, I don't get your answer. Why I can't revert last edit and restore original content of post? It seems to be valid use case for me.

Kylo

rob006 And if it is a diff, it is no longer clear which revision will be used for "rollback" or "delete" action - will it be revision before or after the change?

That is the real question that we need to find answers.

Kylo Should it be "revert" or "rollback"? If i go with revert than the post's content should be replaced with the revision's old content. If it is rollback than it sounds more reasonable to jump between revisions (so post's content will be replaced with the revision's new content).

Kylo

rob006 Okay your points makes sense. Dropdown list should include all revisions and rollback should change one revision to another. I'll call the original post as revision 1 so when one rollbacks to revision 1, it'll revert the changes all the way to the original post then it'll be treated as new edit. Sounds good?

rob006

Kylo Yeah, sounds good.

Kylo

Next version will be tagged as stable and i'll drop it in 2-3 weeks because i have another priorities for now. Sadly, it'll delete previous revisions for the last time, because i did some modifications on the DB side among other things. I also noticed some bugs on renderers (especially with long diffs), so sorry if you encounter one of them. It's up to you to wait for the stable one. Thanks for your patience & comprehension.

Littlegolden

Can we change the box size? just like Windows Form? Right now the view box is too small... can only see a few contents...

Kylo

Littlegolden i'm planning to drop tabular view on v2 and implement a new layout like Notion's version history so it'll be looking like this:

https://www.notion.so/Version-history-eec3af1f5bc64ba0a712ee5794e12a9c

Until that, i think you can force the modal to be large with using .Modal--large class

Littlegolden

Kylo Looks nice!

theportablegeek

Kylo This is amazing 🙂

theportablegeek

HD3D Did the update solve this for you? I am still running into the issue....

Littlegolden

theportablegeek Yeah, that issur has been fixed.

Yalfoosh

theportablegeek I still have the issue as well, we have to wait until the stable release I guess 🙂

theportablegeek

Yalfoosh not sure if you are running the Nickname Changer Extension but if you are - disable it and it should work for you!

Kylo

theportablegeek Yeah, just saw that but I won't support it. Because it seems pointless to put effort into it, we all already have an username on Flarum but that extension adds a secondary username called nickname. If you're not happy with your username what's the point of covering it with a nickname? What if I'm not happy with my nickname either? Should I cover it with a secondary nickname, too? I recommend you to use Username Request by FriendsOfFlarum instead.

theportablegeek

Kylo Totally makes sense - and glad I was able to figure out what was going on 😄

Happy to drop the Nickname extension for this awesome extension - especially with the planned changes!

Kylo

`1.0.0`

Diff Collage

From now on, I won't touch your revisions again (unless a vital issue reported 🤐).

I've changed lots of things. See changelog for full list. Here are some important notes:

This extension conflicts with dem13n/nickname-changer package. Use fof/username-request instead.

If you're using the-turk/flarum-edit-notifications extension, you should update it to v0.1.4

composer update the-turk/flarum-edit-notifications:0.1.4

New layout may not work for some browsers. Click here to see supported ones (including IE10+).

You need to update s9e/text-formatter to v2.3.7 for syntax highlighting in revision previews (skip this step if you didn't update flarum/core to beta 12 yet).

composer update s9e/text-formatter:2.3.7

There are new lines & few changes for translators. You can check the en.yml's history on GitHub to find out what's been changed (it's a bit much, sorry for that).

Updating

It's a fresh start so, get rid of the previous version and install the new one. 😏

composer remove the-turk/flarum-diff
composer require the-turk/flarum-diff:1.0.0
php flarum migrate
php flarum cache:clear

theportablegeek

🙌

Littlegolden

seems the bug comes back

Kylo

Littlegolden I can't reproduce it, there might be an another confliction.

Could you check https://yourflarum.org/api/diff?id={post-id} ? You can get the post's id using mentions (@Littlegolden#125160 (post-id: 125160)).

Littlegolden

Kylo okay, my bad, I didn't close the NickName Changer plugin.
Now find another problem, ToolTip won't disappear after clicking the button (unless the mouse hover once)

« Previous Page Next Page »