Scheduling multiple tasks (using FoF\Console)

iPurpl3x

Hi fellows,
A few months ago I wrote an extension that runs scheduled tasks using the exact same implementation as the Bazaar extension.
Today I am wring another extension that also needs to run scheduled tasks but I have run into a problem:
When I add a callback to the resolving event of the app Container for the Schedule class, only one of my extensions will actually fire the callback, the other one seems to be overridden...
Here is the code that I use to add a callback :

$this->app->resolving(Schedule::class, function (Schedule $schedule) {
    // Schedule the command here as described in Laravel docs
});

Any idea on how I could do something about this problem ? I feel like this is the way a Laravel Container works and I can only have one callback for the resolving event of a specific class... I also looked into the source code of Laravel and this is how it seems to be.

luceos

iPurpl3x This is probably caused by resolving the Schedule class too early from IOC (eg in your extend.php directly or in an extender). Can you post more of your code so that I can assist?

iPurpl3x

luceos OK so what I have is (I removed imports and unrelated code) :
extend.php

return [
	function (Application $app) {
		$app->register(Providers\ConsoleProvider::class);
		$events = $app['events'];
		$events->subscribe(Listeners\RegisterConsoleCommand::class);
	}
];

ConsoleProvider.php

class ConsoleProvider extends AbstractServiceProvider
{
	public function register()
	{
		if (!defined('ARTISAN_BINARY')) {
			define('ARTISAN_BINARY', 'flarum');
		}
		// Force registering the Schedule as singleton.
		$this->app->register(Console::class); // FoF\Console\Providers\ConsoleProvider

		$this->app->resolving(Schedule::class, function (Schedule $schedule) {
			$schedule->command('post_scheduled_posts')
				->everyMinute()
				->withoutOverlapping();
		});
	}
}

RegisterConsoleCommand.php

class RegisterConsoleCommand
{
	public function subscribe(Dispatcher $events)
	{
		$events->listen(Configuring::class, [$this, 'add']);
	}
	public function add(Configuring $event)
	{
		if ($event->app->bound(Schedule::class)) {
			$event->addCommand(PostScheduledPosts::class);
		}
	}
}

iPurpl3x

@luceos I fugured that I could implement my service provider in another way :

class ConsoleProvider extends AbstractServiceProvider
{
	public function boot()
	{
		$schedule = $this->app->make(Schedule::class);

		$schedule->command('post_scheduled_posts')
			->everyMinute()
			->withoutOverlapping();
	}
}

This way I don't need make a callback for the resolving event.

Is there a reason why this was not done like this in the Bazaar extension ?

iPurpl3x

iPurpl3x By doing this, it seems like the scheduled command isn't executed at all.

iPurpl3x

After debugging I found out the the fact that I would call
$this->app->register(Console::class); // FoF\Console\Providers\ConsoleProvider
multiple times cause my initial issue because the Schedule::class singleton would be overridden the second time...

@luceos Now I am wondering how import that is? Could I somehow verify if I need to register the FoF\Console\Providers\ConsoleProvider?

luceos

iPurpl3x there's an extender in the Console package called EnableConsole, from your findings it makes sense to have that extender check whether the given Provider was registered, before calling it again; that would solve it globally, right?

iPurpl3x

luceos Thanks, this solved it !