"Argument 1 passed to..." error after upgrading from beta 7.

holyfuzz

I'm trying to upgrade my Beta 7 installation of Flarum to Beta 11, using these instructions as recommended to me by @jordanjay29 on Discord. I went through all the steps in those instructions with no obvious problems, but when I try to actually view my forum in my browser (after updating, migrating my DB, and clearing the cache), I get this error:

Argument 1 passed to Flarum\Formatter\Event\Rendering::__construct() must be an instance of s9e\TextFormatter\Renderer, instance of __PHP_Incomplete_Class given, called in /var/www/forum.cosmoteer.net/vendor/flarum/core/src/Formatter/Formatter.php on line 78

The error appears to be identical to this error, but the solution that seemed to work for the OP in that thread (deleting the storage/formatter and storage/cache folders, recreating them, setting permissions on them, and clearing the cache with php flarum cache:clear) does not solve the problem for me.

To make absolutely sure that Flarum/php can write to those folders, I chmod 777 on them...

drwxrwxrwx 3 walt www-data  4096 Feb 13 21:11 cache
drwxrwxrwx 2 walt www-data  4096 Feb 13 21:11 formatter
drwxrwxr-x 2 walt www-data 12288 Feb 13 20:52 less
drwxrwxr-x 2 walt www-data  4096 Feb 13 21:23 locale
drwxrwxr-x 2 walt www-data  4096 Feb 13 20:49 logs
drwxrwxr-x 2 walt www-data  4096 Feb 13 19:31 sessions
drwxrwxr-x 2 walt www-data  4096 Feb 14 07:22 tmp
drwxrwxr-x 2 walt www-data  4096 Feb 13 20:49 views

... but no luck.

Note that a fresh install of Flarum works totally fine. It's only after importing and migrating the DB from my old Beta 7 install that I get this error.

Anyone have any idea what's going on?

Thanks!

clarkwinkelmann

holyfuzz can you share the output of php flarum info so we can see your extension list ? Maybe you have one that's not compatible with the current beta.

At first it would look like old data loaded from cache to me, but if you deleted the storage/formatter directory then it can't be that anymore. Is there any newly created file inside storage/formatter after you make a request or does it stay empty ?

holyfuzz

clarkwinkelmann can you share the output of php flarum info so we can see your extension list ? Maybe you have one that's not compatible with the current beta.

No 3rd-party extensions, I disabled them all and then re-installed Flarum from scratch:

Flarum core 0.1.0-beta.11.1
PHP version: 7.2.13-1+ubuntu16.04.1+deb.sury.org+1
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, sodium, session, standard, mysqlnd, PDO, xml, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, json, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, Zend OPcache
+----------------------+----------------+--------+
| Flarum Extensions    |                |        |
+----------------------+----------------+--------+
| ID                   | Version        | Commit |
+----------------------+----------------+--------+
| flarum-approval      | v0.1.0-beta.8  |        |
| flarum-bbcode        | v0.1.0-beta.8  |        |
| flarum-emoji         | v0.1.0-beta.10 |        |
| flarum-flags         | v0.1.0-beta.10 |        |
| flarum-likes         | v0.1.0-beta.9  |        |
| flarum-lock          | v0.1.0-beta.9  |        |
| flarum-markdown      | v0.1.0-beta.10 |        |
| flarum-mentions      | v0.1.0-beta.10 |        |
| flarum-pusher        | v0.1.0-beta.9  |        |
| flarum-sticky        | v0.1.0-beta.9  |        |
| flarum-subscriptions | v0.1.0-beta.9  |        |
| flarum-suspend       | v0.1.0-beta.10 |        |
| flarum-tags          | v0.1.0-beta.11 |        |
+----------------------+----------------+--------+

clarkwinkelmann Is there any newly created file inside storage/formatter after you make a request or does it stay empty ?

It's empty:

walt@cosmoteer-test:~/www/forum.cosmoteer.net/storage/formatter$ ls -al
total 8
drwxrwxrwx  2 walt www-data 4096 Feb 13 21:11 .
drwxrwxr-x 10 walt www-data 4096 Feb 13 21:10 ..

Thanks for your help!

luceos

Please post the contents of your composer.json file.

holyfuzz

luceos Please post the contents of your composer.json file.

Sure:

walt@cosmoteer-test:~/www/forum.cosmoteer.net$ cat composer.json
{
    "name": "flarum/flarum",
    "description": "Delightfully simple forum software.",
    "type": "project",
    "keywords": ["forum", "discussion"],
    "homepage": "https://flarum.org/",
    "license": "MIT",
    "authors": [
        {
            "name": "Toby Zerner",
            "email": "toby.zerner@gmail.com"
        },
        {
            "name": "Franz Liedke",
            "email": "franz@develophp.org"
        }
    ],
    "support": {
        "issues": "https://github.com/flarum/core/issues",
        "source": "https://github.com/flarum/flarum",
        "docs": "https://flarum.org/docs/"
    },
    "require": {
        "flarum/core": "^0.1.0",
        "flarum/approval": "^0.1.0",
        "flarum/auth-facebook": "^0.1.0",
        "flarum/auth-github": "^0.1.0",
        "flarum/auth-twitter": "^0.1.0",
        "flarum/bbcode": "^0.1.0",
        "flarum/emoji": "^0.1.0",
        "flarum/lang-english": "^0.1.0",
        "flarum/flags": "^0.1.0",
        "flarum/likes": "^0.1.0",
        "flarum/lock": "^0.1.0",
        "flarum/markdown": "^0.1.0",
        "flarum/mentions": "^0.1.0",
        "flarum/pusher": "^0.1.0",
        "flarum/statistics": "^0.1.0",
        "flarum/sticky": "^0.1.0",
        "flarum/subscriptions": "^0.1.0",
        "flarum/suspend": "^0.1.0",
        "flarum/tags": "^0.1.0"
    },
    "config": {
        "preferred-install": "dist",
        "sort-packages": true
    },
    "minimum-stability": "beta",
    "prefer-stable": true
}

luceos

delete vendor and composer.lock then try installing again using composer install --prefer-dist -a

holyfuzz

luceos delete vendor and composer.lock then try installing again using composer install --prefer-dist -a

Done, but I'm still getting the error.

luceos

holyfuzz how much disk space do you have left?

holyfuzz

luceos how much disk space do you have left?

About 20 GB.

holyfuzz

Just a reminder in case it's relevant: A fresh Flarum install works fine, but if I then point that fresh install to my old DB and run migrate on it, that's when I start getting the error. Could there maybe be some leftover data in my DB from some old extensions that is causing the error, or something like that?

holyfuzz

Bump. Anyone have any more ideas for what might be going wrong here? Thanks!

luceos

Does running php flarum cache:clear throw any errors?

holyfuzz

luceos Nope, it just prints Clearing the cache... in green and nothing else.

luceos

holyfuzz sending you an email

holyfuzz

For anyone else with this issue, here's what the problem was for me and the very easy solution. (Thanks to @luceos for help verifying that my database was NOT the problem.)

The issue that php flarum cache:clear fails silently if it runs into permissions problems when deleting cache files. On my server, Flarum saves cache files using the www-data user, which php flarum cache:clear can't delete when I run it under my regular SSH user, leaving the cache only partially-cleared and my Flarum install non-operational.

So if you run into this problem, try simply running sudo flarum cache:clear (or whatever command that is required to run php with elevated permissions on your OS/distro), which solved the problem for me and got my forum working again.

jordanjay29

holyfuzz I'm really glad this got resolved. Can I mark it as such?

holyfuzz

jordanjay29 Yes! I am now happily on Beta 11 and going through upgrading my extensions and finding new ones. 😃