Edit Notifications

Kylo

HD3D thank you! Feel free to report any issues, i'll look into it asap.

Littlegolden

It seemed to notify something that didn't happen at all. . .

luceos

@Kylo just out of curiosity, why did you even build this extension? What was the reason for it?

Littlegolden

luceos I think, many times our post has added new content. Or the content of a post is a software instruction, but after a few years, we added a sentence "This tutorial is no longer applicable to the new version after 2019". Or the forum’s user guidelines have been updated. I think many webmasters want to let users know about these new dynamics.

Kylo

Littlegolden it's a known issue for 0.1.1, update to 0.1.2

luceos you may call it 'perfectionism'. There were many times when i make an addition to my posts and wanted to scream "hey, look at my post again i've stated something wrong" or "here's the better statement, now it's completed". There also were times when i reply a post and it wasn't the post that i replied anymore. I don't want to disable it after first reply because it's a 'need' in my opinion. Of course it seems very unnecessary for the core but it's just an extension, installing it or not is up to users. Mostly my extensions are there for my needs and i'm sharing them if anyone facing the same situation or sharing the same thoughts as i'm. Apart from these, i just wanted to play with notifications & queues for preparation to bigger extensions 😄

luceos

Kylo Oh I never meant to say this is an unnecessary feature nor worthy of being an extension. I firmly believe that extensions are meant to solve your own (or client) needs.

luceos The most common reason for someone to build an extension is to solve an issue oneself has.

I was just curious whether this was initiated from a user perspective or moderative/admin one. You explained it perfectly, thank you.

Kylo Apart from these, i just wanted to play with notifications & queues for preparation to bigger extensions

Please understand that from beta 13 and up, all notifications using the NotificationSyncer (core notification functionality) will be pushed to a queue by default, no need to do so manually.

Kylo

luceos it's great to hear that! Sorry if i sounded touchy (squeamish?) by the way it's hard for me to express my emotions in english since i have no one to practice with.

[deleted]

Kylo by the way it's hard for me to express my emotions in english since i have no one to practice with

Are you kidding me ? Your English is better than some "native speakers" I know 🙂

Kylo

`0.1.3`

Add beta 12 compatibility.
Add the-turk/flarum-diff rollback support.

Kylo

`0.1.4`

Add the-turk/flarum-diff v1.0.0 support.
Note that previous versions of this extension will conflict with the diff v1.0.0
Update dependencies.

`0.1.5`

Update version constraints for Flarum 0.1.0-beta.13.

Kylo

This extension conflicts with some recently updated FoF extensions. As I'm using some kind of "Post Bookmarking" extension on my forum, I won't continue developing the "Edit Notifications" anymore.

So this extension is abandoned. @jordanjay29 could you also mark this as an Incompatible one?

Kylo

Thanks for the report, see Kylo

asdfasfdsafas

Hi, I am hosting a private forum for a bunch of philosophy students and thus we edit and edit and edit (wake half way asleep at 4 am etc).... I realize we really need something like this and get here from search engine.

I am not familiar with php (or fof extensions codebase), so I would be really grateful if you could share information on what exactly are the conflicts and if you have any suggestion, if I want to fork it and make it work again. I am running 1.8.9 at the moment, with all the fof extensions you mentioned on github readme.

clarkwinkelmann

asdfasfdsafas the conflicts are irrelevant at this point. This extension was written for Flarum beta. All conflicting extensions that still exist will have been rewritten for Flarum 1.x since then.

I don't think there's anything to be gained by re-using the code from this extension, it'll be quicker to re-write the extension from scratch.

Looking at the source code it seems to just be a set of event listeners and a notification tied to a user preference. All this can still be done in Flarum 1.x, but the syntax has changed a bit since Flarum beta.

asdfasfdsafas

clarkwinkelmann Thank you for your reply! I'll try to learn the changes and re-write it then.