Developer Scratchpad

Ralkage

Funny how I didn't see this until I saw your updates on GitHub... 🤔

Gonna give this a spin! 😃

clarkwinkelmann

Ralkage it seems like a few people missed my new extensions. I did dump like 5 new ones in 2 days. Though most of them were on Packagist since more than a week but were just not finalized. This one was just a "side project" alongside the other exts made for clients 😂

Ralkage

@clarkwinkelmann getting the following error when trying to hit the compile button on a new or existing scratchpad entry:

Scratchpad Error

I assume this is related to the 4th requirement on your list? Not sure how to get that going actually since I'm using WAMP.

tankerkiller125

Ralkage Install the NodeJS package for windows. That should do it I think.

clarkwinkelmann

Ralkage can you inspect the request in the network tab and copy the response ? It's a POST request to an url ending with /compile.

It's supposed to return a JSON object and it's supposed to have that key, even if a node error occurred.

Ralkage

tankerkiller125 already have Node.js v12.16.1 installed 😉

Ralkage

clarkwinkelmann Stack trace returned below:

[2020-03-19 19:38:20] production.ERROR: InvalidArgumentException: File not found at path: C:\wamp64\www\fb11.local\vendor\clarkwinkelmann\flarum-ext-scratchpad\src/js/dist/admin.js in C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Compiler\Source\FileSource.php:27
Stack trace:
#0 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Compiler\Source\SourceCollector.php(25): Flarum\Frontend\Compiler\Source\FileSource->__construct('C:\\wamp64\\www\\f...')
#1 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Extend\Frontend.php(93): Flarum\Frontend\Compiler\Source\SourceCollector->addFile('C:\\wamp64\\www\\f...')
#2 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Assets.php(98): Flarum\Extend\Frontend->Flarum\Extend\{closure}(Object(Flarum\Frontend\Compiler\Source\SourceCollector), NULL)
#3 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Compiler\RevisionCompiler.php(111): Flarum\Frontend\Assets->Flarum\Frontend\{closure}(Object(Flarum\Frontend\Compiler\Source\SourceCollector))
#4 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Compiler\RevisionCompiler.php(69): Flarum\Frontend\Compiler\RevisionCompiler->getSources()
#5 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Content\Assets.php(58): Flarum\Frontend\Compiler\RevisionCompiler->commit()
#6 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Content\Assets.php(48): Flarum\Frontend\Content\Assets->commit(Array)
#7 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Frontend.php(63): Flarum\Frontend\Content\Assets->__invoke(Object(Flarum\Frontend\Document), Object(Laminas\Diactoros\ServerRequest))
#8 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Frontend.php(55): Flarum\Frontend\Frontend->populate(Object(Flarum\Frontend\Document), Object(Laminas\Diactoros\ServerRequest))
#9 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Frontend\Controller.php(32): Flarum\Frontend\Frontend->document(Object(Laminas\Diactoros\ServerRequest))
#10 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\RouteHandlerFactory.php(38): Flarum\Frontend\Controller->handle(Object(Laminas\Diactoros\ServerRequest))
#11 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\DispatchRoute.php(65): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#12 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\DispatchRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#13 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Admin\Middleware\RequireAdministrateAbility.php(26): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#14 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Admin\Middleware\RequireAdministrateAbility->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#15 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\SetLocale.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#16 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#17 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\CheckCsrfToken.php(23): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#18 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#19 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\AuthenticateWithSession.php(32): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#20 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#21 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\RememberFromCookie.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#22 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#23 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#25 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#26 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#27 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Middleware\HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#28 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#29 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#30 C:\wamp64\www\fb11.local\vendor\middlewares\request-handler\src\RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#31 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#32 C:\wamp64\www\fb11.local\vendor\middlewares\base-path-router\src\BasePathRouter.php(97): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#33 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#34 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Middleware\OriginalMessages.php(42): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#35 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#36 C:\wamp64\www\fb11.local\vendor\middlewares\base-path\src\BasePath.php(53): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#37 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\Next.php(61): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#38 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(84): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#39 C:\wamp64\www\fb11.local\vendor\laminas\laminas-stratigility\src\MiddlewarePipe.php(73): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#40 C:\wamp64\www\fb11.local\vendor\laminas\laminas-httphandlerrunner\src\RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#41 C:\wamp64\www\fb11.local\vendor\flarum\core\src\Http\Server.php(42): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#42 C:\wamp64\www\fb11.local\public\index.php(22): Flarum\Http\Server->listen()
#43 {main}

I feel like this is one of those Windows related issues...paths? 🤦‍♂️

clarkwinkelmann

Ralkage is this the error generated when you hit /scratchpads/{id:[0-9]+}/compile ? That doesn't sound like the same thing. What's the response status and body for the /scratchpads/{id:[0-9]+}/compile request ?

The error you copied is related to Flarum being unable to load the extension own admin.js file. Which is imported like for any other extension. That error must have happened while loading either the forum or admin page, but would mean you are unable to access Flarum at all.

EDIT: the problem in that error is the src/js part, not the path delimiter. vendor\clarkwinkelmann\flarum-ext-scratchpad\src/js/dist/admin.js. I have no idea how that src got in there, it's not supposed to be there.

Ralkage

clarkwinkelmann I'm not sure how it got there either 😅 I'm using Chrome btw and this is the response that I got which is essentially the error I posted earlier:

Edit: Response status is 200 btw 🙈

Edit 2: Actually, I see the differences now, wow, two separate errors, this is the one from the response:

Warning: file_get_contents(C:\wamp64\www\fb11.local\public/../storage/scratchpad/dist/admin.js): failed to open stream: No such file or directory in C:\wamp64\www\fb11.local\vendor\clarkwinkelmann\flarum-ext-scratchpad\src\Controllers\CompileScratchpadController.php on line 51

clarkwinkelmann

Ralkage I suspected it would be a Warning or something like that.

Can you check whether the file exists when the request finishes ? Either it's a Windows issue if the file exists, or it's simply an error in my logic if the file can be absent.

Ralkage

clarkwinkelmann it does exist 🙈 (please ignore the directory name, I recently updated to b12)

clarkwinkelmann

Ralkage could you run a few commands for me ? I would test myself if I had a Windows computer at hand but that's not the case...

php -r "file_get_contents('C:\\wamp64\\www\\fb11.local\\public\\..\\storage\\scratchpad\\dist\\admin.js');"
php -r "file_get_contents('C:\\wamp64\\www\\fb11.local\\storage\\scratchpad\\dist\\admin.js');"

I'm trying to know whether the path delimiters are the issue, or something else like the ..

clarkwinkelmann

Well you lied to me 😛 I took your word for it and didn't watch the screenshot close enough.

Ralkage it does exist

Okay so the dist files don't exist. I'll try to find an explanation for that.

Ralkage

clarkwinkelmann

First command:

Warning: file_get_contents(C:\wamp64\www\fb11.local\public\..\storage\scratchpad
\dist\admin.js): failed to open stream: No such file or directory in Command lin
e code on line 1

Second command:

Warning: file_get_contents(C:\wamp64\www\fb11.local\storage\scratchpad\dist\admi
n.js): failed to open stream: No such file or directory in Command line code on
line 1

The JS never gets compiled so the dist folder and admin.js does not exist.

clarkwinkelmann

Ralkage I released version 1.0.1 which adds additional checks for the existence of the files.

I suspect you had an error inside the npm install command but it's lacking a proper error management. So it continues to the next command, which never reports "module build failed" because it probably fails to load webpack at all.

I should probably also look at the response code of each commands... But anyway, the new solution should at least give you access to the logs.

Ralkage

clarkwinkelmann can't help myself there, this extension is a mysterious beast on its own 😅

clarkwinkelmann I'll hit you up on the Discord's, I have spent the majority of my week confined WFH, I think I been lost my sanity days ago 🤯

Artuu

I had a problem. I got an error after compiling JS.
Probably because I'm holding a flarum on the disk of D: and not the system C:. I use the windows system.

Webpack output
'node_modules' is not recognized as an internal or external command,
operable program or batch file.

NPM output
NPM did not run

So I decided to fix it myself.
I changed that line to below and it worked.

$webpackOutput = shell_exec("cd $path && $path/node_modules/.bin/webpack --mode development --config node_modules/flarum-webpack-config/index.js 2>&1");

I don't know if you shouldn't do the same with the --config on the same line, but I doubt it.

Anyway, I'm counting on the next release soon to correct this error. I hope I helped someone else with this 😉

clarkwinkelmann

Artuu we've had some discussions with @Ralkage about Windows compatibility and I'm a bit unsure whether everything we discovered would apply to all version of Windows or not.

The current version does not seem to work on Windows.

Because I have no Windows PC and have no wish at all to support Windows, I'm considering using Linux commands and provide a customization option for the command. It would be up to user to figure out the correct command for their system if the default doesn't work, and update it if I ever change it in the extension.

clarkwinkelmann

Version 1.1.0 released.

Now with the ability to customize the NPM and Webpack commands in case the default doesn't work on your system.

@Artuu @Ralkage this should be useful for you 😉

Also fixed an issue with the settings modal and added a translation for a previously hard-coded text.

Compatibility with beta 13 was silently pushed as 1.0.3 a few days ago.

clarkwinkelmann

Version 1.2.0 released.

This version is only compatible with Flarum beta 14.

This version also includes a new way of validating PHP and Less files. Now when saving the scratchpad, the code is temporarily loaded on the forum and two requests are made in the background to the forum homepage and to the admin homepage.

Not only does it cover syntax errors like before, it can now detect a wide range of import and extender issues before saving the code and locking you out of the forum. This new approach also solves an issue with the previous approach where creating classes and functions in the global namespace would create an error when the validation would re-run the same code in the same namespace, causing conflicts.

An option in the settings allows disabling this new feature. This might be needed if your server is unable to make requests to itself. But be careful as disabling this option greatly increases the likelyhood of saving invalid PHP and needing a trip to the database to fix the issue.