GIFs

ctml

Looks absolutely fantastic, thanks a lot for this!!

phloo

Set up with Tenor support and verified key.
Doesnt load correctly (Tenor logo missing) and if I use the search, I get an 400 error:
Invalid value at 'contentfilter' (type.googleapis.com/google.search.tenor.v1.ContentFilter.Enum), ""

There should be input fields for the auth code per API url
Giphy API Key: _____
Tenor API Key: _____

Otherwise you have to search them after switching the provider

therealsujitk

phloo I don't follow. From what you're telling me, I don't think you've configured it correctly in the admin panel. Did you disable and re-enable the extension? You can't use both providers together, for one they both require attributions.

phloo

therealsujitk I didn't mean to use both providers together. My suggestion to add an input field per GIF provider is just because you have to search for the credentials after you switch from one to another.

For the 400 bad request problem:
We use this extension flawlessly with Giphy. After the update I wanted to try out TENOR and changed the provider and API key. There was no info that we have to disable and renable the whole extension to switch providers.
Now the Tenor logo shows as intended but searching is still not possible
https://g.tenor.com/v1/search?key=XXXXXX&q=hello&contentfilter=&media_filter=minimal&limit=10

{
  "error": {
    "code": 400,
    "message": "Invalid value at 'contentfilter' (type.googleapis.com/google.search.tenor.v1.ContentFilter.Enum), \"\"",
    "status": "INVALID_ARGUMENT",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.BadRequest",
        "fieldViolations": [
          {
            "field": "contentfilter",
            "description": "Invalid value at 'contentfilter' (type.googleapis.com/google.search.tenor.v1.ContentFilter.Enum), \"\""
          }
        ]
      }
    ]
  }
}

Darkle

With the update the API key was deleted as you put in the note, even if the old string does not appear it is deleted from the database? or you have to do it manually?

therealsujitk

Darkle The old setting therealsujitk-gifs.giphy_api_key in the settings table can be safely deleted. I haven't done it (don't know if it's possible), so if you want to you'll have to manually do it. But if it is possible through code, I'll do it in a future release.

Darkle

therealsujitk Ok, got it, thanks so much for the clarification, awesome update!! 😄

therealsujitk

phloo There was no info that we have to disable and renable the whole extension to switch providers.

I mentioned that in the post above, you don't need to do it to switch providers, just after the update.

phloo searching is still not possible

From the query you've sent, it looks like the contentfilter value is missing for some reason. Try changing that value in the admin panel, save it, change it back, and save it again.

phloo

Changing the Content Filter multiple times, saving each time, helped. Tenor now works 🙂 Thank you!
Maybe you can take a look why it is not saved when switching providers.

therealsujitk

phloo I didn't face that issue, something might've gone wrong saving that setting to the database, or maybe it wasn't registered as something that changed so it didn't get saved. I can make it so it takes a default value if it wasn't saved in a future release.

rovvp

I updated flarum to 1.0.4 from beta16 the plugin is not really usable.

The main UI opens but selecting a GIF results in the JS errors as shown in the image above. I have refreshed the cache on the server as well as browser side.

{
"name": "flarum/flarum",
"description": "Delightfully simple forum software.",
"type": "project",
"keywords": [
"forum",
"discussion"
],
"homepage": "https://flarum.org/",
"license": "MIT",
"authors": [
{
"name": "Franz Liedke",
"email": "franz@develophp.org"
},
{
"name": "Daniel Klabbers",
"email": "daniel@klabbers.email",
"homepage": "https://luceos.com"
},
{
"name": "David Sevilla Martin",
"email": "me+flarum@datitisev.me",
"homepage": "https://datitisev.me"
},
{
"name": "Clark Winkelmann",
"email": "clark.winkelmann@gmail.com",
"homepage": "https://clarkwinkelmann.com"
},
{
"name": "Matthew Kilgore",
"email": "matthew@kilgore.dev"
},
{
"name": "Alexander (Sasha) Skvortsov",
"email": "askvortsov@flarum.org"
}
],
"support": {
"issues": "https://github.com/flarum/core/issues",
"source": "https://github.com/flarum/flarum",
"docs": "https://flarum.org/docs/"
},
"require": {
"askvortsov/flarum-rich-text": "",
"clarkwinkelmann/catch-the-fish": "¹.0",
"flarum/approval": "",
"flarum/bbcode": "",
"flarum/core": "¹.0",
"flarum/emoji": "",
"flarum/flags": "",
"flarum/lang-english": "",
"flarum/likes": "",
"flarum/lock": "",
"flarum/markdown": "",
"flarum/mentions": "",
"flarum/nicknames": "",
"flarum/pusher": "",
"flarum/statistics": "",
"flarum/sticky": "",
"flarum/subscriptions": "",
"flarum/suspend": "",
"flarum/tags": "",
"fof/analytics": "",
"fof/byobu": "¹.0.0-beta.7",
"fof/disposable-emails": "",
"fof/drafts": "",
"fof/filter": "",
"fof/follow-tags": "",
"fof/formatting": "",
"fof/frontpage": "",
"fof/ignore-users": "",
"fof/links": "",
"fof/oauth": "",
"fof/polls": "",
"fof/profile-image-crop": "",
"fof/reactions": "",
"fof/realtimelogin": "¹.0",
"fof/recaptcha": "",
"fof/share-social": "",
"fof/sitemap": "",
"fof/spamblock": "",
"fof/stopforumspam": "",
"fof/upload": "",
"fof/user-directory": "",
"fof/username-request": "",
"kilowhat/flarum-ext-audit-free": "",
"michaelbelgium/flarum-discussion-views": "⁷.0",
"therealsujitk/flarum-ext-gifs": "",
"v17development/flarum-seo": "*"
},
"config": {
"preferred-install": "dist",
"sort-packages": true
},
"prefer-stable": true
}

therealsujitk

rovvp someone else mentioned a similar issue therealsujitk/flarum-ext-gifs#15. Change your gif engine, save settings, change it again, save it again. That should fix your issue.

rovvp

therealsujitk

Thanks for the reply.

This appears to have fixed my issue. Thanks!

ctml

Extension appears to work, but when opening I get the "Oops! Something went wrong. Please reload the page and try again." due to a 500 error. I did disable/enable and try switching engines back and forth. Below are flarum logs from the event

Next Illuminate\Contracts\Container\BindingResolutionException: Target class [Therealsujitk\GIFs\Controllers\ListGIFController] does not exist. in /usr/share/nginx/flarum/vendor/illuminate/container/Container.php:875
Stack trace:
#0 /usr/share/nginx/flarum/vendor/illuminate/container/Container.php(754): Illuminate\Container\Container->build('Therealsujitk\\G...')
#1 /usr/share/nginx/flarum/vendor/illuminate/container/Container.php(692): Illuminate\Container\Container->resolve('Therealsujitk\\G...', Array)
#2 /usr/share/nginx/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(77): Illuminate\Container\Container->make('Therealsujitk\\G...')
#3 /usr/share/nginx/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(37): Flarum\Http\RouteHandlerFactory->resolveController('Therealsujitk\\G...')
#4 /usr/share/nginx/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#5 /usr/share/nginx/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))

therealsujitk

ctml Thanks for bringing this up, there's a typo in the class name because of which this error shows up.

010101

I get a 404 error saying the Giphy attribution logo can't be found. Anyone else? Also, I can't actually add GIFs to a post. I have the production API key. The GIF box shows and I can search for GIFs. When I click nothing happens. There's a JavaScript error in the console.

undefined is not an object (evaluating 'l.engine[0].toUpperCase')

Maybe a conflict with another extension... but, the error seems to point to a different extension every time I deactivate one. At first the error pointed to a line related to a hashtag extension. So I deactivated that one. Then the error pointed to the whisper private messaging extension. So, I deactivated that one. Then it pointed to another extension. So, it seems like this error will blame which ever extension happens to load at whatever time... Because of this odd error changing behavior (blaming every other extension) I feel like it's got to be this extension. And, of course if I deactivate this extension there are no errors.

Not that it's super helpful but in this image I have circled a GIF that I have clicked on. Nothing happens. And, I've circled the missing logo. I've cleared caches.

010101

The above issue I was having is related to database settings. I had to flip to tenor, save. Then flip back to giphy.

therealsujitk

010101 this issue has been opened on Github (therealsujitk/flarum-ext-gifs#15). I'll fix it as soon as I get some free time.

Darkle

My Tenor API key has been verified and ready to use for two days now, but I keep getting this errors, any ideas?

therealsujitk

Darkle yes, this is the same issue as therealsujitk/flarum-ext-gifs#15. You'll have to change your content filter, save changes, change it back & save it again.

I currently don't have access to my testing environment, so I can't fix this right now.

Darkle

therealsujitk It worked, I'm sorry I thought it was another error, when I switched from Giphy to Tenor it didn't work, that's why I thought it was something new. Thanks!

« Previous Page Next Page »