Flarum Categories

askvortsov

Yalfoosh Just to confirm, did you want to add a visual grid of followed tags to the following page, or just discussions from tags that are being already followed? The second doesn't seem like it would be too difficult to implement.

Yalfoosh Because I thought that you'd created a categories extension which is separate from tags which would've saved me of 2 extensions to write

Is there some kind of Categories functionality you were hoping to see that's separate from what tags provides? If so, I'm always open to feature requests for this extension. Can't guaruntee of course, but open to hearing!

Yalfoosh

askvortsov No, your extension looks amazing and I don't think there is anything it lacks in terms of looks; it has just the right amount of content.

I initially assumed that your extension is more-or-less an infinite depth tags system, which is a feature some of us would be happy to have. Obviously because of how Flarum is imagined, first and foremost to be light(weight), it's not a priority, hence the PR on the flarum's tags github is not added yet.

Ralkage

Absolutely LOVE this extension 💝 Koseki would be proud 😢 ⚰️

SezginYILDIRIM

Very good job, thank you. My modest suggestion is that categories are an option for them not to appear on the mobile version.

askvortsov

SezginYILDIRIM My modest suggestion is that categories are an option for them not to appear on the mobile version.

My apologizes, I'm not 100% sure what you mean by this. Could you possibly clarify?

Ralkage

Some suggestions if I may add:

For the part that shows the avatar of the latest discussion creator, can you make it so it's clickable and leads to the actual user profile?
- The same would go for the username after the start date of the discussion.
Lastly, may I suggest making the pubdate not have an anchor tag as well? (if I'm not mistaken, that whole section is basically wrapped in an anchor tag that leads to the latest discussion in that tag/section)

Edit: There also seems to be a bug when you click on the lastest discussion (from the LastDiscussionWidget) to which sends you to the tag/category instead of the discussion itself. If you try to go back from that page (using the back button on your browser) it will then send you to the actual discussion itself?

askvortsov

Ralkage Thank you, all have been fixed/implemented in v0.1.8! Also, I added a user card popover when hovering over avatar or username!

Ralkage

askvortsov UserCard doesn’t look right on mobile (using an iPhone X on Chrome) 😂

UserCard error

Nonetheless, thank you for your hard work and response time for fixes/improvements 🙏

Kylo

askvortsov i think he used the Google translator because that sentence can be perfectly translated back into Turkish. He's asking for an option to hide categories on mobile view. I don't know the reason though.

askvortsov

Ralkage

I've changed it to now show up on mobile (i don't see it adding too much there other than being distracting since the username itself works like a link). Also, fixed an issue with 'joined at' always showing 'invalid date'

Ralkage Nonetheless, thank you for your hard work and response time for fixes/improvements

Keep em coming! This seems to be a widely-wanted extension, so I might as well make it as good as I can!

Ralkage

askvortsov would you be able to separate the latest discussion widget links into their individual routes? Seems as if when I click even on the username it just brings me to the discussion rather than the profile (on mobile anyways) and there’s the off chance that it actually takes you the the users profile if you click the users username in the right spot or time?

I was experimenting with it locally yesterday and noticed I had to add a bunch of other methods to get them to work as individual links especially how it behaves in the actual DiscussionListItem component (jumping to the last post of the discussion, being able to go to that users profile by clicking on their username, etc).

askvortsov

Ralkage

Ralkage would you be able to separate the latest discussion widget links into their individual routes?

Apologizes for the ignorance, but could you clarify what you mean by this?

Ralkage Seems as if when I click even on the username it just brings me to the discussion rather than the profile (on mobile anyways)

I think I was able to fix this in the release I made earlier today, and it's working fine on Chrome on Android. Is this still an issue if you clear cache on https://forum.youthneuro.org?

Ralkage jumping to the last post of the discussion,

Yeah this is definitely missing, I'll set that particular link up to go to the most recent post vs just to the discussion (although worth noting that the behavior I have now is how the default Tags grid handles it too, but going to last post is definitely better)

DursunCan

To work compatible with Night Mode by FriendsOfFlarum plugin;
Can you update the plugin or share external CSS codes?

askvortsov

DursunCan Can you update the plugin or share external CSS codes?

Is this happening on hover? If so I'll be able to fix that shortly (I have a suspicion as to whats causing it), if not, I might need more info. Could you send a link to your website?

askvortsov

askvortsov I'll set that particular link up to go to the most recent post vs just to the discussion (although worth noting that the behavior I have now is how the default Tags grid handles it too, but going to last post is definitely better)

This is gonna have to wait until my proposed fix to the tags extension gets merged. I don't want to return contents/info about hidden discussions to the public forum.

DursunCan

askvortsov https://forum.sourceturk.net

askvortsov Is this happening on hover?

yes

askvortsov

DursunCan
Fixed in v0.1.10 (latest version), thanks for reporting!

Kyrne

This is so cool! Awesome work @askvortsov

DursunCan

askvortsov A few more missing caught my attention. The title of the discussion does not appear on the main label. Username is not visible in the sub-tag. Colors are not compatible with night mode and day mode. Note; I do not use colors on the tags.

night mode:

day mode:

JesusIsGodAlmighty

Interesting - cool! The Possibilities... hmmm

askvortsov

DursunCan A few more missing caught my attention. The title of the discussion does not appear on the main label. Username is not visible in the sub-tag.

Huh sorry about that, I was testing with dark mod eon in settings, and it seems like night mode behaves differently, I'll get that all fixed soon.

DursunCan Colors are not compatible with night mode and day mode.

I'm assuming the issue is the off-white background for child tags. If so, I'll see what I can do (I can definitely make it compatible with dark mode, but will need to see how night mode works under the surface). If that's not the issue, please let me know more about the incompatibility

« Previous Page Next Page »