Progressive Web App (PWA) and Push Notifications

askvortsov

[deleted] by any chance, are you using v6 of minishlink? This extension is currently incompatible with that, I'd reccomend downgrading that back to v5

[deleted]

askvortsov I was some time back but downgraded to 5. I've just upgraded to 5.25 (I think) and will see how that goes.

pkernstock

First of all, thanks for this great extension! I think that's a great addition to the other extensions out there.

I've just rolled it out on my forum, however when enabling the Push notifications e.g. on the browser I'm getting a fatal error saying:

Uncaught (in promise) DOMException: Failed to execute 'subscribe' on 'PushManager': The provided applicationServerKey is not encoded as base64url without padding.
    at Q (/assets/forum-35316174.js:1771:12009)
    at /assets/forum-35316174.js:1771:17008

Using PWA 1.0.3 with push-web 5.2.5. Occurring in addPushNotifications.js:11:

const subscribeUser = (save) => {
  return app.sw.pushManager
    .subscribe({ // <-- the function which fails
      userVisibleOnly: true,
      applicationServerKey: app.forum.attribute("vapidPublicKey"), // <--- probably there

Beside that... is there a way to donate a tiny bit to the project? Haven't found something 🙂

askvortsov

pkernstock I've just rolled it out on my forum, however when enabling the Push notifications e.g. on the browser I'm getting a fatal error saying:
Uncaught (in promise) DOMException: Failed to execute 'subscribe' on 'PushManager': The provided applicationServerKey is not

Huh that's odd, haven't seen that one before... Which browser is this?

pkernstock Beside that... is there a way to donate a tiny bit to the project? Haven't found something 🙂

Thanks, I appreciate that! I don't have anything set up, but the flarum project itself could always use donations, as that enables us to support paid development time.

pkernstock

You're responding way too fast. That's scary. 😃

askvortsov don't have anything set up, but the flarum project itself could always use donations

Donating to the whole project is great, but giving something back to individual developers dedicated to their projects is also great 🙂

askvortsov Huh that's odd, haven't seen that one before... Which browser is this?

Google Chrome 84.0.4147.105. So nothing special on that end. I've also seen an JS error being triggered when doing the same on my mobile phone...

Installation
Just in case it depends on how I installed it or any other circumstances:

$ composer -V
Composer version 1.10.10 2020-08-03 11:35:19
$ composer require "askvortsov/flarum-pwa:*"
$ composer require "minishlink/web-push:5" //<- making sure to use compatible v5
$ php flarum migrate
$ php flarum recache:clear
$ php flarum cache:clear
$ php flarum cache:assets --css --js --locales

I've tried removing and re-requiring flarum-pwa once again and used --no-cache to eliminate some factors.

idb.js
When using CTRL-F5, I can see that pulling one specific JS file fails:

sw:1 Uncaught DOMException: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at '/assets/extensions/askvortsov-pwa/idb.js' failed to load.
    at /sw:1:1

And even more interesting:

$ ls public/assets/extensions/askvortsov-pwa/
offline.html  sw.js

It's indeed not there. However on your GitHub/idb.js it's indeed present.

So I was manually pulling it via wget https://raw.githubusercontent.com/askvortsov1/flarum-pwa/master/assets/idb.js -O public/assets/extensions/askvortsov-pwa/idb.js. But unfortunately: No change, even when hard-refreshing the browser.

The key
When using Chrome's DevConsole the PublicKey seems to look like a valid public key indeed: (However appears to be binary data when decoding)

app.forum.attribute("vapidPublicKey")
"BFargahjcHsO1PqaVMe9Sf4rXPfRUCJE1axoBOhm0H29qAoZ0kXIsC9gD++UIKiY9XScrBIM0fApramKOvPXkBo="

Not sure if I've done something wrong on my end.

I very appreciate your reply - thanks! 🙂

askvortsov

Sorry for the delay in responding to y'all, work and beta 14 has been keeping me busy 😃

pkernstock I've tried removing and re-requiring flarum-pwa once again and used --no-cache to eliminate some factors.

Has php flarum cache:clear helped here? Or if you try clicking the "uninstall" button in the extension's settings?

pkernstock When using Chrome's DevConsole the PublicKey seems to look like a valid public key indeed: (However appears to be binary data when decoding)

This is very odd... One thing you could try to do is going into settings in the database, and removing the askvortsov-pwa.vapid.private and askvortsov-pwa.vapid.public entries, then it should regenerate keys. Possibly something messed up there?

pkernstock Call to undefined method Minishlink\WebPush\WebPush::setReuseVAPIDHeaders() in vendor/askvortsov/flarum-pwa/src/Listener/SendPushNotifications.php:96

Make sure you're using minishlink\web-push v5.2.5, looking at the source code, that seems to have the correct source code.

Fantomen Is there any way to implement a pull down to refresh the page?

Does it not currently work? If not, I'll try to include that in the next release.

[deleted] What ahould I do? Is it safe to drop this table and try again? I'm unable to activate extension... Thanks!

Yeah, try that. Nothing mission-critical, although people who have signed up for push notifications won't get any more until they visit the site.

pkernstock

Is there a known compatibility issue with Redis Cache Queues by @luceos?

When running the command (or in the background by systemd) I can see following extremely heavy spam: (after a while)

[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob
[2020-08-12 20:57:23][OBIFT0eYP56ZpY4vIJSiLWFSdz6xxsr9] Processing: Flarum\Notification\Job\SendNotificationsJob

(₃₀ messages per second)

When checking the Flarum logs:

2020-08-12 20:59:49] production.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Minishlink\WebPush\WebPush::setReuseVAPIDHeaders() in vendor/askvortsov/flarum-pwa/src/Listener/SendPushNotifications.php:96
Stack trace:
#0 [internal function]: Askvortsov\FlarumPWA\Listener\SendPushNotifications->handle()
#1 vendor/illuminate/events/Dispatcher.php(379): call_user_func_array()
#2 vendor/illuminate/events/Dispatcher.php(209): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}()
#3 vendor/flarum/core/src/helpers.php(93): Illuminate\Events\Dispatcher->dispatch()
#4 vendor/flarum/core/src/Notification/Job/SendNotificationsJob.php(38): event()
#5 [internal function]: Flarum\Notification\Job\SendNotificationsJob->handle()

This generates about nearly 1 million log messages per 15 minutes:

$ cat storage/logs/flarum-2020-08-12.log | head -n 1 && echo && cat storage/logs/flarum-2020-08-12.log  | wc -l
[2020-08-12 20:47:07] production.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Minishlink\WebPush\WebPush::setReuseVAPIDHeaders() in vendor/askvortsov/flarum-pwa/src/Listener/SendPushNotifications.php:96

737579

And filling the disk with about 3 GB of logs in roughly 8 hours, exceeding disk quota and crash basically everything.

I've been able to reproduce it multiple times. After removing WebPush everything is back to normal and this does not occur anymore.

luceos

pkernstock Is there a known compatibility issue with Redis Cache Queues by @luceos?

Nope. But your issue seems similar to the one @[deleted] reported above.

[deleted]

luceos webpush is working for me since downgrading minishlink to v5.5 but not sure about the logs since because I've not checked.

Fantomen

Is there any way to implement a pull down to refresh the page?

xxwn

askvortsov I have time to test today，removing minishilink v6.0.0 and then installed v5.25, solved！ It's all right now . Thanks for your advice.

[deleted]

I'm getting this error (copied from log)

Next Illuminate\Database\QueryException: SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'edupush_subscriptions' already exists (SQL: create tableedupush_subscriptions(idint unsigned not null auto_increment primary key,endpointvarchar(255) not null,vapid_public_keyvarchar(255) not null,keysvarchar(255) null,expires_attimestamp null,user_idint unsigned not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci' engine = InnoDB) in /home/xxxxxxx/MYSITE/vendor/illuminate/database/Connection.php:664 Stack trace:

What ahould I do? Is it safe to drop this table and try again? I'm unable to activate extension... Thanks!

[deleted]

askvortsov Yeah, try that. Nothing mission-critical, although people who have signed up for push notifications won't get any more until they visit the site.

Thanks, @askvortsov
But it sems that push_subscriptions is empty, nothing to drop MySQL returned an empty result set (i.e. zero rows).

pkernstock

askvortsov removing the askvortsov-pwa.vapid.private and askvortsov-pwa.vapid.public entries, then it should regenerate keys.

This worked out fantastic! No massive log spam as of now, nor JavaScript errors as there were previously. Thanks! 🙂

askvortsov Make sure you're using minishlink\web-push v5.2.5, looking at the source code, that seems to have the correct source code.

I had 5.2.5 installed, as I read earlier comments about issues in later releases.

askvortsov

[deleted] dropping a table isn't the same as deleting all rows. In this case, you DO want to drop it.

[deleted]

askvortsov
Dropped table - still nothing. Reinstalled extension, cleared cache... Problem is still there:

Next Illuminate\Database\QueryException: SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes (SQL: alter table `edupush_subscriptions` add unique `edupush_subscriptions_endpoint_unique`(`endpoint`)) in /home/xxxx/mysite/vendor/illuminate/database/Connection.php:664
Stack trace:
#0 /home/xxxx/mysite/vendor/illuminate/database/Connection.php(624): Illuminate\Database\Connection->runQueryCallback('alter table `ed...', Array, Object(Closure))
#1 /home/xxxx/mysite/vendor/illuminate/database/Connection.php(459): Illuminate\Database\Connection->run('alter table `ed...', Array, Object(Closure))

askvortsov

[deleted] Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes

THat's actually a different issue! See https://discuss.flarum.org/d/24018-looking-for-testers-for-a-push-notifications-extension/15

askvortsov

pkernstock One thing to try if you're still experiencing issues is upgrading to the latest version of askvortsov/flarum-pwa (1.0.4 I believe?).

pkernstock

askvortsov 1.0.4 I believe

$ composer require "askvortsov/flarum-pwa:1.0.4"  --no-cache
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - askvortsov/flarum-pwa v1.0.4 conflicts with minishlink/web-push[v5.2.5].
    - minishlink/web-push v5.2.5 conflicts with askvortsov/flarum-pwa[v1.0.4].
    - askvortsov/flarum-pwa v1.0.4 conflicts with minishlink/web-push[v5.2.5].
    - Installation request for askvortsov/flarum-pwa 1.0.4 -> satisfiable by askvortsov/flarum-pwa[v1.0.4].
    - Installation request for minishlink/web-push 5.2.5 -> satisfiable by minishlink/web-push[v5.2.5].

According to your composer.json:

  "conflict": {
    "minishlink/web-push": "<=5.2.5 || >=6"
  },

I believe this be something like >5.2.5 instead?

askvortsov

pkernstock oh no..... I can't believe I've done that... 🤣

« Previous Page Next Page »