Progressive Web App (PWA) and Push Notifications

rafaucau

askvortsov rafaucau Today I also have these errors in the logs.

Regarding the link problem, I found the cause. The problem is in this line: https://github.com/askvortsov1/flarum-pwa/blob/master/src/PushSender.php#L155
When I change it to $subjectModel = $blueprint::getSubjectModel();, then the link works. However, there is still a problem rather with the $subject variable. The notification has no content.

Maybe it will be better to talk on Disord? My nickname: Rafau#0221. I would be happy to help you fix this extension.

askvortsov

rafaucau i will reach out on Discord. I'll try to work on both of these sometime this coming week, as i have the last finals of my last semester coming up soon.

CyberGene in line with this, I'll also be trying to test out stuff with iOS.

CyberGene

Using the latest version I finally managed to make notifications work but only on Firefox for Mac. Still no notifications in Safari on either macOS or iOS 😕

askvortsov

v3.3.1

Includes some fixes for post-related notifications and PHPStan static analysis by @rafaucau, thank you so much!

llaumgui Is it possible to disable all push notification by default ?

Implemented this; there's now a setting in admin.

CyberGene Using the latest version I finally managed to make notifications work but only on Firefox for Mac. Still no notifications in Safari on either macOS or iOS 😕

I'll try to keep working on this. My old ipad is stuck forever on the iOS version below that which adds push notifications, so I'll need to get my hands on another device.

mip001

Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in /www/wwwroot/flarum/vendor/askvortsov/flarum-pwa/src/Util.php on line 20

Fatal error: Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in /www/wwwroot/flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:20 Stack trace: #0 /www/wwwroot/flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(42): Laminas\HttpHandlerRunner\Exception\EmitterException::forOutputSent() #1 /www/wwwroot/flarum/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(21): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->assertNoPreviousOutput() #2 /www/wwwroot/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(75): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->emit() #3 /www/wwwroot/flarum/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #4 /www/wwwroot/flarum/public/index.php(26): Flarum\Http\Server->listen() #5 {main} thrown in /www/wwwroot/flarum/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php on line 20

When I enable this extension, the entire site will no longer work, with error messages on it.

And after removing PWA and re-activating with composer require askvortsov/flarum-pwa --with-all-dependencies, it does no difference. And there comes to another warning when clearing cache:


Warning: "resource" is not a supported builtin type and will be interpreted as a class name. Write "\Safe\resource" or import the class with "use" to suppress this warning in /www/wwwroot/flarum/vendor/thecodingmachine/safe/generated/sockets.php on line 797
PHP Warning:  "integer" will be interpreted as a class name. Did you mean "int"? Write "\Safe\integer" or import the class with "use" to suppress this warning in /www/wwwroot/flarum/vendor/thecodingmachine/safe/generated/swoole.php on line 17

Warning: "integer" will be interpreted as a class name. Did you mean "int"? Write "\Safe\integer" or import the class with "use" to suppress this warning in /www/wwwroot/flarum/vendor/thecodingmachine/safe/generated/swoole.php on line 17

My php version is 8.1.13, how can I do for it?

Sorry for the bad English 🙁

clarkwinkelmann

mip001 you can modify your server php.ini settings to disable display_errors. You'll see that Off is the recommended value for use on production environments.

Those warnings/deprecations should not prevent Flarum to run as long as you configure PHP to not write the "error" text into the page output.

mip001

It works! I'm sorry for my foolishness. Thank you very much for your help!

llaumgui

I observe a problem on my board. By default, several pushes was enabled and need to validate browser authorizations... Before this validation, member see a warning to bottom left.

Some member doesn't have knowledge of PWA. Is it possible to disable all push notification by default ?

askvortsov

v3.3.2

Fixed a potential bug with the topic option. I've now tested on a live site and (desktop) Safari, and this fixes some push notifications not being sent.

Please update and let me know if you still experience issues

CyberGene

askvortsov I can finally receive notifications on the iPhone 🥳 Thank you very much!

For anyone interested, for this to work you need to open your Flarum forum in Safari and then add the page to the Home Screen through the share menu. This makes it like a separate app on the iPhone and is where push notifications are supported. However push notifications are not supported in Safari by itself.

However I have a new “problem” now. There’s no refresh button in the Home Screen app (because I use Pusher) but there’s no way to refresh the page either. Anyone knows how this can be fixed? Any CSS to bring back the refresh button? Or any CSS that would allow the Home Screen app to enable pull to refresh?

Subarist

Starting from version 3.14 + , I have been consistently encountering the following 500 errors:

Error: Call to undefined function Askvortsov\FlarumPWA\Api\Controller\fnmatch() in /www/wwwroot/flarum/vendor/askvortsov/flarum-pwa/src/Api/Controller/AddPushSubscriptionController.php:80
Stack trace:
#0 /www/wwwroot/flarum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(116): Askvortsov\FlarumPWA\Api\Controller\AddPushSubscriptionController->data()
#1 /www/wwwroot/flarum/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(22):

Flarum core: 1.7.2
PHP version: 8.2.4
MySQL version: 8.0.33
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, ctype, curl, dom, filter, ftp, gd, gettext, hash, iconv, intl, json, mbstring, SPL, session, pcntl, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, random, Reflection, mysqli, shmop, SimpleXML, soap, sockets, sodium, sysvsem, tokenizer, xml, xmlreader, xmlwriter, zip, fileinfo, memcached, redis, exif, gmp, Zend OPcache
+-------------------------------------+---------------+--------+
| Flarum Extensions                   |               |        |
+-------------------------------------+---------------+--------+
| ID                                  | Version       | Commit |
+-------------------------------------+---------------+--------+
| flarum-markdown                     | v1.7.0        |        |
| flarum-flags                        | v1.7.0        |        |
| flarum-suspend                      | v1.7.0        |        |
| askvortsov-rich-text                | v2.1.7        |        |
| flarum-tags                         | v1.7.1        |        |
| flarum-lock                         | v1.7.0        |        |
| flarum-sticky                       | v1.7.0        |        |
| fof-formatting                      | 1.0.3         |        |
| afrux-forum-widgets-core            | v0.1.7        |        |
| fof-oauth                           | 1.3.0         |        |
| flarum-nicknames                    | v1.7.0        |        |
| fof-spamblock                       | 1.1.0         |        |
| fof-pages                           | 1.0.5         |        |
| flarum-approval                     | v1.7.0        |        |
| sycho-advanced-extension-categories | v0.1.3        |        |
| zequeen-acgembed-remastered         | v1.1.2        |        |
| v17development-seo                  | v1.8.0        |        |
| v17development-blog                 | v0.6.5        |        |
| the-turk-stickiest                  | 3.0.1         |        |
| sycho-profile-cover                 | v1.3.3        |        |
| sycho-lite-youtube                  | v0.1.1        |        |
| rob006-last-post-avatar             | 1.2.4         |        |
| pipecraft-id-slug                   | v1.1.0        |        |
| nearata-tags-color-generator        | v2.2.0        |        |
| malago-fancybox                     | 0.3.0         |        |
| justoverclock-hashtag               | 1.0.1         |        |
| justoverclock-custom-html-widget    | 0.1.4         |        |
| justoverclock-country-flags         | 0.2.1         |        |
| justoverclock-contactme             | 0.2.3         |        |
| ianm-oauth-line                     | 0.1.4         |        |
| ianm-html-head                      | 1.1.0         |        |
| fof-username-request                | 1.1.2         |        |
| fof-user-directory                  | 1.2.3         |        |
| fof-user-bio                        | 1.1.1         |        |
| fof-upload                          | 1.2.3         |        |
| fof-stopforumspam                   | 1.2.3         |        |
| fof-socialprofile                   | 1.1.5         |        |
| fof-sitemap                         | 2.1.0         |        |
| fof-share-social                    | 1.1.2         |        |
| fof-profile-image-crop              | 1.1.1         |        |
| fof-pretty-mail                     | 1.1.1         |        |
| fof-nightmode                       | 1.5.1         |        |
| fof-merge-discussions               | 1.3.1         |        |
| fof-links                           | 1.1.4         |        |
| fof-drafts                          | 1.2.2         |        |
| fof-default-user-preferences        | 1.2.0         |        |
| fof-best-answer                     | 1.2.5         |        |
| fof-analytics                       | 1.1.0         |        |
| flarumtr-mobile-search              | v1.2          |        |
| flarum-subscriptions                | v1.7.0        |        |
| flarum-statistics                   | v1.7.0        |        |
| flarum-pusher                       | v1.7.0        |        |
| flarum-package-manager              | v1.0.0-beta.2 |        |
| flarum-mentions                     | v1.7.0        |        |
| flarum-likes                        | v1.7.0        |        |
| flarum-lang-english                 | v1.7.0        |        |
| flarum-lang-chinese-traditional     | v1.10.0       |        |
| flarum-lang-chinese-simplified      | v1.3.0        |        |
| flarum-emoji                        | v1.7.0        |        |
| flarum-bbcode                       | v1.7.0        |        |
| extiverse-mercury                   | 0.2.0         |        |
| davwheat-ads                        | 1.2.0         |        |
| datlechin-silent-edit               | v0.1.0        |        |
| datlechin-scroll-buttons            | v1.1.0        |        |
| datlechin-posted-on                 | v0.1.6        |        |
| datlechin-link-preview              | v1.3.2        |        |
| datlechin-chatgpt                   | v0.2.0        |        |
| clarkwinkelmann-scout               | 0.3.5         |        |
| clarkwinkelmann-first-post-approval | 1.0.1         |        |
| clarkwinkelmann-emojionearea        | 1.0.0         |        |
| clarkwinkelmann-author-change       | 1.0.3         |        |
| cccyun-clogin-oauth                 | v1.0.2        |        |
| blomstra-turnstile                  | 0.1.2         |        |
| blomstra-spam-prevention            | 1.3.1         |        |
| blomstra-fontawesome                | 0.1.5         |        |
| blomstra-database-queue             | 0.1-beta.2    |        |
| askvortsov-pwa                      | v3.3.2        |        |
| askvortsov-markdown-tables          | v1.2.1        |        |
| afrux-online-users-widget           | v0.1.6        |        |
| afrux-forum-stats-widget            | v0.1.1        |        |
| afrux-asirem                        | v0.1.7        |        |
| acpl-mobile-tab                     | 1.1.1         |        |
+-------------------------------------+---------------+--------+
Installation path: /www/wwwroot/flarum
Queue driver: database
Session driver: file
Scheduler status: 啟用
Mail driver: smtp
Debug mode: ON

Don't forget to turn off debug mode! It should never be turned on in a production system.

askvortsov

Subarist Looks like you might be hosting on some non-POSIX system, where fnmatch isn't available?

Either way, should be fixed in v3.3.0

Subarist

askvortsov
Thanks, V3.3.3 works.
In fact, since 2022 till now, this is the first time I get PWA notification ^^

rafaucau

@askvortsov There's still an issue with the notification content. When a new post appears, the notification content always displays the content of the first post in the discussion. I haven't been able to determine why this is happening yet.

CyberGene

@askvortsov , is it possible to apply some modifications to the manifest.json? I am not really sure, just guessing but I think changing the "display" property in the manifest may fix the issue of not being able to refresh the forum when it's pinned to the home screen on iOS. I don't know what the current value is but I would assume it's standalone since I see no browser or navigation controls and puling the page down doesn't refresh the page (which is a default behavior of Safari). I guess if the display mode is changed to minimal-ui or even browser, then pulling down would refresh the view or even show the standard browser refresh button. Is there any way that I can update that manually or probably to update the extension to allow a configuration of the display mode in the manifest.json (which I assume is generated on the fly, rather than being stored statically as a resource because I don't find one).

P.S. I checked out the extension code and I see that you expect standalone in some if-else statements and apply functionality that is apparently targeted for when the forum is being viewed in standalone mode, and so it's probably not a good idea to mess-up with the display property. In that case, is it possible that you add a refresh functionality/button when in standalone mode, i.e. when we're in a mobile app mode? Currently the standalone app is unusable on iPhone when Pusher is enabled because there's no way to refresh the forum.

samus14

Hi! I've successfully installed the extension, but I can't activate it.

When I try to enable in my admin dashboard by clicking the slider, it goes to green, pauses for a second, then slides back over to the grey/off position.

Can anyone help? I must be missing something, some dependency or requirement...

pwFoo

Installed the extension first time with a new flarum 1.8 docker installation... seems to work.

Some ideas for improvements...

Status warning about HTTP instead of HTTPS with a SSL offloading reverse proxy
I need to upload each image size... would it possible to generate the needed images from one uploaded image instead of upload multiple images?
I don't know if related to mail or push notification, but save reply was delayed some seconds?
Without uploaded image replies are saved, but an error is shown. No helping error message is shown
Link should take the user to the new reply instead of topic top / frist post.

@askvortsov Awesome extension!!! Should be added here too!

Darkle

I noticed something interesting, why does it take so long to generate the webmanifest? It seems to take so long because it is generated from scratch in each request(?), in fact when the client is far away from the source it can take around 500-600ms, which is quite long considering that it is around 4 lines of plain text.

Wouldn't it be better to generate a static copy in cache? as new changes to the webmanifest are almost never made.

VittorioTomasi

hello,
i have installed l PWA plugin but when i try to enable it in backend i get this error:

023-07-15 18:46:14] flarum.ERROR: ParseError: syntax error, unexpected 'Queue' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/websites/forum/vendor/askvortsov/flarum-pwa/src/PushNotificationDriver.php:25
Stack trace:
#0 /var/websites/forum/vendor/composer/ClassLoader.php(427): Composer\Autoload{closure}('/var/websites/f...')
#1 [internal function]: Composer\Autoload\ClassLoader->loadClass('Askvortsov\Flar...')
#2 [internal function]: spl_autoload_call('Askvortsov\Flar...')
#3 /var/websites/forum/vendor/illuminate/container/Container.php(877): ReflectionClass->__construct('Askvortsov\Flar...')
#4 /var/websites/forum/vendor/illuminate/container/Container.php(758): Illuminate\Container\Container->build('Askvortsov\Flar...')
#5 /var/websites/forum/vendor/illuminate/container/Container.php(694): Illuminate\Container\Container->resolve('Askvortsov\Flar...', Array)
#6 /var/websites/forum/vendor/flarum/core/src/Notification/NotificationServiceProvider.php(52): Illuminate\Container\Container->make('Askvortsov\Flar...')
#7 /var/websites/forum/vendor/flarum/core/src/Notification/NotificationServiceProvider.php(42): Flarum\Notification\NotificationServiceProvider->setNotificationDrivers(Object(Illuminate\Container\Container))
#8 /var/websites/forum/vendor/illuminate/container/BoundMethod.php(36): Flarum\Notification\NotificationServiceProvider->boot(Object(Illuminate\Container\Container))
#9 /var/websites/forum/vendor/illuminate/container/Util.php(40): Illuminate\Container\BoundMethod::Illuminate\Container{closure}()
#10 /var/websites/forum/vendor/illuminate/container/BoundMethod.php(93): Illuminate\Container\Util::unwrapIfClosure(Object(Closure))
#11 /var/websites/forum/vendor/illuminate/container/BoundMethod.php(37): Illuminate\Container\BoundMethod::callBoundMethod(Object(Illuminate\Container\Container), Array, Object(Closure))
#12 /var/websites/forum/vendor/illuminate/container/Container.php(653): Illuminate\Container\BoundMethod::call(Object(Illuminate\Container\Container), Array, Array, NULL)
#13 /var/websites/forum/vendor/flarum/core/src/Foundation/Application.php(290): Illuminate\Container\Container->call(Array)
#14 /var/websites/forum/vendor/flarum/core/src/Foundation/Application.php(273): Flarum\Foundation\Application->bootProvider(Object(Flarum\Notification\NotificationServiceProvider))
#15 [internal function]: Flarum\Foundation\Application->Flarum\Foundation{closure}(Object(Flarum\Notification\NotificationServiceProvider), 19)
#16 /var/websites/forum/vendor/flarum/core/src/Foundation/Application.php(274): array_walk(Array, Object(Closure))
#17 /var/websites/forum/vendor/flarum/core/src/Foundation/InstalledSite.php(151): Flarum\Foundation\Application->boot()
#18 /var/websites/forum/vendor/flarum/core/src/Foundation/InstalledSite.php(82): Flarum\Foundation\InstalledSite->bootLaravel()
#19 /var/websites/forum/vendor/flarum/core/src/Http/Server.php(59): Flarum\Foundation\InstalledSite->bootApp()
#20 /var/websites/forum/vendor/flarum/core/src/Http/Server.php(36): Flarum\Http\Server->safelyBootAndGetHandler()
#21 /var/websites/forum/public/index.php(26): Flarum\Http\Server->listen()
#22 {main}

I Use PHP 7.3.33 and flarum 1.8.1. maybe the php version is the problem?
I uninstalled all plugins and tried to enable pwa plugin with the same error result

askvortsov

VittorioTomasi probably, PHP 7.3 has been EOL for quite a bit now

« Previous Page Next Page »