Suspend permanently text

[deleted]

This is great but would be good if it would say that the account was suspended permanently instead of max 18 years

Pollux

Some translations allow singular and plural forms separated by a pipe symbol. In the case of suspensions, we could similarly provide for the two cases of suspensions (18 years, <18 years):

user_suspended_text: "{username} suspended you permanently|{username} suspended you for {timeReadable}"

luceos

Suspending someone permanently will set her "suspended_at" to now + something (18) years. It's not the best solution, but it does work. An alternative solution would be to rename suspended_at to suspended and allow that to be either a boolean true or a date.

clarkwinkelmann

Pollux I don't think this is relevant to the technical side of the issue here. The fix would be to either show "18+" (or was it a hard-coded year in the future?) as "permanent" or change the way we store the suspend status to actually be able to store "permanent".

In any case the "permanent" text should be its own translation if we want to stay compatible with the Symfony translation syntax. The pipe syntax is only for singular-plural rules.

jordanjay29

clarkwinkelmann The fix would be to either show "18+" (or was it a hard-coded year in the future?) as "permanent" or change the way we store the suspend status to actually be able to store "permanent".

Well, the code shows that it will suspend until the year 9999, it looks like the notification simply stops counting after 18 years. Looking at a suspended user, the count in the suspend modal gets stuck permanently at 6469 days and doesn't decrease.

EDIT: this code is why it stops counting at 18 years. This is probably what needs adjusting as well.