Fix (maybe) for new registration username!

TOWUK_ru

I am testing flarum and see "bug",
i dont register user with name "test name", space dont correct in name, maybe add space in config:
DIR: flarum\vendor\flarum\core\src\User\UserValidator.php

before:

44.         return [
45.             'username' => [
46.                 'required',
47.                 'regex:/^[a-z0-9_-]+$/i',
48.                 'unique:users,username'.$idSuffix,
49.                 'min:3',
50.                 'max:30'
51.             ],

after:

44.         return [
45.             'username' => [
46.                 'required',
47.                 'regex:/^[a-z 0-9_-]+$/i',
48.                 'unique:users,username'.$idSuffix,
49.                 'min:3',
50.                 'max:30'
51.             ],

screens:

askvortsov

The username only supports the characters it supports as a design decision: you can definitely modify the Validator, but allowing other characters will likely unexpectedly break other functionality.

TOWUK_ru

askvortsov just wanted register users with 2nd words like "TOWUK test" (and not "TOWUKtest")

askvortsov

I understand that, and you are certainly free to do so. But keep in mind that some parts of your site (profile pages and mentions, most likely) might break / not work as expected. Right now, we recommend using a nickname extension instead of changing the Validator.

TOWUK_ru

askvortsov okay, get me link please on this EXT flarum, i d k this

Kylo

askvortsov @TOWUK_ru FYI that extension also has the possibility of beaking things. It's not compatible with the Diff extension and may cause issues while using with another ones.

askvortsov

https://discuss.flarum.org/d/21238-nickname-changer

askvortsov

Good point. Better support for display names is planned, as per flarum/core557