Looking for testers for a Push Notifications extension

askvortsov

Hi everyone!

I've recently been working on a push notifications addition to my Progressive Web App extension to be released within the next few days. This system:

Does not use any external providers, and works directly with the browser push services
Can be enabled by users per-notification-category
Does not require any API keys or subscriptions
Will be free

That being said, if anyone is interested in testing it out and giving feedback, I would very much appreciate it! You can reach out to me via discord at askvortsov#3485.

[deleted]

askvortsov count me in

askvortsov

Hi everyone! I've tagged v1.0.0-beta.1 as a beta for push notifications, you can install it with composer require askvortsov/flarum-pwa:v1.0.0-beta.1. Please note that you'll also need to install the php web push library (composer require minishlink/web-push) for the push notifications feature to work. PWA will work without it, but push requires it.

Ralkage

askvortsov maybe add the package to the suggested packages in the composer.json? You can also add a note along side the package as it’s value 🙂

https://getcomposer.org/doc/04-schema.md#suggest

askvortsov

Already done 😃 Plus, there'll be a message in the status code section if it's missing.

askvortsov

v1.0.0-beta.2 fixes notifications about posts not linking to those specific posts.

v1.0.0-beta.4 fixes some mobile bugs

Operator

Hi askvortsov ,

There is a bug when admin tries to enable the extension, this bug has kept me out from testing the extension for the past days, I thought it was a problem on my end that is why I have not reported earlier.

I believe those who have tested it, just upgraded from an activated version lower than or equal to v0.1.5.

The Problem:
I have v0.1.5 installed, so I disable it in the admin panel then I run composer require askvortsov/flarum-pwa. Installation runs successfully but when I want to enable the extension an error occurs which says "Oops! Something went wrong. Please reload the page and try again." And the extension is not enabled.

However, if I leave the v0.1.5 enabled and run the upgrade the extension remains enabled and I am able to use it. But, if i deactivate the v1.0.0 upgrade of the extension, the problem resumes, and I would not be able to enable the extension as the error occurs which says "Oops! Something went wrong. Please reload the page and try again." And the extension is not enabled.

ornanovitch

I'm testing it and it seems to work fine with my firefox, great work thank you !

Only a question : is it supposed to work also for the "autorefresh" notification (show direct notifications on the page) ? That's what I thought first but I think I misunderstood

askvortsov

ornanovitch Hi, thank you for trying it out! Could you clarify what you mean by 'autorefresh'? This isn't a term I've come across while researching the web push API. If it's feasible to implement, I'll definitely try!

ornanovitch

askvortsov Hi, thank you for trying it out! Could you clarify what you mean by 'autorefresh'? This isn't a term I've come across while researching the web push API. If it's feasible to implement, I'll definitely try!

I was talking about that kind of pusher :
screenshot
But I guess I didn't understood precisely the project.

Concerning the tests I've made : all good so far ! Perfect on firefox 76 (PC), perfect on chrome (on mobile). Perfect when the browser doesn't handle the push (it just add a little warning in the user preferences). I just have misbehavior with kiwi browser which is yet chromium-based : the "opt-in" button to allow notifications doesn't do anything. I'm trying to figure out if it's because of my browser configuration or something else. But as it's working on chrome I guess it's not due to your extension.

askvortsov

Operator Here's a slightly more detailed list of installation steps, please let me know if these fix the issue:

composer require askvortsov/flarum-pwa:v1.0.0-beta.4
composer require minishlink/web-push
php flarum migrate
php flarum cache:clear

You also need to disable and re-enable the extension in admin settings so that one of the files registers properly

Operator

Thanks for your reply askvortsov
But,

Migrating extension: askvortsov-pwa

In Connection.php line 664:

  SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes (SQL: alter table
   `flarumforum_push_subscriptions` add unique `flarumforum_push_subscriptions_endpoint_unique`(`endpoint`))


In PDOStatement.php line 129:

  SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes


In PDOStatement.php line 127:

  SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes

and when i try to run php flarum migrate again it says Nothing to migrate. for all extensions with DB access and then this, but askvortsov-pwa is not listed among the extensions.

Nothing to migrate.
Publishing assets...
DONE.

askvortsov

Operator 071 Specified key was too long; max key length is 767 bytes

Looks like your database prefix makes the DB key too long. You might want to upgrade your MySQL version, or tweak your DB config to avoid this. You can rollback the migration with `php flarum migrate:reset --extension askvortsov-pwa.

ornanovitch I was talking about that kind of pusher :

Ah, I see. This isn't the goal of this project, but it's certainly possible to create an extension that makes incoming alerts more prominent.

ornanovitch I just have misbehavior with kiwi browser which is yet chromium-based : the "opt-in" button to allow notifications doesn't do anything.

When using Kiwi, is there a message in the user's notification settings that push notifications aren't available on their device?

huuduy216 Works great on chrome mobile. No notification on PC though?

[deleted] Yeah - same for me @askvortsov

Should be... Did you enable it on desktop too? Which browser?

huuduy216 Another question that I have is the notification are not showing the app's icon. It's showing the default "bell" icon.

Do you mean the row of icons in the very top bar of your device, or the big icon next to the notification? The big icon next to the notification should match your site's favicon, although that isn't supported on some browsers (mostly chrome). If you mean the row of icons on the top bar of your device, that's not implemented, and when implemented, would only supported by chrome on mobile.

huuduy216

Works great on chrome mobile. No notification on PC though?

[deleted]

huuduy216 Works great on chrome mobile. No notification on PC though?

Yeah - same for me @askvortsov

huuduy216

Another question that I have is the notification are not showing the app's icon. It's showing the default "bell" icon. Is that something wrong with my setup or you haven't implement it yet?

askvortsov

[deleted] Could be related to brave/brave-browser2362.

huuduy216 are you also using Brave?

[deleted]

askvortsov Should be... Did you enable it on desktop too? Which browser?

Yeah, Brave with shields off. Might need to take another look at this and get console output.

ornanovitch

askvortsov When using Kiwi, is there a message in the user's notification settings that push notifications aren't available on their device?

Nope, but I have this message on another mobile browser (LineageOS Jelly Browser), which means that this prevention functionality seems to work fine. As Kiwi is based on Chromium, I guess it should work. I'll try on another smartphone with Kiwi if I have the opportunity to !

askvortsov Ah, I see. This isn't the goal of this project

No problem, that's what I thought !

Operator

Thank you @askvortsov Problem Solved.

Uninstall > Remove > Clear Cache > Install

And everything is working fine. 👏🏽👍🏽

huuduy216

askvortsov
I re-tested on another PC, so far it seems like Firefox is not working. Chrome works well, though it did miss a couple of notification 🤔

Haven't had a chance, but does this work on iOS? I don't think PWA works on iOS yet right? Even though I recall reading Safari support web push somewhere 🤷