First Post Approval

clarkwinkelmann

Version 0.1.2 has been released with support for Flarum beta 14.

peopleinside

clarkwinkelmann I still get error, maybe need some time?
https://discuss.flarum.org/d/25184-issues-on-upgrading/2

MikeJones

Just stopped my first piece of spam with this fantastic extension, I feel so vindicated that the spammers post never made it live on my site :-)

clarkwinkelmann

It took a while, but someone finally spammed my little unknown forum again! So I have finally seen my extension work for the first time on real data, hurray 😃

MikeJones

clarkwinkelmann its such a good feeling :-)

peopleinside

clarkwinkelmann this extension is very useful. Thank you to have updated for Beta 15!
Happy Holidays! 🎁🎄

clarkwinkelmann

Release 0.1.3

Added Flarum beta 15 compatibility. This update should automatically be installed when you update Flarum.

Pollux

@clarkwinkelmann

I'm not sure whether this is Byobu's fault or First Post Approval's (although I suspect the latter), but if you use both extensions together I observe the following problem:

If user A starts a private discussion with user B and A is in the position to need approval, this discussion is shown in admin's folder 'Private Discussions' as well. I assume everyone with the priviledge to approve posts can see these private discussions. In addition, these private posts awaiting approval show only the buttons 'Delete' and 'Dismiss Flag'. The 'Approve' button is shown only if admin is an intended recipient of the PM.

The Flarum/Approval extension doesn't show this behaviour, private messages are never subjected to approval.

A second issue not related to Byobu: Posts awaiting approval aren't shown in the 'All Discussions' page, neither as answers nor as new discussions. They are only shown in their respective tag pages. Is this on purpose?

clarkwinkelmann

Pollux I have never tested the two extensions together, so whatever is happening, it's not intentional.

If someone wants to sponsor some time for me to test and make the two extensions work together that would be great. Right now we should assume the two extensions don't work together.

If we were to introduce compatibility, this raises questions about the desired implementation. Should those post be approved? Should private discussions be disabled until the approval requirement is met, etc...

The fact the discussion appears to admins is probably due to a Byobu feature. I remember flagged posts become visible to moderators, so this must be what is happening here. Not sure if the lack of option to approve is in a bug caused by this extension or approval/byobu.

Pollux

clarkwinkelmann Should those post be approved? Should private discussions be disabled until the approval requirement is met, etc...

As I mentioned Flarum's own Approval extension doesn't apply the approval process to private discussions, and that's how I think it should be. It would make sense though to have an option to not allow opening private discussions while in the approval phase.

The second issue seems to be independent from Byobu. First Post Approval act's differently from Flarum/Approval in regard to the inclusion of yet unapproved posts / discussions on the All Discussions page for those who are tasked to approve them.

JAC

This seems to make me approve all users posts, say they register I approve the first one and then they do another post I have to approve that too and the third etc?

I thought it would just be approving people once and then they can post as they like?

[deleted]

JAC check the permissions you have for posting in the core (under admin->permissions). It could be the case that you have this set to approval required rather than allow to post.

JAC

(
(

I still have this enabled.

The admin (Jon )post is being moderated when I upvote or like a post from another user its flagged to be moderated.

What I want is for the first post to be approved and then the user is free to post all they like 🙂

what settings do I need to enable to achieve this?

Thanks

clarkwinkelmann

JAC I don't understand what exactly happens in what order.

Do you have exact steps I can follow to reproduce, or is this a one-off issue?

What is "Auto Moderator" which is listed in the title of the flag? Is it a custom translation for "Pending approval"?

Was the admin post flagged right after it was created, or did it happen as the result of another action?

JAC

clarkwinkelmann The actions seem to happen when I edit or like or upvote another person's post.

The auto moderator seems to flag this up even on admin posts, so I can post something fine and then if I upvote someone else post it will send their post for approval although it's already been approved.

clarkwinkelmann

JAC but what is "auto moderator"? That word doesn't exist in Flarum core or this extension.

JAC

I don't know what that is, I guessed it was something to do with the first approval extension? Is it not? 😛

Unless it is to do with other permissions.

clarkwinkelmann

JAC can you share the output of your php flarum info ?

clarkwinkelmann

Released version 0.1.4 with Flarum beta 16 compatibility.

peopleinside

clarkwinkelmann thank you! Very happy to see this update!

Kulga

MikeJones

clarkwinkelmann Released version 0.1.4 with Flarum beta 16 compatibility.